Skip to contentSkip to conversation

ALSA: HDA: Add new revision for ALC662

PATCH In review David Henningsson 2 participants 2 messages Oct 19, 2011 – Oct 24, 2011 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: HDA: Add new revision for ALC662

We found a new chip, with Vendor Id: 0x10ec0662 and Revision Id: 0x100300. It seems to work well with patch_alc662, but I don't know if patch_alc882 had been better, and actually, I don't know if there's much of a difference between the two patch functions these days anyway.

I'm cc:ing Kailang in case there's more to it (codec renaming, processing coefficients etc) that we don't know of.

Signature · 2 lines
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
Quoted 1 line

From 8820c37abd6b093f2cf61787b8e2abf64166c53e Mon Sep 17 00:00:00 2001

From: David Henningsson <[email protected]>
Date: Tue, 18 Oct 2011 14:07:51 +0200
Subject: [PATCH] ALSA: HDA: Add new revision for ALC662

The revision 0x100300 was found for ALC662. It seems to work well with patch_alc662.

---
 sound/pci/hda/patch_realtek.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/pci/hda/patch_realtek.c +2 -0
index f9d24c3..86ecc72 100644
@@ -5774,6 +5774,8 @@ static const struct hda_codec_preset snd_hda_preset_realtek[] = {
 	  .patch = patch_alc882 },
 	{ .id = 0x10ec0662, .rev = 0x100101, .name = "ALC662 rev1",
 	  .patch = patch_alc662 },
+	{ .id = 0x10ec0662, .rev = 0x100300, .name = "ALC662 rev3",
+	  .patch = patch_alc662 },
 	{ .id = 0x10ec0663, .name = "ALC663", .patch = patch_alc662 },
 	{ .id = 0x10ec0665, .name = "ALC665", .patch = patch_alc662 },
 	{ .id = 0x10ec0670, .name = "ALC670", .patch = patch_alc662 },
Signature · 1 line
1.7.5.4
#1 lore raw

At Wed, 19 Oct 2011 11:50:11 +0200,

Quoted 8 lines · David Henningsson

We found a new chip, with Vendor Id: 0x10ec0662 and Revision Id:
0x100300. It seems to work well with patch_alc662, but I don't know if patch_alc882 had been better, and actually, I don't know if there's much of a difference between the two patch functions these days anyway.

I'm cc:ing Kailang in case there's more to it (codec renaming, processing coefficients etc) that we don't know of.

OK, now I committed with the ack by Kailang.

thanks,

Takashi