Skip to contentSkip to conversation

Gerrit for BR

RFC Yegor Yefremov 6 participants 9 messages Oct 20, 2011 – Oct 21, 2011

lore
Share & tools
lore
#2 lore raw
In reply to Yegor Yefremov

Le Thu, 20 Oct 2011 16:11:54 +0200,
Yegor Yefremov <[email protected]> a ?crit :

Quoted 1 line

What do you think about using Gerrit (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects seem to switch to this system.

How does it compare to patchwork (http://patchwork.ozlabs.org/) ? Patchwork works in relation to a mailing-list, from which it automatically picks up patches and related review comments, and it allows maintainers to track which patches have been applied/not applied.

How does Gerrit work in that respect?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw
Quoted 11 lines · Thomas Petazzoni

Le Thu, 20 Oct 2011 16:11:54 +0200,
Yegor Yefremov <[email protected]> a ?crit :

Quoted 1 line

What do you think about using Gerrit (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects seem to switch to this system.

How does it compare to patchwork (http://patchwork.ozlabs.org/) ? Patchwork works in relation to a mailing-list, from which it automatically picks up patches and related review comments, and it allows maintainers to track which patches have been applied/not applied.

How does Gerrit work in that respect?

Just supplying some background on how gerrit is used with android:

http://source.android.com/source/life-of-a-bug.html
http://source.android.com/source/life-of-a-patch.html

Quoted 10 lines

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-Bryan

#4 lore raw
Quoted 12 lines · Bryan Hundven
Quoted 10 lines · Thomas Petazzoni

Le Thu, 20 Oct 2011 16:11:54 +0200,
Yegor Yefremov <[email protected]> a ?crit :

Quoted 1 line

What do you think about using Gerrit (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects seem to switch to this system.

How does it compare to patchwork (http://patchwork.ozlabs.org/) ? Patchwork works in relation to a mailing-list, from which it automatically picks up patches and related review comments, and it allows maintainers to track which patches have been applied/not applied.

Quoted 6 lines
Quoted 1 line

How does Gerrit work in that respect?

Just supplying some background on how gerrit is used with android:

http://source.android.com/source/life-of-a-bug.html
http://source.android.com/source/life-of-a-patch.html

imo, it's what works for the project.
It seems to me that patchwork works for this project. Unless there is a problem wrt using patchwork.

Quoted 13 lines
Quoted 10 lines

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-Bryan

#5 lore raw
In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 3 lines
Quoted 3 lines

What do you think about using Gerrit
(http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects seem to switch to this system.

Thomas> How does it compare to patchwork (http://patchwork.ozlabs.org/)
Thomas> ? Patchwork works in relation to a mailing-list, from which it Thomas> automatically picks up patches and related review comments, and Thomas> it allows maintainers to track which patches have been Thomas> applied/not applied.

Thomas> How does Gerrit work in that respect?

I don't have any hands on experience (but I am following the openocd list, so I see it used), and my initial feeling is that something like patchwork would fit better our current way of working.

But that's just an initial feeling, let's discuss at ELC and/or here on the list.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

Am 21.10.2011 09:49, schrieb Peter Korsgaard:

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 3 lines
Quoted 3 lines

What do you think about using Gerrit
(http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects seem to switch to this system.

Thomas> How does it compare to patchwork (http://patchwork.ozlabs.org/)
Thomas> ? Patchwork works in relation to a mailing-list, from which it Thomas> automatically picks up patches and related review comments, and Thomas> it allows maintainers to track which patches have been Thomas> applied/not applied.

Quoted 8 lines

Thomas> How does Gerrit work in that respect?

I don't have any hands on experience (but I am following the openocd list, so I see it used), and my initial feeling is that something like patchwork would fit better our current way of working.

But that's just an initial feeling, let's discuss at ELC and/or here on the list.

Peter, you just mentioned yourself, that you're following openocd list. Please see this thread for pros contra etc.
http://www.mail-archive.com/openocd-development at lists.berlios.de/msg18509.html

As far as I understand Gerrit integrates very good with Git and when used properly and by all contributors, you'll have all the patches in one place. The patches can be then commented online and you'll also get history for reworked patches. As soon as patches are verified, maintainer (you :-) ) can merge them with one click. These were the benefits Gerrit would bring Buidroot community. I think such approach makes sense, since lots of patches will be sent almost every day.

And as far as I understand from the openocd list thread mentioned above, patchwork still requires more handwork from maintainer than Gerrit.

Yegor

#7 lore raw
In reply to Peter Korsgaard

Hi,

Quoted 14 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

?>> What do you think about using Gerrit
?>> (http://code.google.com/p/gerrit/) for Buildroot? Many OSS projects ?>> seem to switch to this system.

?Thomas> How does it compare to patchwork (http://patchwork.ozlabs.org/)
?Thomas> ? ?Patchwork works in relation to a mailing-list, from which it ?Thomas> automatically picks up patches and related review comments, and ?Thomas> it allows maintainers to track which patches have been ?Thomas> applied/not applied.

Quoted 8 lines

?Thomas> How does Gerrit work in that respect?

I don't have any hands on experience (but I am following the openocd list, so I see it used), and my initial feeling is that something like patchwork would fit better our current way of working.

But that's just an initial feeling, let's discuss at ELC and/or here on the list.

Whatever system chosen, if any, should be capable of importing patches from the mailing list.

The gerrit documentation does not seem to mention this feature. It suggests that every developer creates a git repository and pushes to the gerrit system.
Personally, I don't use git, nor would I like to be forced to. I'm using Mercurial. Stable buildroot versions are imported into a Mercurial repository. I make changes in that repository and prepare patches from that, which I check on the latest buildroot snapshot. These patches are sent to the mailing list.
I prefer being able to continue working in this way, also with a review system in place.

~Thomas

#8 lore raw

Le Fri, 21 Oct 2011 13:19:53 +0200,
Thomas De Schampheleire <[email protected]> a ?crit :

Quoted 2 lines

Whatever system chosen, if any, should be capable of importing patches from the mailing list.

Not only importing, but also sending the review comments on the mailing list. Mails can be read offline, while reading things in a web interface needs a network connection.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com