Skip to contentSkip to conversation

U-Boot maintainers: some boards are broken by recent mach-type update

U-Boot Albert ARIBAUD 5 participants 6 messages Oct 28, 2011 – Nov 5, 2011

lore
Share & tools
lore
#0 lore raw

Hello all,

Recently the ARM mach-types.h file has been brought in sync with its Linux original, leasing to a number of boards not being listed any more, as the new list only contains boards which have actual Linux support or were declared less than one year ago.

The symptom is a build failure with a message of the form "error:
'MACH_TYPE_XXXXXX' undeclared (first use in this function)".

U-Boot maintainers of such boards (in Cc: of this mail) should provide a patch to re-introduce the MACH_TYPE_XXXXXX definition in their boards' config header file in include/configs/.

Note that three boards do not have a maintainer and will be removed if nobody steps forward to take over their maintainership. They have been listed below as ORPHAN, and since they are all PXA boards, I have CC:ed Marek just in case.

Here is the list of broken boards (BTW: how about putting maintainer identity in boards.cfg, or at least turning MAINTAINERS into a format more easily parseable?)

-------------------------

Ajay Bhargav <[email protected]>

	gplugd		ARM926EJS (ARMADA100 88AP168 SoC)

Luca Ceresoli <[email protected]>

	dig297		ARM ARMV7 (OMAP3530 SoC)

Po-Yu Chuang <[email protected]>

	a320evb		FA526 (ARM920T-like) (a320 SoC)

Daniel Gorsulowski <[email protected]>

	meesc		ARM926EJS (AT91SAM9263 SoC)
	otc570		ARM926EJS (AT91SAM9263 SoC)

Ilko Iliev <[email protected]>

	PM9261		AT91SAM9261
	PM9263		AT91SAM9263
	PM9G45		ARM926EJS (AT91SAM9G45 SoC)

Prakash Kumar <[email protected]>

	cerf250		xscale/pxa

Valentin Longchamp <[email protected]>

km_kirkwood ARM926EJS (Kirkwood SoC)
portl2 ARM926EJS (Kirkwood SoC)

David M?ller <[email protected]>

	VCMA9		ARM920T

Jens Scharsig <[email protected]>

	eb_cpux9k2	ARM920T (AT91RM9200 SoC)

Heiko Schocher <[email protected]>

mgcoge3un ARM926EJS (Kirkwood SoC)

Robert Schwebel <[email protected]>

	csb226		xscale/pxa
	innokom		xscale/pxa

Albin Tonnerre <[email protected]>

	sbc35_a9g20	ARM926EJS (AT91SAM9G20 SoC)
	tny_a9260	ARM926EJS (AT91SAM9260 SoC)
	tny_a9g20	ARM926EJS (AT91SAM9G20 SoC)

Matthias Weisser <[email protected]>

	jadecpu		ARM926EJS (MB86R01 SoC)

ORPHAN:

	cradle		xscale/pxa
	pleb2		xscale/pxa
	xm250		xscale/pxa

Amicalement,

Signature · 1 line
Albert.
#1 lore raw

Hi Albert,

Quoted 23 lines

Hello all,

Recently the ARM mach-types.h file has been brought in sync with its Linux original, leasing to a number of boards not being listed any more, as the new list only contains boards which have actual Linux support or were declared less than one year ago.

The symptom is a build failure with a message of the form "error:
'MACH_TYPE_XXXXXX' undeclared (first use in this function)".

U-Boot maintainers of such boards (in Cc: of this mail) should provide a patch to re-introduce the MACH_TYPE_XXXXXX definition in their boards' config header file in include/configs/.

Note that three boards do not have a maintainer and will be removed if nobody steps forward to take over their maintainership. They have been listed below as ORPHAN, and since they are all PXA boards, I have CC:ed Marek just in case.

Here is the list of broken boards (BTW: how about putting maintainer identity in boards.cfg, or at least turning MAINTAINERS into a format more easily parseable?)

Quoted 5 lines

-------------------------

Ajay Bhargav <[email protected]>

	gplugd		ARM926EJS (ARMADA100 88AP168 SoC)

Ajay, you have warnings in your damn ethernet code !!! Have you ever tested it ?!

Quoted 16 lines

Luca Ceresoli <[email protected]>

	dig297		ARM ARMV7 (OMAP3530 SoC)

Po-Yu Chuang <[email protected]>

	a320evb		FA526 (ARM920T-like) (a320 SoC)

Daniel Gorsulowski <[email protected]>

	meesc		ARM926EJS (AT91SAM9263 SoC)
	otc570		ARM926EJS (AT91SAM9263 SoC)

Ilko Iliev <[email protected]>

Quoted 7 lines
	PM9261		AT91SAM9261
	PM9263		AT91SAM9263
	PM9G45		ARM926EJS (AT91SAM9G45 SoC)

Prakash Kumar <[email protected]>

	cerf250		xscale/pxa

Drop unless I get fixes from maintainer in a week or request for longer time to fix.

Quoted 14 lines

Valentin Longchamp <[email protected]>

km_kirkwood ARM926EJS (Kirkwood SoC)
portl2 ARM926EJS (Kirkwood SoC)

David M?ller <[email protected]>

	VCMA9		ARM920T

Jens Scharsig <[email protected]>

	eb_cpux9k2	ARM920T (AT91RM9200 SoC)
Quoted 8 lines

Heiko Schocher <[email protected]>

mgcoge3un ARM926EJS (Kirkwood SoC)

Robert Schwebel <[email protected]>

	csb226		xscale/pxa
	innokom		xscale/pxa

Drop unless I get fixes from maintainer in a week or request for longer time to fix. (here I have some feeling it's not gonna be fixed)

Quoted 9 lines

Albin Tonnerre <[email protected]>

	sbc35_a9g20	ARM926EJS (AT91SAM9G20 SoC)
	tny_a9260	ARM926EJS (AT91SAM9260 SoC)
	tny_a9g20	ARM926EJS (AT91SAM9G20 SoC)

Matthias Weisser <[email protected]>

Quoted 7 lines
	jadecpu		ARM926EJS (MB86R01 SoC)

ORPHAN:

	cradle		xscale/pxa
	pleb2		xscale/pxa
	xm250		xscale/pxa

Drop, sorry.

Cheers

#2 lore raw

Hi Marek,

Quoted 7 lines · Marek Vasut
Quoted 4 lines

Robert Schwebel <[email protected]>

	csb226		xscale/pxa
	innokom		xscale/pxa

Drop unless I get fixes from maintainer in a week or request for longer time to fix. (here I have some feeling it's not gonna be fixed)

They won't. Both boards are not in my hands any more and long obsolete. So from my side, dropping them is just fine.

rsc

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw
In reply to Marek Vasut
Quoted 8 lines · Marek Vasut
Quoted 5 lines

Here is the list of broken boards

Ajay Bhargav <[email protected]>

? ? ? gplugd ? ? ? ? ?ARM926EJS (ARMADA100 88AP168 SoC)

Ajay, you have warnings in your damn ethernet code !!! Have you ever tested it ?!

let's be a little more accommodating from the get-go and assume that they have, and that something has changed in parallel -mike

#4 lore raw
In reply to Albert ARIBAUD
Quoted 3 lines · Albert ARIBAUD

(BTW: how about putting maintainer
identity in boards.cfg, or at least turning MAINTAINERS into a format more easily parseable?)

having a MAINTAINERS file that is compatible in syntax with the Linux kernel is nice, but i guess boards.cfg does make sense in the u-boot context in that it's a single db of board info. perhaps we could have it list aliases though and then we could maintain a muttrc compatible file which binds aliases to e-mails/names so we could directly leverage it from .git/mailrc ?
-mike