Skip to contentSkip to conversation

PATCH: Add "time" command

U-Boot NAK Peter Barada 3 participants 4 messages Oct 29, 2011 – Oct 30, 2011

lore
Share & tools
lore
NAK
#1 lore raw
Quoted 2 lines · On Saturday 29 October 2011 10:57:48 Peter Barada wrote:

Add 'time <cmd> <args>' which executes <cmd> with <args> and shows the execution time in seconds. Requires get_timer().

NAK: we already have common/cmd_time.c and CONFIG_CMD_TIME
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111030/3de5c179/attachment.pgp

#2 lore raw

Dear Mike Frysinger,

Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 3 lines

Add 'time <cmd> <args>' which executes <cmd> with <args> and shows the execution time in seconds. Requires get_timer().

NAK: we already have common/cmd_time.c and CONFIG_CMD_TIME

But common/cmd_time.c is unportable and only available on ARM due so using a non standard timer API (get_timer_masked() etc.

I wonder if we should swap the implementations.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to kill without reason
	-- Spock, "Journey to Babel", stardate 3842.4
#3 lore raw
Quoted 8 lines · On Sunday 30 October 2011 11:55:15 Wolfgang Denk wrote:
Quoted 4 lines · Mike Frysinger
Quoted 2 lines

Add 'time <cmd> <args>' which executes <cmd> with <args> and shows the execution time in seconds. Requires get_timer().

NAK: we already have common/cmd_time.c and CONFIG_CMD_TIME

But common/cmd_time.c is unportable and only available on ARM due so using a non standard timer API (get_timer_masked() etc.

i think the idea was to use the more exact API like will be available with Graeme's proposed rewrite ...

Quoted 1 line

I wonder if we should swap the implementations.

extending the current code to support non-ARM makes sense, but adding a new code base like the original patch does not
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111030/6706434c/attachment.pgp