Incorrect checkpatch warning
Adrian Hunter
maintainerHi
This checkpatch warning looks wrong:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #73: FILE: drivers/mmc/host/sdhci-pci-data.c:5:
+EXPORT_SYMBOL_GPL(sdhci_pci_get_data);
The patch has this:
drivers/mmc/host/sdhci-pci-data.c new file +5 -0
@@ -0,0 +1,5 @@ +#include <linux/module.h> +#include <linux/mmc/sdhci-pci-data.h> + +struct sdhci_pci_data *(*sdhci_pci_get_data)(struct pci_dev *pdev,int slotno); +EXPORT_SYMBOL_GPL (sdhci_pci_get_data);
Regards
Adrian
Quoted 30 lines · Adrian Hunter
Hi
This checkpatch warning looks wrong:
WARNING:
EXPORT_SYMBOL(foo); should immediately follow its function/variable #73: FILE:drivers/mmc/host/sdhci-pci-data.c:5:
+EXPORT_SYMBOL_GPL(sdhci_pci_get_data);The patch has this:
drivers/mmc/host/sdhci-pci-data.c new file +5
-0@@ -0,0 +1,5 @@ +#include <linux/module.h> +#include <linux/mmc/sdhci-pci-data.h> + +struct sdhci_pci_data *(*sdhci_pci_get_data)(struct pci_dev *pdev,int slotno); +EXPORT_SYMBOL_GPL (sdhci_pci_get_data);since it is a prototype you get that message. use
EXPORT_SYMBOLbelow the function definition and not below prototype declarationRegards
Adrian
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html