PROBLEM: n_hdlc not atomic use tty->flags.
N_HDLC can spoil tty->flags because use not atomic operations on tty->flags. I use n_hdlc line discipline and it happens.
Signed-off-by Ilya Zykov <[email protected]>
---
drivers/tty/n_hdlc.c +3 -3
@@ -417,7 +417,7 @@ static void n_hdlc_send_frames(struct n_ __FILE__,__LINE__,tbuf,tbuf->count);/* Send the next block of data to device */ - tty->flags |= (1 <<TTY_DO_WRITE_WAKEUP ); +set_bit (TTY_DO_WRITE_WAKEUP , &tty->flags); actual = tty->ops->write (tty, tbuf->buf, tbuf->count);/* rollback was possible and has been done */
@@ -459,7 +459,7 @@ static void n_hdlc_send_frames(struct n_ }if (!tbuf) - tty->flags &= ~(1 <<TTY_DO_WRITE_WAKEUP ); +clear_bit (TTY_DO_WRITE_WAKEUP , &tty->flags);/* Clear the re-entry flag */ spin_lock_irqsave (&n_hdlc->tx_buf_list.spinlock, flags);
@@ -491,7 +491,7 @@ static void n_hdlc_tty_wakeup(struct ttyreturn ;if (tty != n_hdlc->tty) { - tty->flags &= ~(1 <<TTY_DO_WRITE_WAKEUP ); +clear_bit (TTY_DO_WRITE_WAKEUP , &tty->flags);return ; }
Alan Cox
Acked-byQuoted 2 lines · On Mon, 07 Nov 2011 11:32:46 +0400 Ilya Zykov <[email protected]> wrote:
N_HDLCcan spoiltty->flagsbecause use not atomic operations ontty->flags. I usen_hdlcline discipline and it happens.
Acked-by Alan Cox <[email protected]>