Adding Microblaze support to Buildroot

Hi, I'm trying to add the Microblaze arch to buildroot.

My changes are available at git://github.com/Spenser309/buildroot.git

Thanks,
Spenser

Am 10.11.2011 23:55, schrieb Spenser Gilliland:

Quoted 1 line

Hi, I'm trying to add the Microblaze arch to buildroot.

Hello Spenser,

I am also working on Microblaze, but did not try to build a toolchain yet. There is some information on this on the internet, especially here:
http://www.monstr.eu/. There are lots of patches for the toolchain and I don't know how complete the Microblaze support in the original gcc is.

is there an interest in adding the Microblaze architecture to buildroot?

And, if it is, would it be acceptable to rely on toolchain and/or bootloader coming from the board vendor or Xilinx, at least for some time?

Le Tue, 22 Nov 2011 09:52:24 +0100,
Stephan Hoffmann <[email protected]> a ?crit :

Quoted 2 lines

is there an interest in adding the Microblaze architecture to buildroot?

Definitely, yes.

Quoted 3 lines

And, if it is, would it be acceptable to rely on toolchain and/or bootloader coming from the board vendor or Xilinx, at least for some time?

Yes. It is possible to use the external toolchain mechanism. For example, the Blackfin support relies on an external toolchain provided by ADI, I'm not sure the internal Buildroot code to build a toolchain works for Blackfin. So doing the same for Microblaze seems reasonable.

Regards,

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

"Stephan" == Stephan Hoffmann <[email protected]> writes:

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

"Stephan" == Stephan Hoffmann <[email protected]> writes:

Stephan> Hello all,

Stephan> is there an interest in adding the Microblaze architecture to Stephan> buildroot?

Yes, I would say so.

I'm more worrying about how much we need to patch individual
packages to work on microblaze.

To which extend do you expect individual packages being tested on the different architectures?

By now I have a busybox only configuration that can boot with the U-Boot available from the Avnet website.

I can send a patch against buildroot's next branch if desired.

Le Wed, 23 Nov 2011 12:09:53 +0100,
Stephan Hoffmann <[email protected]> a ?crit :

Quoted 2 lines

To which extend do you expect individual packages being tested on the different architectures?

On Blackfin, there are many packages that don't build, because they simply cannot build on !MMU systems. Our goal is to progressively add the "depends on BR2_USE_MMU" on all packages that need a MMU to build/work properly.

Excellent. Would be good to have :

* A patch adding the general Microblaze support

* A patch that adds some defconfig for the Microblaze board you have

* It would be even better if another patch could add a defconfig for the Microblaze Qemu emulation, so that those not having a Microblaze board can test.

In fact, my Microblaze is with MMU since Xilinx only supports linux with mmu.

I'll send these in one patch if that's O.K. There ia also a new kernel defconfig, because the defconfig supplied with the kernel does not work for my configuration.

Quoted 3 lines

* It would be even better if another patch could add a defconfig for the Microblaze Qemu emulation, so that those not having a Microblaze board can test.

That's a real good idea, I'll work on this later.

Le Wed, 23 Nov 2011 16:46:03 +0100,
Stephan Hoffmann <[email protected]> a ?crit :

Quoted 2 lines

In fact, my Microblaze is with MMU since Xilinx only supports linux with mmu.

Ah, ok.

Quoted 3 lines

I'll send these in one patch if that's O.K. There ia also a new kernel defconfig, because the defconfig supplied with the kernel does not work for my configuration.

Ok.

Quoted 4 lines

Quoted 3 lines

* It would be even better if another patch could add a defconfig for the Microblaze Qemu emulation, so that those not having a Microblaze board can test.

That's a real good idea, I'll work on this later.

Do you know if Qemu emulates the Microblaze variants that have a MMU ? It would be good to have samples for both cases.

Regards,

Thomas

Excellent. Would be good to have :

* A patch adding the general Microblaze support

* A patch that adds some defconfig for the Microblaze board you have

Am 23.11.2011 14:54, schrieb Thomas Petazzoni:

Quoted 6 lines

Excellent. Would be good to have :

* A patch adding the general Microblaze support

* A patch that adds some defconfig for the Microblaze board you have

Hello all,

here is my patch to introduce MicroBlaze to buildroot. Comments are highly welcome!

Hi Stephan,

Quoted 11 lines · Stephan Hoffmann

Am 23.11.2011 14:54, schrieb Thomas Petazzoni:

Quoted 6 lines

Excellent. Would be good to have :

?* A patch adding the general Microblaze support

?* A patch that adds some defconfig for the Microblaze board you have

Hello all,

here is my patch to introduce MicroBlaze to buildroot. Comments are highly welcome!

[snip]

Review

Quoted 3 lines

(quoted diff) +3 -0

+This is the buildroot board support for the Avnet Spartan6 LX9 MicroBoard.
+
+The board can be bought from Avnet or from Trenz for a low prize.

s/prize/price/

baruch

--
? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ~. .~ ? Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= ? - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

I'm using this Microblaze patch for my project. Will it be part of the official release that is coming up soon?

Quoted 2 lines · On Saturday 11 February 2012 05:58:37 Spenser Gilliland wrote:

I'm using this Microblaze patch for my project. ?Will it be part of the official release that is coming up soon?

?I'm afraid it got lost between the cracks. ?Could you repost it?

?Regards,
?Arnout

--
Arnout Vandecappelle ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? arnout at mind be Senior Embedded Software Architect ? ? ? ? ? ? ? ? +32-16-286540 Essensium/Mind ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium ? ? ? ? ? ? ? ?BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: ?7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Arnout,

This is the patch with some minor adjustments. I've tested it using a big endian toolchain. Stephen used a little endian toolchain.

I got rid of the BR2_GCC_TARGET_TUNE as the build errored out when I attempt it with the raw patch. The error stated that target tune was not supported by the compiler.

Spenser

configs/spartan6lx9_mb_defconfig new file +2 -0

+BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y
+BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="simpleImage.lx9_mmu"

linux/Config.in +0 -0

index 86dc32a..138feb3 100644
@@ -120,6 +120,14 @@ config BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE
 	help

linux/Config.in +0 -0

 #
 # Binary format
 #

linux/linux.mk +0 -0

index ae236d4..ade867a 100644

linux/linux.mk +2 -0

 	# As the kernel gets compiled before root filesystems are
 	# built, we create a fake cpio file. It'll be
 	# replaced later by the real cpio archive, and the kernel will be

@@ -215,6 +229,8 @@ $(LINUX_DIR)/.stamp_initramfs_rebuilt: $(LINUX_DIR)/.stamp_target_installed $(LI
 	$(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(LINUX_IMAGE_NAME)
 	# Copy the kernel image to its final destination
 	cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
+	# If there is a .ub file copy it to the final destination
+	test -f $(LINUX_IMAGE_PATH).ub && cp $(LINUX_IMAGE_PATH).ub $(BINARIES_DIR)
 	$(Q)touch $@
 
 # The initramfs building code must make sure this target gets called

target/Config.in.arch +4 -0

index 417441d..0524307 100644
@@ -21,6 +21,8 @@ config BR2_i386
 config BR2_m68k
 	bool "m68k"
 	depends on BROKEN # ice in uclibc / inet_ntoa_r
+config BR2_microblaze
+    bool "microblaze"
 config BR2_mips
 	bool "mips"
 config BR2_mipsel

@@ -477,6 +479,19 @@ config BR2_powerpc_SPE
 	depends on BR2_powerpc_8540 || BR2_powerpc_8548 || BR2_powerpc_e500mc
 endchoice
 
+choice 
+	prompt "Target Endianess"

target/Config.in.arch +4 -2

+
 config BR2_ARCH
 	string
 	default "arm"		if BR2_arm

@@ -508,6 +523,7 @@ config BR2_ARCH
 	default "i686"		if BR2_x86_athlon
 	default "i686"		if BR2_x86_athlon_4
 	default "m68k"		if BR2_m68k
+	default "microblaze"	if BR2_microblaze
 	default "mips"		if BR2_mips
 	default "mipsel"	if BR2_mipsel
 	default "powerpc"	if BR2_powerpc

@@ -533,11 +549,13 @@ config BR2_ARCH
 
 config BR2_ENDIAN
 	string
-	default "LITTLE" if BR2_arm || BR2_bfin || BR2_i386 || BR2_mipsel || \
-			    BR2_sh3 || BR2_sh4 || BR2_sh4a || BR2_x86_64 || BR2_sh64
+   default "LITTLE" if BR2_arm || BR2_bfin || BR2_i386 || BR2_mipsel || \
+			    BR2_sh3 || BR2_sh4 || BR2_sh4a || BR2_x86_64 || BR2_sh64 || \

Quoted 7 lines · On Monday 13 February 2012 02:03:58 Spenser Gilliland wrote:

Arnout,

This is the patch with some minor adjustments. ?I've tested it using a big endian toolchain. ?Stephen used a little endian toolchain.

I got rid of the BR2_GCC_TARGET_TUNE as the build errored out when I attempt it with the raw patch. ?The error stated that target tune was not supported by the compiler.

Spenser

?Thanks for this patch!

?A few remarks:

* Please add a relevant commit message. ?It starts with a single line short description followed by an empty line. ?Then one or more paragraphs of explanation (probably not much needed in this case). ?And finally, one or more Signed-off-by lines.

* Add a Signed-off-by line for yourself. ?This is a short way for you to assert that you are entitled to contribute the patch under buildroot's GPL license. ?See ?http://kerneltrap.org/files/Jeremy/DCO.txt for more details.

* In addition, include the Signed-off-by line of the original poster:

Signed-off-by Stephan Hoffmann <[email protected]>

* There were also a few remarks from Peter Kosgaard, Alvaro Gamez and Thomas Petazonni. ?Could you include those?

* See additional remarks below.

?If you don't have the time to do all this yourself, please let us know so someone else can take it over. ?Hopefully it won't fall between the cracks again :-)

[snip]

configs/spartan6lx9_mb_defconfig line 5

Quoted 11 lines

configs/spartan6lx9_mb_defconfig new file +5 -0

new file mode 100644
index 0000000..5ae1ede
@@ -0,0 +1,18 @@
+BR2_microblaze=y
+BR2_microblazel=y
+BR2_TOOLCHAIN_EXTERNAL=y
+BR2_TOOLCHAIN_EXTERNAL_PATH="/opt/microblazeel-unknown-linux-gnu/"
+BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="microblazeel-unknown-linux-gnu"

?I don't think we should have defconfigs that depend on pre-extracted toolchains. Instead, the Xilinx toolchain should be added to the supported external toolchains like Sourcery.

configs/spartan6lx9_mb_defconfig line 9

Quoted 5 lines

configs/spartan6lx9_mb_defconfig new file +4 -0

+BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC=y
+BR2_TOOLCHAIN_EXTERNAL_CXX=y
 
+BR2_TARGET_GENERIC_HOSTNAME="Microblaze Buildroot"
+BR2_TARGET_GENERIC_ISSUE="Welcome to Microblaze Buildroot"

?No need to change the defaults here.

configs/spartan6lx9_mb_defconfig line 16

Quoted 7 lines

configs/spartan6lx9_mb_defconfig new file +7 -0

+BR2_TARGET_GENERIC_GETTY_PORT="ttyUL0"
+# BR2_TARGET_ROOTFS_TAR is not set
+BR2_TARGET_ROOTFS_INITRAMFS=y
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
+BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="$(TOPDIR)/board/relinux/avnet_LX9MicroBoard/lx9_mmu_defconfig"
+BR2_LINUX_KERNEL_DTS_FILE="$(TOPDIR)/board/relinux/avnet_LX9MicroBoard/lx9_mmu.dts"

?The $(TOPDIR)/ is redundant: the build is always executed from $(TOPDIR).

Quoted 10 lines

configs/spartan6lx9_mb_defconfig new file +2 -0

+BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y
+BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="simpleImage.lx9_mmu"

linux/Config.in +0 -0

index 86dc32a..138feb3 100644
@@ -120,6 +120,14 @@ config BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE

? ? ? help
? ? ? ? Path to the kernel configuration file

Quoted 8 lines

+config BR2_LINUX_KERNEL_DTS_FILE
+ ? ?string "Device Tree dts file location"
+ ? ?depends on BR2_microblaze
+ ? ?help
+ ? ? ?Path from where the dts file has to be copied
+ ? ? ?The final "custom target" name depends on the
+ ? ? ?dts file name:
+ ? ? ? ? ?<name>.dts --> simpleImage.<name>

?Device tree support isn't specific to microblaze. ?It's incredible that we didn't have that in buildroot yet! ?Can you make a separate patch to add device tree support? ?The generic device tree support of course wouldn't have the combination of zImage and .dtb into a simpleImage, so you'd have to add an explicit '$(MAKE) ....dtb' to the linux build commands.

?Of course, there should also be support to select an in-kernel dts (just like the in-kernel defconfigs).

Quoted 11 lines

?#
?# Binary format
?#

linux/linux.mk +0 -0

index ae236d4..ade867a 100644
@@ -117,6 +117,18 @@ endef
 

?LINUX_POST_PATCH_HOOKS += LINUX_APPLY_PATCHES

linux/linux.mk endef · line 122

Quoted 3 lines

linux/linux.mk +3 -0

+ifeq ($(KERNEL_ARCH),microblaze)
+# on microblaze, we always want mkimage
+LINUX_DEPENDENCIES+=host-uboot-tools

?I think you should define a new image type BR2_LINUX_KERNEL_SIMPLEIMAGE for microblaze, and only add this dependency if that image type is chosen.

linux/linux.mk

Quoted 8 lines

linux/linux.mk +8 -0

+
+define LINUX_COPY_DTS
+ ? ?if test -f "$(BR2_LINUX_KERNEL_DTS_FILE)" ; then \
+ ? ? ? ?cp $(BR2_LINUX_KERNEL_DTS_FILE) $(@D)/arch/microblaze/boot/dts ; \
+ ? ?else \
+ ? ? ? ?echo "Cannot copy dts file!" ; \
+ ? ?fi
+endef

?The path should be $(KERNEL_ARCH_PATH)/boot/dts.

?It requires an mkdir -p to make sure the target directory exists.

?The test -f is redundant, since cp will simply fail and terminate the build if the source file doesn't exist.

?You also need an extra make variable to remove the quotes:
LINUX_KERNEL_DTS_FILE = $(call qstrip,$(BR2_LINUX_KERNEL_DTS_FILE))

?And the define should be wrapped in a
ifneq ($(LINUX_KERNEL_DTS_FILE),)
...
endif

linux/linux.mk define LINUX_CONFIGURE_CMDS · line 147

Quoted 10 lines

+endif

?ifeq ($(BR2_LINUX_KERNEL_USE_DEFCONFIG),y)
?KERNEL_SOURCE_CONFIG = $(KERNEL_ARCH_PATH)/configs/$(call qstrip,$(BR2_LINUX_KERNEL_DEFCONFIG))_defconfig

linux/linux.mk +2 -0

@@ -131,6 +143,8 @@ define LINUX_CONFIGURE_CMDS
 ? ? ? $(if $(BR2_ARM_EABI),
 ? ? ? ? ? ? ? $(call KCONFIG_ENABLE_OPT,CONFIG_AEABI,$(@D)/.config),
 ? ? ? ? ? ? ? $(call KCONFIG_DISABLE_OPT,CONFIG_AEABI,$(@D)/.config))
+ ? ?$(if $(BR2_microblaze),
+ ? ? ? ?$(call LINUX_COPY_DTS))

?No call is needed here, the COPY_DTS is not a function. ?And the condition isn't necessary: the variable will default to empty.

Quoted 31 lines

? ? ? # As the kernel gets compiled before root filesystems are ? ? ? # built, we create a fake cpio file. It'll be
? ? ? # replaced later by the real cpio archive, and the kernel will be

linux/linux.mk +0 -0

@@ -215,6 +229,8 @@ $(LINUX_DIR)/.stamp_initramfs_rebuilt: $(LINUX_DIR)/.stamp_target_installed $(LI
 ? ? ? $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(LINUX_IMAGE_NAME)

? ? ? # Copy the kernel image to its final destination
? ? ? cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
+ ? ? # If there is a .ub file copy it to the final destination
+ ? ? test -f $(LINUX_IMAGE_PATH).ub && cp $(LINUX_IMAGE_PATH).ub $(BINARIES_DIR) ? ? ? $(Q)touch $@

?# The initramfs building code must make sure this target gets called

target/Config.in.arch +0 -0

index 417441d..0524307 100644
@@ -21,6 +21,8 @@ config BR2_i386

?config BR2_m68k
? ? ? bool "m68k"
? ? ? depends on BROKEN # ice in uclibc / inet_ntoa_r +config BR2_microblaze
+ ? ?bool "microblaze"
?config BR2_mips
? ? ? bool "mips"
?config BR2_mipsel

target/Config.in.arch +0 -0

@@ -477,6 +479,19 @@ config BR2_powerpc_SPE

? ? ? depends on BR2_powerpc_8540 || BR2_powerpc_8548 || BR2_powerpc_e500mc ?endchoice

target/Config.in.arch +2 -0

+choice
+ ? ? prompt "Target Endianess"

target/Config.in.arch

Quoted 10 lines

target/Config.in.arch +10 -0

+ ? ? depends on BR2_microblaze
+ ? ? default BR2_microblazeel
+ ? ? help
+ ? ? ? Endianess of the Microblaze Processor
+
+config BR2_microblazeel
+ ? ? bool "Little Endian"
+config BR2_microblazebe
+ ? ? bool "Big Endian"
+endchoice

?For ARM and MIPS we define the endianness as the main architecture, not as a subarchitecture. ?I would do the same for microblaze.

?It does make sense to add a summarizing hidden BR2_microblaze, like this:

config BR2_microblaze
? ? ? ?bool
? ? ? ?default y if BR2_microblazeel || BR2_microblazebe

Quoted 26 lines

+
?config BR2_ARCH
? ? ? string
? ? ? default "arm" ? ? ? ? ? if BR2_arm

target/Config.in.arch +0 -0

@@ -508,6 +523,7 @@ config BR2_ARCH

? ? ? default "i686" ? ? ? ? ?if BR2_x86_athlon
? ? ? default "i686" ? ? ? ? ?if BR2_x86_athlon_4
? ? ? default "m68k" ? ? ? ? ?if BR2_m68k
+ ? ? default "microblaze" ? ?if BR2_microblaze
? ? ? default "mips" ? ? ? ? ?if BR2_mips
? ? ? default "mipsel" ? ? ? ?if BR2_mipsel
? ? ? default "powerpc" ? ? ? if BR2_powerpc

target/Config.in.arch +0 -0

@@ -533,11 +549,13 @@ config BR2_ARCH
 

?config BR2_ENDIAN
? ? ? string

- ? ? default "LITTLE" if BR2_arm || BR2_bfin || BR2_i386 || BR2_mipsel || \
- ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh3 || BR2_sh4 || BR2_sh4a || BR2_x86_64 || BR2_sh64
+ ? default "LITTLE" if BR2_arm || BR2_bfin || BR2_i386 || BR2_mipsel || \
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh3 || BR2_sh4 || BR2_sh4a || BR2_x86_64 || BR2_sh64 || \
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_microblazeel
? ? ? default "BIG" ? ?if BR2_armeb || BR2_avr32 || BR2_m68k || BR2_mips || \
- ? ? ? ? ? ? ? ? ? ? ? ? BR2_powerpc || BR2_sh2 || BR2_sh2a || \
- ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh3eb || BR2_sh4eb || BR2_sh4aeb || BR2_sparc
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_powerpc || BR2_sh2 || BR2_sh2a || BR2_sh3eb || \
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh4eb || BR2_sh4aeb || BR2_sparc || \

Quoted 5 lines

+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? BR2_microblazebe

?config BR2_GCC_TARGET_TUNE
? ? ? string

?Regards,
?Arnout

--
Arnout Vandecappelle ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? arnout at mind be Senior Embedded Software Architect ? ? ? ? ? ? ? ? +32-16-286540 Essensium/Mind ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium ? ? ? ? ? ? ? ?BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: ?7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Arnout,

I agree with the comments. ?I'll get on it and have something ASAP. ?I want to have this in the coming release.

Additionally, I have been working on a Microblaze specific patch which adds the ability to copy parameters.h to the required directory in uboot. ?This is required to build a working u-boot for a custom board.

Spenser

Quoted 239 lines · Arnout Vandecappelle

Quoted 7 lines · On Monday 13 February 2012 02:03:58 Spenser Gilliland wrote:

Arnout,

This is the patch with some minor adjustments. ?I've tested it using a big endian toolchain. ?Stephen used a little endian toolchain.

I got rid of the BR2_GCC_TARGET_TUNE as the build errored out when I attempt it with the raw patch. ?The error stated that target tune was not supported by the compiler.

Spenser

?Thanks for this patch!

?A few remarks:

* Please add a relevant commit message. ?It starts with a single line short description followed by an empty line. ?Then one or more paragraphs of explanation (probably not much needed in this case). ?And finally, one or more Signed-off-by lines.

* Add a Signed-off-by line for yourself. ?This is a short way for you to assert that you are entitled to contribute the patch under buildroot's GPL license. ?See ?http://kerneltrap.org/files/Jeremy/DCO.txt for more details.

* In addition, include the Signed-off-by line of the original poster:

Signed-off-by Stephan Hoffmann <[email protected]>

* There were also a few remarks from Peter Kosgaard, Alvaro Gamez and Thomas Petazonni. ?Could you include those?

* See additional remarks below.

?If you don't have the time to do all this yourself, please let us know so someone else can take it over. ?Hopefully it won't fall between the cracks again :-)

[snip]

configs/spartan6lx9_mb_defconfig line 5

Quoted 11 lines

configs/spartan6lx9_mb_defconfig new file +5 -0

new file mode 100644
index 0000000..5ae1ede
@@ -0,0 +1,18 @@
+BR2_microblaze=y
+BR2_microblazel=y
+BR2_TOOLCHAIN_EXTERNAL=y
+BR2_TOOLCHAIN_EXTERNAL_PATH="/opt/microblazeel-unknown-linux-gnu/"
+BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="microblazeel-unknown-linux-gnu"

?I don't think we should have defconfigs that depend on pre-extracted toolchains. Instead, the Xilinx toolchain should be added to the supported external toolchains like Sourcery.

configs/spartan6lx9_mb_defconfig line 9

Quoted 5 lines

configs/spartan6lx9_mb_defconfig new file +4 -0

+BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC=y
+BR2_TOOLCHAIN_EXTERNAL_CXX=y
 
+BR2_TARGET_GENERIC_HOSTNAME="Microblaze Buildroot"
+BR2_TARGET_GENERIC_ISSUE="Welcome to Microblaze Buildroot"

?No need to change the defaults here.

configs/spartan6lx9_mb_defconfig line 16

Quoted 7 lines

configs/spartan6lx9_mb_defconfig new file +7 -0

+BR2_TARGET_GENERIC_GETTY_PORT="ttyUL0"
+# BR2_TARGET_ROOTFS_TAR is not set
+BR2_TARGET_ROOTFS_INITRAMFS=y
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
+BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="$(TOPDIR)/board/relinux/avnet_LX9MicroBoard/lx9_mmu_defconfig"
+BR2_LINUX_KERNEL_DTS_FILE="$(TOPDIR)/board/relinux/avnet_LX9MicroBoard/lx9_mmu.dts"

?The $(TOPDIR)/ is redundant: the build is always executed from $(TOPDIR).

Quoted 10 lines

configs/spartan6lx9_mb_defconfig new file +2 -0

+BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y
+BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="simpleImage.lx9_mmu"

linux/Config.in +0 -0

index 86dc32a..138feb3 100644
@@ -120,6 +120,14 @@ config BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE

? ? ? help
? ? ? ? Path to the kernel configuration file

Quoted 8 lines

+config BR2_LINUX_KERNEL_DTS_FILE
+ ? ?string "Device Tree dts file location"
+ ? ?depends on BR2_microblaze
+ ? ?help
+ ? ? ?Path from where the dts file has to be copied
+ ? ? ?The final "custom target" name depends on the
+ ? ? ?dts file name:
+ ? ? ? ? ?<name>.dts --> simpleImage.<name>

?Device tree support isn't specific to microblaze. ?It's incredible that we didn't have that in buildroot yet! ?Can you make a separate patch to add device tree support? ?The generic device tree support of course wouldn't have the combination of zImage and .dtb into a simpleImage, so you'd have to add an explicit '$(MAKE) ....dtb' to the linux build commands.

?Of course, there should also be support to select an in-kernel dts (just like the in-kernel defconfigs).

Quoted 11 lines

?#
?# Binary format
?#

linux/linux.mk +0 -0

index ae236d4..ade867a 100644
@@ -117,6 +117,18 @@ endef
 

?LINUX_POST_PATCH_HOOKS += LINUX_APPLY_PATCHES

linux/linux.mk endef · line 122

Quoted 3 lines

linux/linux.mk +3 -0

+ifeq ($(KERNEL_ARCH),microblaze)
+# on microblaze, we always want mkimage
+LINUX_DEPENDENCIES+=host-uboot-tools

?I think you should define a new image type BR2_LINUX_KERNEL_SIMPLEIMAGE for microblaze, and only add this dependency if that image type is chosen.

linux/linux.mk

Quoted 8 lines

linux/linux.mk +8 -0

+
+define LINUX_COPY_DTS
+ ? ?if test -f "$(BR2_LINUX_KERNEL_DTS_FILE)" ; then \
+ ? ? ? ?cp $(BR2_LINUX_KERNEL_DTS_FILE) $(@D)/arch/microblaze/boot/dts ; \
+ ? ?else \
+ ? ? ? ?echo "Cannot copy dts file!" ; \
+ ? ?fi
+endef

?The path should be $(KERNEL_ARCH_PATH)/boot/dts.

?It requires an mkdir -p to make sure the target directory exists.

?The test -f is redundant, since cp will simply fail and terminate the build if the source file doesn't exist.

?You also need an extra make variable to remove the quotes:
LINUX_KERNEL_DTS_FILE = $(call qstrip,$(BR2_LINUX_KERNEL_DTS_FILE))

?And the define should be wrapped in a
ifneq ($(LINUX_KERNEL_DTS_FILE),)
...
endif

linux/linux.mk define LINUX_CONFIGURE_CMDS · line 147

Quoted 10 lines

+endif

?ifeq ($(BR2_LINUX_KERNEL_USE_DEFCONFIG),y)
?KERNEL_SOURCE_CONFIG = $(KERNEL_ARCH_PATH)/configs/$(call qstrip,$(BR2_LINUX_KERNEL_DEFCONFIG))_defconfig

linux/linux.mk +2 -0

@@ -131,6 +143,8 @@ define LINUX_CONFIGURE_CMDS
 ? ? ? $(if $(BR2_ARM_EABI),
 ? ? ? ? ? ? ? $(call KCONFIG_ENABLE_OPT,CONFIG_AEABI,$(@D)/.config),
 ? ? ? ? ? ? ? $(call KCONFIG_DISABLE_OPT,CONFIG_AEABI,$(@D)/.config))
+ ? ?$(if $(BR2_microblaze),
+ ? ? ? ?$(call LINUX_COPY_DTS))

?No call is needed here, the COPY_DTS is not a function. ?And the condition isn't necessary: the variable will default to empty.

Quoted 31 lines

? ? ? # As the kernel gets compiled before root filesystems are ? ? ? # built, we create a fake cpio file. It'll be
? ? ? # replaced later by the real cpio archive, and the kernel will be

linux/linux.mk +0 -0

@@ -215,6 +229,8 @@ $(LINUX_DIR)/.stamp_initramfs_rebuilt: $(LINUX_DIR)/.stamp_target_installed $(LI
 ? ? ? $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(LINUX_IMAGE_NAME)

? ? ? # Copy the kernel image to its final destination
? ? ? cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
+ ? ? # If there is a .ub file copy it to the final destination
+ ? ? test -f $(LINUX_IMAGE_PATH).ub && cp $(LINUX_IMAGE_PATH).ub $(BINARIES_DIR) ? ? ? $(Q)touch $@

?# The initramfs building code must make sure this target gets called

target/Config.in.arch +0 -0

index 417441d..0524307 100644
@@ -21,6 +21,8 @@ config BR2_i386

?config BR2_m68k
? ? ? bool "m68k"
? ? ? depends on BROKEN # ice in uclibc / inet_ntoa_r +config BR2_microblaze
+ ? ?bool "microblaze"
?config BR2_mips
? ? ? bool "mips"
?config BR2_mipsel

target/Config.in.arch +0 -0

@@ -477,6 +479,19 @@ config BR2_powerpc_SPE

? ? ? depends on BR2_powerpc_8540 || BR2_powerpc_8548 || BR2_powerpc_e500mc ?endchoice

target/Config.in.arch +2 -0

+choice
+ ? ? prompt "Target Endianess"

target/Config.in.arch

Quoted 10 lines

target/Config.in.arch +10 -0

+ ? ? depends on BR2_microblaze
+ ? ? default BR2_microblazeel
+ ? ? help
+ ? ? ? Endianess of the Microblaze Processor
+
+config BR2_microblazeel
+ ? ? bool "Little Endian"
+config BR2_microblazebe
+ ? ? bool "Big Endian"
+endchoice

?For ARM and MIPS we define the endianness as the main architecture, not as a subarchitecture. ?I would do the same for microblaze.

?It does make sense to add a summarizing hidden BR2_microblaze, like this:

config BR2_microblaze
? ? ? ?bool
? ? ? ?default y if BR2_microblazeel || BR2_microblazebe

Quoted 26 lines

+
?config BR2_ARCH
? ? ? string
? ? ? default "arm" ? ? ? ? ? if BR2_arm

target/Config.in.arch +0 -0

@@ -508,6 +523,7 @@ config BR2_ARCH

? ? ? default "i686" ? ? ? ? ?if BR2_x86_athlon
? ? ? default "i686" ? ? ? ? ?if BR2_x86_athlon_4
? ? ? default "m68k" ? ? ? ? ?if BR2_m68k
+ ? ? default "microblaze" ? ?if BR2_microblaze
? ? ? default "mips" ? ? ? ? ?if BR2_mips
? ? ? default "mipsel" ? ? ? ?if BR2_mipsel
? ? ? default "powerpc" ? ? ? if BR2_powerpc

target/Config.in.arch +0 -0

@@ -533,11 +549,13 @@ config BR2_ARCH
 

?config BR2_ENDIAN
? ? ? string

- ? ? default "LITTLE" if BR2_arm || BR2_bfin || BR2_i386 || BR2_mipsel || \
- ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh3 || BR2_sh4 || BR2_sh4a || BR2_x86_64 || BR2_sh64
+ ? default "LITTLE" if BR2_arm || BR2_bfin || BR2_i386 || BR2_mipsel || \
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh3 || BR2_sh4 || BR2_sh4a || BR2_x86_64 || BR2_sh64 || \
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_microblazeel
? ? ? default "BIG" ? ?if BR2_armeb || BR2_avr32 || BR2_m68k || BR2_mips || \
- ? ? ? ? ? ? ? ? ? ? ? ? BR2_powerpc || BR2_sh2 || BR2_sh2a || \
- ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh3eb || BR2_sh4eb || BR2_sh4aeb || BR2_sparc
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_powerpc || BR2_sh2 || BR2_sh2a || BR2_sh3eb || \
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh4eb || BR2_sh4aeb || BR2_sparc || \

Quoted 5 lines

+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? BR2_microblazebe

?config BR2_GCC_TARGET_TUNE
? ? ? string

?Regards,
?Arnout

Quoted 7 lines

--
Arnout Vandecappelle ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? arnout at mind be Senior Embedded Software Architect ? ? ? ? ? ? ? ? +32-16-286540 Essensium/Mind ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium ? ? ? ? ? ? ? ?BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: ?7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

--
Spenser Gilliland
Computer Engineer
Illinois Institute of Technology

Arnout,

I'm running into an issue downloading the toolchain. ?The toolchain is located in a tar ball inside a git repo. ?I tried the following in toolchain/toolchain-external/ext-tool.mk and it works from the command line but fails in a buildroot build.

ifeq ($(BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEBE_20),y)? TOOLCHAIN_EXTERNAL_SITE="http://git.xilinx.com/?p=xldk/microblaze_v2.0.git;a=blob;f="? TOOLCHAIN_EXTERNAL_SOURCE=microblaze-unknown-linux-gnu.tgz

It may be easier to just host these externally. ?Is there a host available for hosting tarballs?

Spenser

Quoted 263 lines · Spenser Gilliland

Arnout,

I agree with the comments. ?I'll get on it and have something ASAP. ?I want to have this in the coming release.

Additionally, I have been working on a Microblaze specific patch which adds the ability to copy parameters.h to the required directory in uboot. ?This is required to build a working u-boot for a custom board.

Spenser

Quoted 239 lines · Arnout Vandecappelle

Quoted 7 lines · On Monday 13 February 2012 02:03:58 Spenser Gilliland wrote:

Arnout,

This is the patch with some minor adjustments. ?I've tested it using a big endian toolchain. ?Stephen used a little endian toolchain.

I got rid of the BR2_GCC_TARGET_TUNE as the build errored out when I attempt it with the raw patch. ?The error stated that target tune was not supported by the compiler.

Spenser

?Thanks for this patch!

?A few remarks:

* Please add a relevant commit message. ?It starts with a single line short description followed by an empty line. ?Then one or more paragraphs of explanation (probably not much needed in this case). ?And finally, one or more Signed-off-by lines.

* Add a Signed-off-by line for yourself. ?This is a short way for you to assert that you are entitled to contribute the patch under buildroot's GPL license. ?See ?http://kerneltrap.org/files/Jeremy/DCO.txt for more details.

* In addition, include the Signed-off-by line of the original poster:

Signed-off-by Stephan Hoffmann <[email protected]>

* There were also a few remarks from Peter Kosgaard, Alvaro Gamez and Thomas Petazonni. ?Could you include those?

* See additional remarks below.

?If you don't have the time to do all this yourself, please let us know so someone else can take it over. ?Hopefully it won't fall between the cracks again :-)

[snip]

configs/spartan6lx9_mb_defconfig line 5

Quoted 11 lines

configs/spartan6lx9_mb_defconfig new file +5 -0

new file mode 100644
index 0000000..5ae1ede
@@ -0,0 +1,18 @@
+BR2_microblaze=y
+BR2_microblazel=y
+BR2_TOOLCHAIN_EXTERNAL=y
+BR2_TOOLCHAIN_EXTERNAL_PATH="/opt/microblazeel-unknown-linux-gnu/"
+BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="microblazeel-unknown-linux-gnu"

?I don't think we should have defconfigs that depend on pre-extracted toolchains. Instead, the Xilinx toolchain should be added to the supported external toolchains like Sourcery.

configs/spartan6lx9_mb_defconfig line 9

Quoted 5 lines

configs/spartan6lx9_mb_defconfig new file +4 -0

+BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC=y
+BR2_TOOLCHAIN_EXTERNAL_CXX=y
 
+BR2_TARGET_GENERIC_HOSTNAME="Microblaze Buildroot"
+BR2_TARGET_GENERIC_ISSUE="Welcome to Microblaze Buildroot"

?No need to change the defaults here.

configs/spartan6lx9_mb_defconfig line 16

Quoted 7 lines

configs/spartan6lx9_mb_defconfig new file +7 -0

+BR2_TARGET_GENERIC_GETTY_PORT="ttyUL0"
+# BR2_TARGET_ROOTFS_TAR is not set
+BR2_TARGET_ROOTFS_INITRAMFS=y
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
+BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="$(TOPDIR)/board/relinux/avnet_LX9MicroBoard/lx9_mmu_defconfig"
+BR2_LINUX_KERNEL_DTS_FILE="$(TOPDIR)/board/relinux/avnet_LX9MicroBoard/lx9_mmu.dts"

?The $(TOPDIR)/ is redundant: the build is always executed from $(TOPDIR).

Quoted 10 lines

configs/spartan6lx9_mb_defconfig new file +2 -0

+BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y
+BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="simpleImage.lx9_mmu"

linux/Config.in +0 -0

index 86dc32a..138feb3 100644
@@ -120,6 +120,14 @@ config BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE

? ? ? help
? ? ? ? Path to the kernel configuration file

Quoted 8 lines

+config BR2_LINUX_KERNEL_DTS_FILE
+ ? ?string "Device Tree dts file location"
+ ? ?depends on BR2_microblaze
+ ? ?help
+ ? ? ?Path from where the dts file has to be copied
+ ? ? ?The final "custom target" name depends on the
+ ? ? ?dts file name:
+ ? ? ? ? ?<name>.dts --> simpleImage.<name>

?Device tree support isn't specific to microblaze. ?It's incredible that we didn't have that in buildroot yet! ?Can you make a separate patch to add device tree support? ?The generic device tree support of course wouldn't have the combination of zImage and .dtb into a simpleImage, so you'd have to add an explicit '$(MAKE) ....dtb' to the linux build commands.

?Of course, there should also be support to select an in-kernel dts (just like the in-kernel defconfigs).

Quoted 11 lines

?#
?# Binary format
?#

linux/linux.mk +0 -0

index ae236d4..ade867a 100644
@@ -117,6 +117,18 @@ endef
 

?LINUX_POST_PATCH_HOOKS += LINUX_APPLY_PATCHES

linux/linux.mk endef · line 122

Quoted 3 lines

linux/linux.mk +3 -0

+ifeq ($(KERNEL_ARCH),microblaze)
+# on microblaze, we always want mkimage
+LINUX_DEPENDENCIES+=host-uboot-tools

?I think you should define a new image type BR2_LINUX_KERNEL_SIMPLEIMAGE for microblaze, and only add this dependency if that image type is chosen.

linux/linux.mk

Quoted 8 lines

linux/linux.mk +8 -0

+
+define LINUX_COPY_DTS
+ ? ?if test -f "$(BR2_LINUX_KERNEL_DTS_FILE)" ; then \
+ ? ? ? ?cp $(BR2_LINUX_KERNEL_DTS_FILE) $(@D)/arch/microblaze/boot/dts ; \
+ ? ?else \
+ ? ? ? ?echo "Cannot copy dts file!" ; \
+ ? ?fi
+endef

?The path should be $(KERNEL_ARCH_PATH)/boot/dts.

?It requires an mkdir -p to make sure the target directory exists.

?The test -f is redundant, since cp will simply fail and terminate the build if the source file doesn't exist.

?You also need an extra make variable to remove the quotes:
LINUX_KERNEL_DTS_FILE = $(call qstrip,$(BR2_LINUX_KERNEL_DTS_FILE))

?And the define should be wrapped in a
ifneq ($(LINUX_KERNEL_DTS_FILE),)
...
endif

linux/linux.mk define LINUX_CONFIGURE_CMDS · line 147

Quoted 10 lines

+endif

?ifeq ($(BR2_LINUX_KERNEL_USE_DEFCONFIG),y)
?KERNEL_SOURCE_CONFIG = $(KERNEL_ARCH_PATH)/configs/$(call qstrip,$(BR2_LINUX_KERNEL_DEFCONFIG))_defconfig

linux/linux.mk +2 -0

@@ -131,6 +143,8 @@ define LINUX_CONFIGURE_CMDS
 ? ? ? $(if $(BR2_ARM_EABI),
 ? ? ? ? ? ? ? $(call KCONFIG_ENABLE_OPT,CONFIG_AEABI,$(@D)/.config),
 ? ? ? ? ? ? ? $(call KCONFIG_DISABLE_OPT,CONFIG_AEABI,$(@D)/.config))
+ ? ?$(if $(BR2_microblaze),
+ ? ? ? ?$(call LINUX_COPY_DTS))

?No call is needed here, the COPY_DTS is not a function. ?And the condition isn't necessary: the variable will default to empty.

Quoted 31 lines

? ? ? # As the kernel gets compiled before root filesystems are ? ? ? # built, we create a fake cpio file. It'll be
? ? ? # replaced later by the real cpio archive, and the kernel will be

linux/linux.mk +0 -0

@@ -215,6 +229,8 @@ $(LINUX_DIR)/.stamp_initramfs_rebuilt: $(LINUX_DIR)/.stamp_target_installed $(LI
 ? ? ? $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(LINUX_IMAGE_NAME)

? ? ? # Copy the kernel image to its final destination
? ? ? cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
+ ? ? # If there is a .ub file copy it to the final destination
+ ? ? test -f $(LINUX_IMAGE_PATH).ub && cp $(LINUX_IMAGE_PATH).ub $(BINARIES_DIR) ? ? ? $(Q)touch $@

?# The initramfs building code must make sure this target gets called

target/Config.in.arch +0 -0

index 417441d..0524307 100644
@@ -21,6 +21,8 @@ config BR2_i386

?config BR2_m68k
? ? ? bool "m68k"
? ? ? depends on BROKEN # ice in uclibc / inet_ntoa_r +config BR2_microblaze
+ ? ?bool "microblaze"
?config BR2_mips
? ? ? bool "mips"
?config BR2_mipsel

target/Config.in.arch +0 -0

@@ -477,6 +479,19 @@ config BR2_powerpc_SPE

? ? ? depends on BR2_powerpc_8540 || BR2_powerpc_8548 || BR2_powerpc_e500mc ?endchoice

target/Config.in.arch +2 -0

+choice
+ ? ? prompt "Target Endianess"

target/Config.in.arch

Quoted 10 lines

target/Config.in.arch +10 -0

+ ? ? depends on BR2_microblaze
+ ? ? default BR2_microblazeel
+ ? ? help
+ ? ? ? Endianess of the Microblaze Processor
+
+config BR2_microblazeel
+ ? ? bool "Little Endian"
+config BR2_microblazebe
+ ? ? bool "Big Endian"
+endchoice

?For ARM and MIPS we define the endianness as the main architecture, not as a subarchitecture. ?I would do the same for microblaze.

?It does make sense to add a summarizing hidden BR2_microblaze, like this:

config BR2_microblaze
? ? ? ?bool
? ? ? ?default y if BR2_microblazeel || BR2_microblazebe

Quoted 26 lines

+
?config BR2_ARCH
? ? ? string
? ? ? default "arm" ? ? ? ? ? if BR2_arm

target/Config.in.arch +0 -0

@@ -508,6 +523,7 @@ config BR2_ARCH

? ? ? default "i686" ? ? ? ? ?if BR2_x86_athlon
? ? ? default "i686" ? ? ? ? ?if BR2_x86_athlon_4
? ? ? default "m68k" ? ? ? ? ?if BR2_m68k
+ ? ? default "microblaze" ? ?if BR2_microblaze
? ? ? default "mips" ? ? ? ? ?if BR2_mips
? ? ? default "mipsel" ? ? ? ?if BR2_mipsel
? ? ? default "powerpc" ? ? ? if BR2_powerpc

target/Config.in.arch +0 -0

@@ -533,11 +549,13 @@ config BR2_ARCH
 

?config BR2_ENDIAN
? ? ? string

- ? ? default "LITTLE" if BR2_arm || BR2_bfin || BR2_i386 || BR2_mipsel || \
- ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh3 || BR2_sh4 || BR2_sh4a || BR2_x86_64 || BR2_sh64
+ ? default "LITTLE" if BR2_arm || BR2_bfin || BR2_i386 || BR2_mipsel || \
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh3 || BR2_sh4 || BR2_sh4a || BR2_x86_64 || BR2_sh64 || \
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_microblazeel
? ? ? default "BIG" ? ?if BR2_armeb || BR2_avr32 || BR2_m68k || BR2_mips || \
- ? ? ? ? ? ? ? ? ? ? ? ? BR2_powerpc || BR2_sh2 || BR2_sh2a || \
- ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh3eb || BR2_sh4eb || BR2_sh4aeb || BR2_sparc
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_powerpc || BR2_sh2 || BR2_sh2a || BR2_sh3eb || \
+ ? ? ? ? ? ? ? ? ? ? ? ? BR2_sh4eb || BR2_sh4aeb || BR2_sparc || \

Quoted 5 lines

+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? BR2_microblazebe

?config BR2_GCC_TARGET_TUNE
? ? ? string

?Regards,
?Arnout

Quoted 7 lines

--
Arnout Vandecappelle ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? arnout at mind be Senior Embedded Software Architect ? ? ? ? ? ? ? ? +32-16-286540 Essensium/Mind ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium ? ? ? ? ? ? ? ?BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: ?7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Quoted 4 lines

--
Spenser Gilliland
Computer Engineer
Illinois Institute of Technology

--
Spenser Gilliland
Computer Engineer
Illinois Institute of Technology

I'm having an issue generating the dtb. What is the command in the kernel build needed to make a dts into a dtb. (should I just use dtc directly?)

Quoted 7 lines · On Tuesday 14 February 2012 06:02:26 Spenser Gilliland wrote:

I'm having an issue generating the dtb.??What is the command in the

kernel build needed to make a dts into a dtb. (should I just use dtc

directly?)

As I mentioned in an earlier mail:

$(MAKE) <linux make flags> <dtc basename>.dtb

Regards,

Arnout

--

Arnout Vandecappelle arnout at mind be

Senior Embedded Software Architect +32-16-286540

Essensium/Mind http://www.mind.be

G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven

LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle

GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Arnout,

I've tried a make target of both <DTS_NAME>.dtb and $(KERNEL_ARCH_PATH/boot/<DTS_NAME>.dtb with no success. Are you sure this is correct? I've tried this both within buildroot and just on a kernel tree directly with the microblaze toolchain.

Quoted 11 lines · On Thursday 16 February 2012 22:28:08 Spenser Gilliland wrote:

Arnout,

I've tried a make target of both <DTS_NAME>.dtb and

$(KERNEL_ARCH_PATH/boot/<DTS_NAME>.dtb with no success. Are you sure

this is correct? I've tried this both within buildroot and just on a

kernel tree directly with the microblaze toolchain.

I've never tried it myself, I've just looked at

http://www.denx.de/wiki/DULG/LinuxFDTBlob

Regards,

Arnout

--

Arnout Vandecappelle arnout at mind be

Senior Embedded Software Architect +32-16-286540

Essensium/Mind http://www.mind.be

G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven

LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle

GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Arnout,

I'm running into an issue downloading the toolchain. The toolchain is located in a tar ball inside a git repo. I tried the following in toolchain/toolchain-external/ext-tool.mk and it works from the command line but fails in a buildroot build.

ifeq ($(BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEBE_20),y)? TOOLCHAIN_EXTERNAL_SITE="
http://git.xilinx.com/?p=xldk/microblaze_v2.0.git;a=blob;f="?
TOOLCHAIN_EXTERNAL_SOURCE=microblaze-unknown-linux-gnu.tgz

It may be easier to just host these externally. Is there a host available for hosting tarballs?

Spenser

Quoted 14 lines · Spenser Gilliland

Arnout,

I agree with the comments. I'll get on it and have something ASAP. I want to have this in the coming release.

Additionally, I have been working on a Microblaze specific patch which adds the ability to copy parameters.h to the required directory in uboot. This is required to build a working u-boot for a custom board.

Spenser

On Mon, Feb 13, 2012 at 3:37 PM, Arnout Vandecappelle <[email protected]>

Quoted 4 lines · wrote:

Quoted 4 lines · On Monday 13 February 2012 02:03:58 Spenser Gilliland wrote:

Quoted 3 lines

Arnout,

This is the patch with some minor adjustments. I've tested it using a

big endian toolchain. Stephen used a little endian toolchain.

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

I got rid of the BR2_GCC_TARGET_TUNE as the build errored out when I

attempt it with the raw patch. The error stated that target tune was not supported by the compiler.

Quoted 9 lines

Quoted 9 lines

Quoted 2 lines

Spenser

Thanks for this patch!

A few remarks:

* Please add a relevant commit message. It starts with a single line short description followed by an empty line. Then one or more

paragraphs

Quoted 1 line

Quoted 1 line

of explanation (probably not much needed in this case). And finally,

one

Quoted 13 lines

Quoted 13 lines

or more Signed-off-by lines.

* Add a Signed-off-by line for yourself. This is a short way for you to assert that you are entitled to contribute the patch under buildroot's GPL license. See http://kerneltrap.org/files/Jeremy/DCO.txt for more details.

* In addition, include the Signed-off-by line of the original poster:

Signed-off-by Stephan Hoffmann <[email protected]>

* There were also a few remarks from Peter Kosgaard, Alvaro Gamez and Thomas Petazonni. Could you include those?

Quoted 8 lines

Quoted 8 lines

* See additional remarks below.

If you don't have the time to do all this yourself, please let us know
so someone else can take it over. Hopefully it won't fall between the cracks again :-)

[snip]

Review

Quoted 1 line

(quoted diff) +0 -0

b/configs/spartan6lx9_mb_defconfig

Quoted 4 lines

Quoted 4 lines

Quoted 4 lines

new file mode 100644
index 0000000..5ae1ede

configs/spartan6lx9_mb_defconfig new file +0 -0

Quoted 8 lines

Quoted 8 lines

configs/spartan6lx9_mb_defconfig line 5

Quoted 6 lines

configs/spartan6lx9_mb_defconfig new file +5 -0

@@ -0,0 +1,18 @@
+BR2_microblaze=y
+BR2_microblazel=y
+BR2_TOOLCHAIN_EXTERNAL=y
+BR2_TOOLCHAIN_EXTERNAL_PATH="/opt/microblazeel-unknown-linux-gnu/"
+BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="microblazeel-unknown-linux-gnu"

I don't think we should have defconfigs that depend on pre-extracted

toolchains.

Quoted 1 line

Quoted 1 line

Instead, the Xilinx toolchain should be added to the supported external

toolchains

Quoted 9 lines

Quoted 9 lines

like Sourcery.

configs/spartan6lx9_mb_defconfig line 9

Quoted 5 lines

configs/spartan6lx9_mb_defconfig new file +4 -0

+BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC=y
+BR2_TOOLCHAIN_EXTERNAL_CXX=y
 
+BR2_TARGET_GENERIC_HOSTNAME="Microblaze Buildroot"
+BR2_TARGET_GENERIC_ISSUE="Welcome to Microblaze Buildroot"

No need to change the defaults here.

Quoted 6 lines

Quoted 6 lines

configs/spartan6lx9_mb_defconfig line 14

Quoted 6 lines

configs/spartan6lx9_mb_defconfig new file +5 -0

+BR2_TARGET_GENERIC_GETTY_PORT="ttyUL0"
+# BR2_TARGET_ROOTFS_TAR is not set
+BR2_TARGET_ROOTFS_INITRAMFS=y
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y

+BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="$(TOPDIR)/board/relinux/avnet_LX9MicroBoard/lx9_mmu_defconfig"

Quoted 1 line

Quoted 1 line

Quoted 1 line

+BR2_LINUX_KERNEL_DTS_FILE="$(TOPDIR)/board/relinux/avnet_LX9MicroBoard/lx9_mmu.dts"

Quoted 1 line

Quoted 1 line

The $(TOPDIR)/ is redundant: the build is always executed from

$(TOPDIR).

Quoted 38 lines

Quoted 38 lines

Quoted 9 lines

configs/spartan6lx9_mb_defconfig new file +2 -0

+BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y
+BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="simpleImage.lx9_mmu"

linux/Config.in +0 -0

index 86dc32a..138feb3 100644
@@ -120,6 +120,14 @@ config BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE
      help

linux/Config.in config BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE · line 130

Quoted 10 lines

linux/Config.in +8 -0

        Path to the kernel configuration file
 
+config BR2_LINUX_KERNEL_DTS_FILE
+    string "Device Tree dts file location"
+    depends on BR2_microblaze
+    help
+      Path from where the dts file has to be copied
+      The final "custom target" name depends on the
+      dts file name:
+          <name>.dts --> simpleImage.<name>

Device tree support isn't specific to microblaze. It's incredible that
we didn't have that in buildroot yet! Can you make a separate patch to add device tree support? The generic device tree support of course wouldn't have the combination of zImage and .dtb into a simpleImage, so you'd have to add an explicit '$(MAKE) ....dtb' to the linux build commands.

Of course, there should also be support to select an in-kernel dts
(just like the in-kernel defconfigs).

Quoted 9 lines

linux/Config.in +0 -0

 #
 # Binary format
 #

linux/linux.mk +0 -0

index ae236d4..ade867a 100644
@@ -117,6 +117,18 @@ endef
 

Quoted 8 lines

Quoted 8 lines

linux/linux.mk endef · line 122

Quoted 5 lines

linux/linux.mk +3 -0

 LINUX_POST_PATCH_HOOKS += LINUX_APPLY_PATCHES
 
+ifeq ($(KERNEL_ARCH),microblaze)
+# on microblaze, we always want mkimage
+LINUX_DEPENDENCIES+=host-uboot-tools

I think you should define a new image type BR2_LINUX_KERNEL_SIMPLEIMAGE
for microblaze, and only add this dependency if that image type is

chosen.

Quoted 6 lines

Quoted 6 lines

linux/linux.mk endef

Quoted 6 lines

linux/linux.mk +4 -0

+
+define LINUX_COPY_DTS
+    if test -f "$(BR2_LINUX_KERNEL_DTS_FILE)" ; then \
+        cp $(BR2_LINUX_KERNEL_DTS_FILE)

$(@D)/arch/microblaze/boot/dts ; \

Quoted 10 lines

Quoted 10 lines

linux/linux.mk endef · line 130

Quoted 4 lines

linux/linux.mk +4 -0

+    else \
+        echo "Cannot copy dts file!" ; \
+    fi
+endef

The path should be $(KERNEL_ARCH_PATH)/boot/dts.

It requires an mkdir -p to make sure the target directory exists.

The test -f is redundant, since cp will simply fail and terminate the

build

Quoted 10 lines

Quoted 10 lines

if the source file doesn't exist.

You also need an extra make variable to remove the quotes:
LINUX_KERNEL_DTS_FILE = $(call qstrip,$(BR2_LINUX_KERNEL_DTS_FILE))

And the define should be wrapped in a
ifneq ($(LINUX_KERNEL_DTS_FILE),)
...
endif

Quoted 4 lines

Quoted 4 lines

linux/linux.mk endef

Quoted 4 lines

linux/linux.mk +1 -0

+endif
 
 ifeq ($(BR2_LINUX_KERNEL_USE_DEFCONFIG),y)
 KERNEL_SOURCE_CONFIG = $(KERNEL_ARCH_PATH)/configs/$(call

qstrip,$(BR2_LINUX_KERNEL_DEFCONFIG))_defconfig

Quoted 9 lines

Quoted 9 lines

linux/linux.mk define LINUX_CONFIGURE_CMDS · line 147

Quoted 6 lines

linux/linux.mk +2 -0

@@ -131,6 +143,8 @@ define LINUX_CONFIGURE_CMDS
      $(if $(BR2_ARM_EABI),
              $(call KCONFIG_ENABLE_OPT,CONFIG_AEABI,$(@D)/.config),
              $(call KCONFIG_DISABLE_OPT,CONFIG_AEABI,$(@D)/.config))
+    $(if $(BR2_microblaze),
+        $(call LINUX_COPY_DTS))

No call is needed here, the COPY_DTS is not a function. And the
condition isn't necessary: the variable will default to empty.

Quoted 4 lines

Quoted 4 lines

linux/linux.mk $(LINUX_DIR)/.stamp_initramfs_rebuilt:

Quoted 4 lines

linux/linux.mk +0 -0

      # As the kernel gets compiled before root filesystems are
      # built, we create a fake cpio file. It'll be
      # replaced later by the real cpio archive, and the kernel will be

@@ -215,6 +229,8 @@ $(LINUX_DIR)/.stamp_initramfs_rebuilt:

$(LINUX_DIR)/.stamp_target_installed $(LI

Quoted 1 line

Quoted 1 line

linux/linux.mk $(LINUX_DIR)/.stamp_initramfs_rebuilt: · line 229

Quoted 1 line

linux/linux.mk +0 -0

      $(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D)

$(LINUX_IMAGE_NAME)

Quoted 4 lines

Quoted 4 lines

linux/linux.mk $(LINUX_DIR)/.stamp_initramfs_rebuilt: $(LINUX_DIR)/.stamp_target_installed $(LI

Quoted 4 lines

linux/linux.mk +2 -0

      # Copy the kernel image to its final destination
      cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
+     # If there is a .ub file copy it to the final destination
+     test -f $(LINUX_IMAGE_PATH).ub && cp $(LINUX_IMAGE_PATH).ub

$(BINARIES_DIR)

Quoted 18 lines

Quoted 18 lines

Quoted 17 lines

linux/linux.mk +0 -0

      $(Q)touch $@
 
 # The initramfs building code must make sure this target gets called

target/Config.in.arch +2 -0

index 417441d..0524307 100644
@@ -21,6 +21,8 @@ config BR2_i386
 config BR2_m68k
      bool "m68k"
      depends on BROKEN # ice in uclibc / inet_ntoa_r
+config BR2_microblaze
+    bool "microblaze"
 config BR2_mips
      bool "mips"
 config BR2_mipsel

target/Config.in.arch config BR2_powerpc_SPE · line 479

Quoted 1 line

target/Config.in.arch +0 -0

@@ -477,6 +479,19 @@ config BR2_powerpc_SPE
      depends on BR2_powerpc_8540 || BR2_powerpc_8548 ||

BR2_powerpc_e500mc

Quoted 18 lines

Quoted 18 lines

Quoted 4 lines

target/Config.in.arch +2 -0

 endchoice
 
+choice
+     prompt "Target Endianess"

target/Config.in.arch config BR2_powerpc_SPE · line 493

Quoted 10 lines

target/Config.in.arch +10 -0

+     depends on BR2_microblaze
+     default BR2_microblazeel
+     help
+       Endianess of the Microblaze Processor
+
+config BR2_microblazeel
+     bool "Little Endian"
+config BR2_microblazebe
+     bool "Big Endian"
+endchoice

For ARM and MIPS we define the endianness as the main architecture, not
as a subarchitecture. I would do the same for microblaze.

Quoted 1 line

Quoted 1 line

It does make sense to add a summarizing hidden BR2_microblaze, like

this:

Quoted 19 lines

Quoted 19 lines

config BR2_microblaze

       bool
       default y if BR2_microblazeel || BR2_microblazebe

Quoted 14 lines

target/Config.in.arch +2 -0

+
 config BR2_ARCH
      string
      default "arm"           if BR2_arm

@@ -508,6 +523,7 @@ config BR2_ARCH
      default "i686"          if BR2_x86_athlon
      default "i686"          if BR2_x86_athlon_4
      default "m68k"          if BR2_m68k
+     default "microblaze"    if BR2_microblaze
      default "mips"          if BR2_mips
      default "mipsel"        if BR2_mipsel
      default "powerpc"       if BR2_powerpc

@@ -533,11 +549,13 @@ config BR2_ARCH
 

Quoted 3 lines

Quoted 3 lines

target/Config.in.arch config BR2_ARCH

Quoted 3 lines

target/Config.in.arch +0 -1

 config BR2_ENDIAN
      string
-     default "LITTLE" if BR2_arm || BR2_bfin || BR2_i386 ||

BR2_mipsel || \

Quoted 1 line

Quoted 1 line

target/Config.in.arch config BR2_ARCH · line 537

Quoted 1 line

target/Config.in.arch +0 -1

-                         BR2_sh3 || BR2_sh4 || BR2_sh4a || BR2_x86_64

|| BR2_sh64
>>> +   default "LITTLE" if BR2_arm || BR2_bfin || BR2_i386 || BR2_mipsel
|| \
>>> +                         BR2_sh3 || BR2_sh4 || BR2_sh4a || BR2_x86_64
|| BR2_sh64 || \
>>> +                         BR2_microblazeel
>>>       default "BIG"    if BR2_armeb || BR2_avr32 || BR2_m68k ||
BR2_mips || \
>>> -                         BR2_powerpc || BR2_sh2 || BR2_sh2a || \
>>> -                         BR2_sh3eb || BR2_sh4eb || BR2_sh4aeb ||

BR2_sparc

Quoted 1 line

Quoted 1 line

target/Config.in.arch config BR2_ARCH · line 552

Quoted 1 line

target/Config.in.arch +1 -0

+                         BR2_powerpc || BR2_sh2 || BR2_sh2a ||

BR2_sh3eb || \

Quoted 8 lines

Quoted 8 lines

Quoted 6 lines

target/Config.in.arch +2 -0

+                         BR2_sh4eb || BR2_sh4aeb || BR2_sparc || \
+                             BR2_microblazebe
 
 config BR2_GCC_TARGET_TUNE
      string
 

Quoted 8 lines

Quoted 8 lines

Regards,
Arnout

--

Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR

Leuven

Quoted 9 lines

Quoted 2 lines

LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

--
Spenser Gilliland
Computer Engineer
Illinois Institute of Technology

--
Spenser Gilliland
Computer Engineer
Illinois Institute of Technology
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

"Alvaro" == Alvaro Gamez <[email protected]> writes:

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

+BR2_TOOLCHAIN_EXTERNAL=y

configs/spartan6lx9_mb_defconfig line 5

Quoted 2 lines

configs/spartan6lx9_mb_defconfig new file +2 -0

+BR2_TOOLCHAIN_EXTERNAL_PATH="/opt/microblazeel-unknown-linux-gnu/"
+BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="microblazeel-unknown-linux-gnu"

I don't think we should have defconfigs that depend on pre-extracted toolchains.
Instead, the Xilinx toolchain should be added to the supported external toolchains like Sourcery.

+BR2_TARGET_GENERIC_HOSTNAME="Microblaze Buildroot"

Quoted 1 line

+BR2_TARGET_GENERIC_ISSUE="Welcome to Microblaze Buildroot"

No need to change the defaults here.

configs/spartan6lx9_mb_defconfig line 16

Quoted 2 lines

configs/spartan6lx9_mb_defconfig new file +2 -0

+BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="$(TOPDIR)/board/relinux/avnet_LX9MicroBoard/lx9_mmu_defconfig"
+BR2_LINUX_KERNEL_DTS_FILE="$(TOPDIR)/board/relinux/avnet_LX9MicroBoard/lx9_mmu.dts"

The $(TOPDIR)/ is redundant: the build is always executed from $(TOPDIR).

Alvaro's Patch to load the toolchain from Xilinx does not work for me.
http://git.xilinx.com always ends up with a timeout leaving an empty tgz-file in the dl folder after the third try. To come further I downloaded the tgz manually.

Hi

2012/3/11 Stephan Hoffmann <sho at relinux.de <mailto:[email protected]>>

Alvaro's Patch to load the toolchain from Xilinx does not work for me.
http://git.xilinx.com always ends up with a timeout leaving an empty tgz-file in the dl folder after the third try. To come further I downloaded the tgz manually.

I don't see the reason for this. I've downloaded it several times with no problem. Maybe there has been some DNS issues or the server was down for a while?

Signature · 2 lines

-- 
?lvaro G?mez Machado

I see, seems you are right. Now the download seems to work better. But it loads a XML file. The URL wget tries to load is:

http://git.xilinx.com/?p=xldk/microblaze_v2.0_le.git;a=blob;hb=HEAD;f=/microblazeel-unknown-linux-gnu.tgz

This extra "/" in front of the filename seems to be the problem. In fact, I don't know where it comes from;-(

Quoted 8 lines

I see, seems you are right. Now the download seems to work better. But it loads a XML file. The URL wget tries to load is:

http://git.xilinx.com/?p=xldk/microblaze_v2.0_le.git;a=blob;hb=HEAD;f=/microblazeel-unknown-linux-gnu.tgz

This extra "/" in front of the filename seems to be the problem. In fact, I don't know where it comes from;-(

Alvaro had patches that refactored the DOWNLOAD macro so the / was
removed. Did you apply those patches?

Regards,
Arnout