Skip to contentSkip to conversation

small bug in mkfs.cramfs + patch

PATCH Applied Arnaud Mouiche 2 participants 2 messages Nov 17, 2011 – Nov 23, 2011 Util-Linux package

lore
Share & tools
lore
#0 lore raw

Hi all.

mkfs.cramfs on version v2.17.2 has a small bug when dealing with very small filesystems. look at upstream code on git, and the issue is still here.

ex:

        $ cd /tmp
        $ mkdir content
        $ echo hello > content/a
        $ echo hello > content/b
        $ mkfs.cramfs content content.cramfs
        not enough space allocated for ROM image (4090 allocated, 4096 
used)

Here is a patch for fixing (simply rounding to page size AFTER eleminating doubles) Regards,
Arnaud

disk-utils/mkfs.cramfs.c +0 -0
index 4ffa908..30f6b4b 100644
@@ -843,6 +843,9 @@ int main(int argc, char **argv)
 
        root_entry->size = parse_directory(root_entry, dirname, 

&root_entry->child, &fslen_ub);

+ /* find duplicate files */
+ eliminate_doubles(root_entry,root_entry, &fslen_ub);
+

        /* always allocate a multiple of blksize bytes because that's
            what we're going to write later on */
        fslen_ub = ((fslen_ub - 1) | (blksize - 1)) + 1;
@@ -858,9 +861,6 @@ int main(int argc, char **argv)
                fslen_ub = fslen_max;
        }

- /* find duplicate files */
- eliminate_doubles(root_entry,root_entry, &fslen_ub);
-
/* TODO: Why do we use a private/anonymous mapping here
followed by a write below, instead of just a shared mapping and a couple of ftruncate calls? Is it just to save us
(

maintainer Applied
#1 lore raw
Quoted 6 lines · Arnaud Mouiche
        $ cd /tmp
        $ mkdir content
        $ echo hello > content/a
        $ echo hello > content/b
        $ mkfs.cramfs content content.cramfs
        not enough space allocated for ROM image (4090 allocated, 4096  

Applied, thanks.

Signature · 2 lines
 Karel Zak  <[email protected]>
 http://karelzak.blogspot.com