Skip to contentSkip to conversation

Moving scan logic into work-queue?

DISCUSSION Ben Greear 2 participants 3 messages Nov 29, 2011

lore
Share & tools
lore

Ben Greear

author
#0 lore raw

We've talked before about moving the scan logic into the work-queue.

Since my previous attempts at optimizing this code for scanning & off-channel work didn't stick, I thought I might attempt to convert the scan logic to the work-queue, with hopes of then being able to make another attempt at optimizing things for multiple interfaces & potentially off-channel work items.

Before I start though, I'm hoping for some guidance on how you'd want this implemented. Or, if you think there are other changes that should go in first, I'll wait...

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
#1 lore raw
Quoted 1 line · Ben Greear

We've talked before about moving the scan logic into the work-queue.

I think you mean ieee80211_work, not work-queue.

Quoted 9 lines

Since my previous attempts at optimizing this code for scanning & off-channel work didn't stick, I thought I might attempt to convert the scan logic to the work-queue, with hopes of then being able to make another attempt at optimizing things for multiple interfaces & potentially off-channel work items.

Before I start though, I'm hoping for some guidance on how you'd want this implemented. Or, if you think there are other changes that should go in first, I'll wait...

In any case, yes, please don't work on this now. I need to rework auth & assoc handling completely, and get rid of the work items for that etc. That will probably mean a large rewrite of the work item logic, possibly even removing most of that code.

johannes

author
#2 lore raw
Quoted 11 lines · Johannes Berg
Quoted 1 line · Ben Greear

We've talked before about moving the scan logic into the work-queue.

I think you mean ieee80211_work, not work-queue.

Quoted 6 lines

Since my previous attempts at optimizing this code for scanning& off-channel work didn't stick, I thought I might attempt to convert the scan logic to the work-queue, with hopes of then being able to make another attempt at optimizing things for multiple interfaces& potentially off-channel work items.

Quoted 8 lines
Quoted 3 lines

Before I start though, I'm hoping for some guidance on how you'd want this implemented. Or, if you think there are other changes that should go in first, I'll wait...

In any case, yes, please don't work on this now. I need to rework auth& assoc handling completely, and get rid of the work items for that etc. That will probably mean a large rewrite of the work item logic, possibly even removing most of that code.

Ok, I'll wait to see how that turns out.

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com