Skip to contentSkip to conversation

Alter order of file systems tried by mount

PATCH In review Gary Thomas 3 participants 7 messages Nov 30, 2011 – Jan 3, 2012

lore
Share & tools
lore

Gary Thomas

author
#0 lore raw

PATCH 1/1 Alter order of file systems tried by mount

The file /etc/filesystems is used by busybox 'mount' when attempting to mount a file system when the type is not specified. This change alters the order so that more capable systems are tried first. Without this change, an EXT3 system will mount as EXT2 which disables many of the EXT3 features. With the change, EXT3 systems are mounted properly.

Signed-off-by Gary Thomas <[email protected]>
---
 .../recipes-core/base-files/base-files/filesystems |    8 ++++----
 meta/recipes-core/base-files/base-files_3.0.14.bb  |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
meta/recipes-core/base-files/base-files/filesystems +4 -4
index 2af6a7e..14f5abb 100644
@@ -1,7 +1,7 @@
-minix
-fat
-vfat
-ext2
 ext3
+ext2
+vfat
+fat
 btrfs
+minix
 *
meta/recipes-core/base-files/base-files_3.0.14.bb +1 -1
index 8f5313b..c860d70 100644
@@ -1,7 +1,7 @@
 SUMMARY = "Miscellaneous files for the base system."
 DESCRIPTION = "The base-files package creates the basic system directory structure and provides a small set of key configuration files for the system."
 SECTION = "base"
-PR = "r69"
+PR = "r70"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://licenses/GPL-2;md5=94d55d512a9ba36caa9b7df079bae19f"
 SRC_URI = "file://rotation \
Signature · 1 line
1.7.6.4
#1 lore raw

Hello.

Quoted 19 lines · Gary Thomas

The file /etc/filesystems is used by busybox 'mount' when attempting to mount a file system when the type is not specified. This change alters the order so that more capable systems are tried first. Without this change, an EXT3 system will mount as EXT2 which disables many of the EXT3 features. With the change, EXT3 systems are mounted properly.

Signed-off-by Gary Thomas <[email protected]>
---
 .../recipes-core/base-files/base-files/filesystems |    8 ++++----
 meta/recipes-core/base-files/base-files_3.0.14.bb  |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
meta/recipes-core/base-files/base-files/filesystems +0 -0
index 2af6a7e..14f5abb 100644

meta/recipes-core/base-files/base-files/filesystems line 6

Quoted 10 lines
meta/recipes-core/base-files/base-files/filesystems +4 -4
@@ -1,7 +1,7 @@
-minix
-fat
-vfat
-ext2
 ext3
+ext2
+vfat
+fat
 btrfs
+minix

In the commit message you explain the problem with ext2/3. And I agree that it makes sense to start with ext3. Actually, adding ext4 would make sense, too.

What is the deal with the re-ordering of fat/vfat/minix though? Looks unrelated to me.

regards
Stefan Schmidt

author
#2 lore raw
Quoted 28 lines · Stefan Schmidt

Hello.

Quoted 25 lines · Gary Thomas

The file /etc/filesystems is used by busybox 'mount' when attempting to mount a file system when the type is not specified. This change alters the order so that more capable systems are tried first. Without this change, an EXT3 system will mount as EXT2 which disables many of the EXT3 features. With the change, EXT3 systems are mounted properly.

Signed-off-by Gary Thomas<[email protected]>
---
  .../recipes-core/base-files/base-files/filesystems |    8 ++++----
  meta/recipes-core/base-files/base-files_3.0.14.bb  |    2 +-
  2 files changed, 5 insertions(+), 5 deletions(-)
meta/recipes-core/base-files/base-files/filesystems +1 -4
index 2af6a7e..14f5abb 100644
@@ -1,7 +1,7 @@
-minix
-fat
-vfat
-ext2
  ext3
+ext2
Quoted 8 lines

meta/recipes-core/base-files/base-files/filesystems line 6

Quoted 4 lines
meta/recipes-core/base-files/base-files/filesystems +3 -0
+vfat
+fat
  btrfs
+minix

In the commit message you explain the problem with ext2/3. And I agree that it makes sense to start with ext3. Actually, adding ext4 would make sense, too.

Agreed.

Quoted 3 lines

What is the deal with the re-ordering of fat/vfat/minix though? Looks unrelated to me.

Same argument as above - try more capable file systems first. I also moved minix to the end as it is rarely, if ever, used.

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
Acked-by
#3 lore raw

Hello.

Quoted 36 lines · Gary Thomas
Quoted 26 lines · Stefan Schmidt
Quoted 25 lines · Gary Thomas

The file /etc/filesystems is used by busybox 'mount' when attempting to mount a file system when the type is not specified. This change alters the order so that more capable systems are tried first. Without this change, an EXT3 system will mount as EXT2 which disables many of the EXT3 features. With the change, EXT3 systems are mounted properly.

Signed-off-by Gary Thomas<[email protected]>
---
 .../recipes-core/base-files/base-files/filesystems |    8 ++++----
 meta/recipes-core/base-files/base-files_3.0.14.bb  |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
meta/recipes-core/base-files/base-files/filesystems +1 -4
index 2af6a7e..14f5abb 100644
@@ -1,7 +1,7 @@
-minix
-fat
-vfat
-ext2
 ext3
+ext2
Quoted 8 lines

meta/recipes-core/base-files/base-files/filesystems line 6

Quoted 4 lines
meta/recipes-core/base-files/base-files/filesystems +3 -0
+vfat
+fat
 btrfs
+minix

In the commit message you explain the problem with ext2/3. And I agree that it makes sense to start with ext3. Actually, adding ext4 would make sense, too.

Quoted 1 line

Agreed.

In the mood to add it and send an updated version of this patch? :)

Quoted 5 lines
Quoted 2 lines

What is the deal with the re-ordering of fat/vfat/minix though? Looks unrelated to me.

Same argument as above - try more capable file systems first. I also moved minix to the end as it is rarely, if ever, used.

Ah, now I see that you also moved vfat before fat. Missed that before.

Acked-by Stefan Schmidt <[email protected]>

regards
Stefan Schmidt

author
#4 lore raw
In reply to Gary Thomas
Quoted 40 lines · Gary Thomas

The file /etc/filesystems is used by busybox 'mount' when attempting to mount a file system when the type is not specified. This change alters the order so that more capable systems are tried first. Without this change, an EXT3 system will mount as EXT2 which disables many of the EXT3 features. With the change, EXT3 systems are mounted properly.

Signed-off-by Gary Thomas <[email protected]>

---
.../recipes-core/base-files/base-files/filesystems | 8 ++++---- meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-

2 files changed, 5 insertions(+), 5 deletions(-)
meta/recipes-core/base-files/base-files/filesystems +0 -4
index 2af6a7e..14f5abb 100644
@@ -1,7 +1,7 @@
-minix
-fat
-vfat
-ext2

ext3

meta/recipes-core/base-files/base-files/filesystems +3 -0
+ext2
+vfat
+fat

btrfs
+minix
*

meta/recipes-core/base-files/base-files_3.0.14.bb +0 -0
index 8f5313b..c860d70 100644
@@ -1,7 +1,7 @@

SUMMARY = "Miscellaneous files for the base system."
DESCRIPTION = "The base-files package creates the basic system directory structure and provides a small set of key configuration files for the system." SECTION = "base"

meta/recipes-core/base-files/base-files_3.0.14.bb +1 -1
-PR = "r69"
+PR = "r70"
Quoted 3 lines

LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://licenses/GPL-2;md5=94d55d512a9ba36caa9b7df079bae19f" SRC_URI = "file://rotation \

What about this patch (now 1 month old, with no action or discussion)?

Thanks

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#5 lore raw
Quoted 43 lines · Gary Thomas
Quoted 42 lines · Gary Thomas

The file /etc/filesystems is used by busybox 'mount' when attempting to mount a file system when the type is not specified. This change alters the order so that more capable systems are tried first. Without this change, an EXT3 system will mount as EXT2 which disables many of the EXT3 features. With the change, EXT3 systems are mounted properly.

Signed-off-by Gary Thomas <[email protected]>

---
.../recipes-core/base-files/base-files/filesystems | 8 ++++---- meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-

2 files changed, 5 insertions(+), 5 deletions(-)
meta/recipes-core/base-files/base-files/filesystems +0 -4
index 2af6a7e..14f5abb 100644
@@ -1,7 +1,7 @@
-minix
-fat
-vfat
-ext2

ext3

meta/recipes-core/base-files/base-files/filesystems +3 -0
+ext2
+vfat
+fat

btrfs
+minix
*

meta/recipes-core/base-files/base-files_3.0.14.bb +0 -0
index 8f5313b..c860d70 100644
@@ -1,7 +1,7 @@

SUMMARY = "Miscellaneous files for the base system." DESCRIPTION = "The base-files package creates the basic system directory structure and provides a small set of key configuration files for the system."
SECTION = "base"

Quoted 9 lines
Quoted 6 lines
meta/recipes-core/base-files/base-files_3.0.14.bb +1 -1
-PR = "r69"
+PR = "r70"

LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://licenses/GPL-2;md5=94d55d512a9ba36caa9b7df079bae19f" SRC_URI = "file://rotation \

What about this patch (now 1 month old, with no action or discussion)?

Looks like there were some comments between you and Stefan about adding ext4, so I was waiting for an updated version.

Sau!

Quoted 2 lines

Thanks

author
#6 lore raw
Quoted 53 lines · Saul Wold
Quoted 43 lines · Gary Thomas
Quoted 42 lines · Gary Thomas

The file /etc/filesystems is used by busybox 'mount' when attempting to mount a file system when the type is not specified. This change alters the order so that more capable systems are tried first. Without this change, an EXT3 system will mount as EXT2 which disables many of the EXT3 features. With the change, EXT3 systems are mounted properly.

Signed-off-by Gary Thomas <[email protected]>

---
.../recipes-core/base-files/base-files/filesystems | 8 ++++---- meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-

2 files changed, 5 insertions(+), 5 deletions(-)
meta/recipes-core/base-files/base-files/filesystems +0 -4
index 2af6a7e..14f5abb 100644
@@ -1,7 +1,7 @@
-minix
-fat
-vfat
-ext2

ext3

meta/recipes-core/base-files/base-files/filesystems +3 -0
+ext2
+vfat
+fat

btrfs
+minix
*

meta/recipes-core/base-files/base-files_3.0.14.bb +0 -0
index 8f5313b..c860d70 100644
@@ -1,7 +1,7 @@

SUMMARY = "Miscellaneous files for the base system." DESCRIPTION = "The base-files package creates the basic system directory structure and provides a small set of key configuration files for the system."
SECTION = "base"

Quoted 9 lines
Quoted 6 lines
meta/recipes-core/base-files/base-files_3.0.14.bb +1 -1
-PR = "r69"
+PR = "r70"

LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://licenses/GPL-2;md5=94d55d512a9ba36caa9b7df079bae19f" SRC_URI = "file://rotation \

What about this patch (now 1 month old, with no action or discussion)?

Quoted 1 line

Looks like there were some comments between you and Stefan about adding ext4, so I was waiting for an updated version.

OK, I'll add that and send a new patch once I can test it.

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------