Skip to contentSkip to conversation

mm/hugetlb.c: cleanup to use long vars instead of int in region_count

PATCH In review Wang Sheng-Hui 3 participants 5 messages Dec 13, 2011 – Apr 4, 2012

Subsystems (2)
Memory management HugeTLB
lore
Share & tools
lore

Wang Sheng-Hui

author
#0 lore raw

PATCH 1/1 mm/hugetlb.c: cleanup to use long vars instead of int in region_count

args f & t and fields from & to of struct file_region are defined as long. Use long instead of int to type the temp vars.

Signed-off-by Wang Sheng-Hui <[email protected]>
---
 mm/hugetlb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
mm/hugetlb.c +2 -2
index dae27ba..e666287 100644
@@ -195,8 +195,8 @@ static long region_count(struct list_head *head, long f, long t)
 
 	/* Locate each segment we overlap with, and count that overlap. */
 	list_for_each_entry(rg, head, link) {
-		int seg_from;
-		int seg_to;
+		long seg_from;
+		long seg_to;
 
 		if (rg->to <= f)
 			continue;
Signature · 8 lines
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Wang Sheng-Hui

args f & t and fields from & to of struct file_region are defined as long. Use long instead of int to type the temp vars.

Signed-off-by Wang Sheng-Hui <[email protected]>
Acked-by David Rientjes <[email protected]>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Acked-by on v1 1/1
#2 lore raw
In reply to Wang Sheng-Hui
Quoted 13 lines · Wang Sheng-Hui

args f & t and fields from & to of struct file_region are defined as long. Use long instead of int to type the temp vars.

Signed-off-by Wang Sheng-Hui <[email protected]>
---
 mm/hugetlb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
mm/hugetlb.c +0 -0
index dae27ba..e666287 100644

mm/hugetlb.c static long region_count(struct list_head *head, long f, long t) · line 202

Quoted 10 lines
mm/hugetlb.c +2 -2
@@ -195,8 +195,8 @@ static long region_count(struct list_head *head, long f, long t)
 
 	/* Locate each segment we overlap with, and count that overlap. */
 	list_for_each_entry(rg, head, link) {
-		int seg_from;
-		int seg_to;
+		long seg_from;
+		long seg_to;
 
 		if (rg->to <= f)
 			continue;
Acked-by David Rientjes <[email protected]>

Andrew, it looks like this never made it to linux-next.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#3 lore raw
Quoted 23 lines · David Rientjes
Quoted 21 lines · Wang Sheng-Hui

args f & t and fields from & to of struct file_region are defined as long. Use long instead of int to type the temp vars.

Signed-off-by Wang Sheng-Hui <[email protected]>
---
 mm/hugetlb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
mm/hugetlb.c +2 -2
index dae27ba..e666287 100644
@@ -195,8 +195,8 @@ static long region_count(struct list_head *head, long f, long t)
 
 	/* Locate each segment we overlap with, and count that overlap. */
 	list_for_each_entry(rg, head, link) {
-		int seg_from;
-		int seg_to;
+		long seg_from;
+		long seg_to;
Quoted 7 lines

mm/hugetlb.c static long region_count(struct list_head *head, long f, long t) · line 202

Quoted 2 lines
mm/hugetlb.c +0 -0
 		if (rg->to <= f)
 			continue;
Acked-by David Rientjes <[email protected]>

Andrew, it looks like this never made it to linux-next.

Still not in linux-next as of today.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Acked-by
#4 lore raw
Quoted 25 lines · David Rientjes
Quoted 23 lines · David Rientjes
Quoted 21 lines · Wang Sheng-Hui

args f & t and fields from & to of struct file_region are defined as long. Use long instead of int to type the temp vars.

Signed-off-by Wang Sheng-Hui <[email protected]>

---
 mm/hugetlb.c |    4 ++--

 1 files changed, 2 insertions(+), 2 deletions(-)
mm/hugetlb.c +2 -2
index dae27ba..e666287 100644
@@ -195,8 +195,8 @@ static long region_count(struct list_head *head, long f, long t)
 
     /* Locate each segment we overlap with, and count that overlap. */
     list_for_each_entry(rg, head, link) {
-           int seg_from;
-           int seg_to;
+           long seg_from;
+           long seg_to;
Quoted 5 lines
Quoted 5 lines

mm/hugetlb.c static long region_count(struct list_head *head, long f, long t) · line 202

Quoted 2 lines
mm/hugetlb.c +0 -0
             if (rg->to <= f)
                     continue;
Acked-by David Rientjes <[email protected]>
Acked-by Hillf Danton <[email protected]>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>