Skip to contentSkip to conversation

mm/mempolicy.c: use enum value MPOL_REBIND_ONCE instead of 0 in mpol_rebind_policy

PATCH In review Wang Sheng-Hui 2 participants 5 messages Dec 14, 2011 – Dec 19, 2011

Subsystems (2)
Memory management MM NUMA placement
lore
Share & tools
lore

Wang Sheng-Hui

author
#0 lore raw

PATCH 1/1 mm/mempolicy.c: use enum value MPOL_REBIND_ONCE instead of 0 in mpol_rebind_policy

We have enum definition in mempolicy.h: MPOL_REBIND_ONCE. It should replace the magic number 0 for step comparison in function mpol_rebind_policy.

Signed-off-by Wang Sheng-Hui <[email protected]>
---
 mm/mempolicy.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
mm/mempolicy.c +1 -1
index 9c51f9f..ecdaa8d 100644
@@ -390,7 +390,7 @@ static void mpol_rebind_policy(struct mempolicy *pol, const nodemask_t *newmask,
 {
 	if (!pol)
 		return;
-	if (!mpol_store_user_nodemask(pol) && step == 0 &&
+	if (!mpol_store_user_nodemask(pol) && step == MPOL_REBIND_ONCE &&
 	    nodes_equal(pol->w.cpuset_mems_allowed, *newmask))
 		return;
Signature · 9 lines
1.7.1


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Wang Sheng-Hui

We have enum definition in mempolicy.h: MPOL_REBIND_ONCE. It should replace the magic number 0 for step comparison in function mpol_rebind_policy.

Signed-off-by Wang Sheng-Hui <[email protected]>
Acked-by David Rientjes <[email protected]>

Tip: when proposing patches, it's helpful to run scripts/get_maintainer.pl on your patch file from git to determine who should be cc'd on the email.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

author
#2 lore raw
Quoted 6 lines · David Rientjes
Quoted 4 lines · Wang Sheng-Hui

We have enum definition in mempolicy.h: MPOL_REBIND_ONCE. It should replace the magic number 0 for step comparison in function mpol_rebind_policy.

Quoted 6 lines
Quoted 1 line
Signed-off-by Wang Sheng-Hui <[email protected]>
Acked-by David Rientjes <[email protected]>

Tip: when proposing patches, it's helpful to run scripts/get_maintainer.pl on your patch file from git to determine who should be cc'd on the email.

Thanks for your tip.
I have tried the script with option -f, and only get the mm, kernel mailing lists, no specific maintainer provided. So here I just posted the patch to these 2 lists.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#3 lore raw
Quoted 8 lines · Wang Sheng-Hui
Quoted 2 lines

Tip: when proposing patches, it's helpful to run scripts/get_maintainer.pl on your patch file from git to determine who should be cc'd on the email.

Thanks for your tip.
I have tried the script with option -f, and only get the mm, kernel mailing lists, no specific maintainer provided. So here I just posted the patch to these 2 lists.

$ ./scripts/get_maintainer.pl -f mm/mempolicy.c
Andrew Morton <[email protected]> (commit_signer:19/23=83%)
KOSAKI Motohiro <[email protected]> (commit_signer:8/23=35%)
Stephen Wilson <[email protected]> (commit_signer:6/23=26%)
Andrea Arcangeli <[email protected]> (commit_signer:5/23=22%)
Johannes Weiner <[email protected]> (commit_signer:3/23=13%)
[email protected] (open list:MEMORY MANAGEMENT)
[email protected] (open list)

All of those people should be cc'd on patches touching mm/mempolicy.c.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

author
#4 lore raw
Quoted 21 lines · David Rientjes
Quoted 8 lines · Wang Sheng-Hui
Quoted 2 lines

Tip: when proposing patches, it's helpful to run scripts/get_maintainer.pl on your patch file from git to determine who should be cc'd on the email.

Thanks for your tip.
I have tried the script with option -f, and only get the mm, kernel mailing lists, no specific maintainer provided. So here I just posted the patch to these 2 lists.

$ ./scripts/get_maintainer.pl -f mm/mempolicy.c
Andrew Morton <[email protected]> (commit_signer:19/23=83%)
KOSAKI Motohiro <[email protected]> (commit_signer:8/23=35%)
Stephen Wilson <[email protected]> (commit_signer:6/23=26%)
Andrea Arcangeli <[email protected]> (commit_signer:5/23=22%)
Johannes Weiner <[email protected]> (commit_signer:3/23=13%)
[email protected] (open list:MEMORY MANAGEMENT)
[email protected] (open list)
Quoted 1 line

All of those people should be cc'd on patches touching mm/mempolicy.c.

Got it. Thanks,

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>