eCryptfs: how to submit a patch
Quoted 1 line · Ben Siemerink
Hello Douglas,
Howdy, I go by "Dustin", FWIW...
Quoted 11 lines
How are you?
I am looking into eCryptfs and Ubuntu's auto-mounting private home directory. I already use it on my laptop, but now want to secure the home directories on my development computer as well.
Anyway, I saw that the key length is hard-coded in the mount.ecryptfs_private utility and tried to change it and recompile it. Doing so I encountered the incorrect usage of the locally defined
KEY_LENGTHfor the signature length, which should beECRYPTFS_SIG_SIZE_HEXas defined inecryptfs.h.
I think you should be able to do this already, using the "ALIAS" feature, as described in the manpage:
* http://manpg.es/mount.ecryptfs_private
Quoted 3 lines
I have a patch ready, but have no experience with submitting code to Launchpad. What is the preferred way to submit the code? Create a new branch on Launchpad? Send you the patch by email?
Ah, well, that's a good question! As a response, I just committed a new file to the repository, CONTRIBUTING, which you can see here:
* http://bazaar.launchpad.net/~ecryptfs/ecryptfs/trunk/view/head:/CONTRIBUTING
Quoted 5 lines
Furthermore I would like the Private directory feature to accept various key lengths (16, 24 and 32 bytes). I saw that the current code explicitly ignores mount options in the alias.conf files. I guess that there may be security reasons for doing so, perhaps because of the set-uid permission. Could you please shed some light on it?
Right, it is essential that any user-provided input to mount.ecryptfs_private is *totally* sanitized, since it is a setuid binary.
I'd suggest first that you try the aforementioned ALIAS feature, and see if that works well enough for you. If it doesn't, then yeah, send your patch along! We're always happy to have new contributions :-)
Signature · 6 lines
:-Dustin Dustin Kirkland Chief Architect Gazzang, Inc. www.gazzang.com