Skip to contentSkip to conversation

igb: reset PHY after recovering from PHY power down

PATCH In review Koki Sanagi 3 participants 3 messages Dec 19, 2011 – Dec 22, 2011

Subsystems (3)
Networking Network drivers Intel Ethernet
lore
Share & tools
lore

Koki Sanagi

author
#0 lore raw

PATCH v2 1/1 igb: reset PHY after recovering from PHY power down

According to 82576_Datasheet.pdf, PHY setting is lost after PHY power down. So resetting PHY is needed when recovering from PHY power down to set a default setting to PHY register.
Owing to this lack, NIC doesn't link up in some rare situation.

Signed-off-by Koki Sanagi <[email protected]>

---

drivers/net/ethernet/intel/igb/igb_main.c +1 -0
index 89d576c..9b923b0 100644
@@ -1498,6 +1498,7 @@ void igb_power_up_link(struct igb_adapter *adapter)
 		igb_power_up_phy_copper(&adapter->hw);
 	else
 		igb_power_up_serdes_link_82575(&adapter->hw);
+	igb_reset_phy(&adapter->hw);
 }
 
 /**

------------------------------------------------------------------------------
Learn Windows Azure Live! Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for developers. It will provide a great way to learn Windows Azure and what it provides. You can attend the event by watching it streamed LIVE online.
Learn more at http://p.sf.net/sfu/ms-windowsazure
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

#1 lore raw
Quoted 35 lines

-----Original Message-----
From: Koki Sanagi [mailto:[email protected]]
Sent: Sunday, December 18, 2011 5:24 PM
To: [email protected]
Cc: [email protected]; [email protected]; Wyborny, Carolyn; Kirsher, Jeffrey T; Brandeburg, Jesse; Allan, Bruce W; Skidmore, Donald C; Rose, Gregory V; Waskiewicz Jr, Peter P; Duyck, Alexander H; Ronciak, John
Subject: [PATCH net-next v2] igb: reset PHY after recovering from PHY power down

According to 82576_Datasheet.pdf, PHY setting is lost after PHY power down.
So resetting PHY is needed when recovering from PHY power down to set a default
setting to PHY register.
Owing to this lack, NIC doesn't link up in some rare situation.

Signed-off-by Koki Sanagi <[email protected]>

---

drivers/net/ethernet/intel/igb/igb_main.c +1 -0
index 89d576c..9b923b0 100644
@@ -1498,6 +1498,7 @@ void igb_power_up_link(struct igb_adapter
 *adapter)
 		igb_power_up_phy_copper(&adapter->hw);
 	else
 		igb_power_up_serdes_link_82575(&adapter->hw);
+	igb_reset_phy(&adapter->hw);
 }
Quoted 1 line

/**

ACK

Carolyn Wyborny
Linux Development
LAN Access Division
Intel Corporation

#2 lore raw
In reply to Koki Sanagi
Quoted 8 lines · Koki Sanagi

According to 82576_Datasheet.pdf, PHY setting is lost after PHY power down.
So resetting PHY is needed when recovering from PHY power down to set a default
setting to PHY register.
Owing to this lack, NIC doesn't link up in some rare situation.

Signed-off-by Koki Sanagi <[email protected]>

I have added this patch to my queue. Thanks Koki!