Skip to contentSkip to conversation

cleanup: mm/migrate.c: cleanup comment for function migration_entry_wait

PATCH In review Wang Sheng-Hui 2 participants 2 messages Dec 21, 2011

Subsystems (2)
Memory management MM migration
lore
Share & tools
lore

Wang Sheng-Hui

author
#0 lore raw

PATCH 1/1 cleanup: mm/migrate.c: cleanup comment for function migration_entry_wait

migration_entry_wait can also be called from hugetlb_fault now. Cleanup the comment.

Signed-off-by Wang Sheng-Hui <[email protected]>
---
 mm/migrate.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
mm/migrate.c +0 -2
index 177aca4..640002a 100644
@@ -181,8 +181,6 @@ static void remove_migration_ptes(struct page *old, struct page *new)
  * Something used the pte of a page under migration. We need to
  * get to the page and wait until migration is finished.
  * When we return from this function the fault will be retried.
- *
- * This function is called from do_swap_page().
  */
 void migration_entry_wait(struct mm_struct *mm, pmd_t *pmd,
 				unsigned long address)
Signature · 8 lines
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Wang Sheng-Hui

migration_entry_wait can also be called from hugetlb_fault now. Cleanup the comment.

Signed-off-by Wang Sheng-Hui <[email protected]>

Alternative is to add hugetlbe_fault in comment but I think it's not useful because We can find caller easily with cscope or just grep.
My feeling is that the comment isn't helpful.
So I am okay to remove this comment.

Acked-by Minchan Kim <[email protected]>
Signature · 9 lines
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>