Skip to contentSkip to conversation

builtin/log: remove redundant initialization

PATCH In review Michael Schubert 2 participants 2 messages Jun 15, 2016

lore
Share & tools
lore

Michael Schubert

author
#0 lore raw

PATCH 1/1 builtin/log: remove redundant initialization

"abbrev" and "commit_format" in struct rev_info get initialized in init_revisions - no need to reinit in cmd_log_init_defaults.

Signed-off-by Michael Schubert <[email protected]>
---
 builtin/log.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
builtin/log.c +0 -2
index 89d0cc0..7d1f6f8 100644
@@ -73,8 +73,6 @@ static int decorate_callback(const struct option *opt, const char *arg, int unse
 
 static void cmd_log_init_defaults(struct rev_info *rev)
 {
-	rev->abbrev = DEFAULT_ABBREV;
-	rev->commit_format = CMIT_FMT_DEFAULT;
 	if (fmt_pretty)
 		get_commit_format(fmt_pretty, rev);
 	rev->verbose_header = 1;
Signature · 1 line
1.7.8.400.g03f4