Skip to contentSkip to conversation

Add USB ID of HP's Broadcom BCM2035 Bluetooth

PATCH Superseded Albert Pool 2 participants 2 messages Dec 21, 2011 Bluetooth drivers

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add USB ID of HP's Broadcom BCM2035 Bluetooth

HP's Broadcom Bluetooth 1.2 interface (USB 03f0:011d) found in HP Compaq nc6120 laptop, fails to detect other devices, and pair with them. With BTUSB_BCM92035 it now works.

I've also tried using BTUSB_WRONG_SCO_MTU, but with that setting it failed to enable the device 50% of the time.

If I didn't properly submit the patch, please let me know.

- - -

 drivers/bluetooth/btusb.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/bluetooth/btusb.c +2 -1
@@ -142,7 +142,8 @@ static struct usb_device_id blacklist_ta
     { USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU },
     { USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU },
 
-    /* HP laptop with Broadcom chip */
+    /* HP laptops with Broadcom chip */
+    { USB_DEVICE(0x03f0, 0x011d), .driver_info = BTUSB_BCM92035 },
     { USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU },
 
     /* Dell laptop with Broadcom chip */
maintainer
#1 lore raw

Hi Albert,

Quoted 8 lines

HP's Broadcom Bluetooth 1.2 interface (USB 03f0:011d) found in HP Compaq nc6120 laptop, fails to detect other devices, and pair with them. With BTUSB_BCM92035 it now works.

I've also tried using BTUSB_WRONG_SCO_MTU, but with that setting it failed to enable the device 50% of the time.

If I didn't properly submit the patch, please let me know.

don't include such a sentence in the commit message. It belongs after --- and before the diffstat.

Include the output of usb-devices in the commit message.

Quoted 3 lines

- - -

And please fix your email client. It is messing up whitespaces.

drivers/bluetooth/btusb.c static struct usb_device_id blacklist_ta · line 146

Quoted 11 lines
  drivers/bluetooth/btusb.c |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/bluetooth/btusb.c +2 -1
@@ -142,7 +142,8 @@ static struct usb_device_id blacklist_ta
      { USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU },
      { USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU },
 
-    /* HP laptop with Broadcom chip */
+    /* HP laptops with Broadcom chip */
+    { USB_DEVICE(0x03f0, 0x011d), .driver_info = BTUSB_BCM92035 },

You need a tab here and not space.

drivers/bluetooth/btusb.c static struct usb_device_id blacklist_ta · line 149

Quoted 4 lines
drivers/bluetooth/btusb.c +0 -0
      { USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU },
 
      /* Dell laptop with Broadcom chip */

Regards

Marcel