gspca patches and new jl2005bcd driver
PATCH 1/1 gspca patches and new jl2005bcd driver
Hi Mauro et all,
Please pull from my tree, for a few small gspca fixes (including the bulk mode fix I send earlier for 3.2) and a new gspca subdriver for jl2005bcd based cameras by Theodore Kilgore.
The following changes since commit 1a5cd29631a6b75e49e6ad8a770ab9d69cda0fa2:
[media] tda10021: Add support for DVB-C Annex C (2011-12-20 14:01:08 -0200)
are available in the git repository at:
git://linuxtv.org/hgoede/gspca.git media-for_v3.3
Hans de Goede (3):
gspca: Fix bulk mode cameras no longer working (regression fix)
gspca_pac207: Raise max exposure + various autogain setting tweaks
gscpa_vicam: Fix oops if unplugged while streaming
Theodore Kilgore (1):
gspca: add jl2005bcd sub driver
Documentation/video4linux/gspca.txt | 1 + drivers/media/video/gspca/Kconfig | 10 + drivers/media/video/gspca/Makefile | 2 + drivers/media/video/gspca/gspca.c | 4 +- drivers/media/video/gspca/gspca.h | 2 + drivers/media/video/gspca/jl2005bcd.c | 571 +++++++++++++++++++++++++++++++++ drivers/media/video/gspca/pac207.c | 10 +- drivers/media/video/gspca/vicam.c | 3 +- include/linux/videodev2.h | 1 + 9 files changed, 596 insertions(+), 8 deletions(-) create mode 100644 drivers/media/video/gspca/jl2005bcd.c
Thanks & Regards,
Hans
On Fri, 30 Dec 2011 10:29:56 +0100
Hans de Goede <[email protected]> wrote:
[snip]
Quoted 6 lines
The following changes since commit
1a5cd29631a6b75e49e6ad8a770ab9d69cda0fa2:[media] tda10021: Add support for DVB-C Annex C (2011-12-20 14:01:08 -0200)are available in the git repository at:
git://linuxtv.org/hgoede/gspca.gitmedia-for_v3.3
[snip]
Quoted 2 lines
Theodore Kilgore (1):
gspca: add jl2005bcd sub driver
[snip]
I have noticed some problems with the patch 2346c78dff71b003f:
- there should be no change in gspca.h (addition of two empty lines)
- there is no documentation about the new pixel format 'JL20'
- in jl2005bcd.c, the macro 'err' is used instead of 'pr_err' (there are also spaces at end of line, but this is less important..)
Signature · 2 lines
Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
Hi,
Quoted 14 lines · Jean-Francois Moine
On Fri, 30 Dec 2011 10:29:56 +0100
Hans de Goede<[email protected]> wrote:[snip]Quoted 6 lines
The following changes since commit
1a5cd29631a6b75e49e6ad8a770ab9d69cda0fa2:[media] tda10021: Add support for DVB-C Annex C (2011-12-20 14:01:08 -0200)are available in the git repository at:
git://linuxtv.org/hgoede/gspca.gitmedia-for_v3.3[snip]Quoted 2 lines
Theodore Kilgore (1):
gspca: add jl2005bcd sub driver[snip]
Quoted 9 lines
I have noticed some problems with the patch
2346c78dff71b003f:- there should be no change in
gspca.h(addition of two empty lines)- there is no documentation about the new pixel format 'JL20'
- in
jl2005bcd.c, the macro 'err' is used instead of 'pr_err' (there are also spaces at end of line, but this is less important..)
I took it as is from Theodore, I guess we should do a separate cleanup patch on top to preserve the history / authorship. Since I'm busy testing the new isoc bandwidth stuff today, could you perhaps do a cleanup patch for this?
Regards,
Hans
Quoted 3 lines · On Fri, 30 Dec 2011 11:56:38 +0100 Hans de Goede <[email protected]> wrote:
I took it as is from Theodore, I guess we should do a separate cleanup patch on top to preserve the history / authorship. Since I'm busy testing the new isoc bandwidth stuff today, could you perhaps do a cleanup patch for this?
Yes, but the first step is to remove this patch from the pull request, and only you may do it (it is only 3 git commands and an email - otherwise, it has no sense to add two empty lines in a patch and to remove them in an other one!).
Signature · 2 lines
Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
Hi,
Quoted 8 lines · Jean-Francois Moine
Quoted 3 lines · On Fri, 30 Dec 2011 11:56:38 +0100 Hans de Goede<[email protected]> wrote:
I took it as is from Theodore, I guess we should do a separate cleanup patch on top to preserve the history / authorship. Since I'm busy testing the new isoc bandwidth stuff today, could you perhaps do a cleanup patch for this?
Yes, but the first step is to remove this patch from the pull request, and only you may do it (it is only 3 git commands and an email - otherwise, it has no sense to add two empty lines in a patch and to remove them in an other one!).
Done.
I'll re-add it later, squashing the white-space fixes into the patch and adding a patch on top to fix:
-err versus pr_err
-PDEBUG used with D_ERR everywhere where most cases should have
a different level
-the missing pixfmt documentation
Regards,
Hans