snowball does not compile on linux-next

DISCUSSION Daniel Lezcano 3 participants 9 messages Jan 2, 2012 – Jan 4, 2012

lore

Share & tools

lore

Daniel Lezcano

author

2012-01-02 11:49 UTC #0 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

the kernel does not compile when
CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.

it fails with :

CHK include/linux/version.h
CHK include/generated/utsrelease.h
make[1]: `include/generated/mach-types.h' is up to date.

  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  CC      drivers/clocksource/clksrc-dbx500-prcmu.o

drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: type defaults to ?int? in declaration of ?DEFINE_CLOCK_DATA? drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: parameter names (without types) in function declaration drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?sched_clock?:
drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: implicit declaration of function ?cyc_to_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: (Each undeclared identifier is reported only once drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: for each function it appears in.)
drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_update_sched_clock?:
drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: implicit declaration of function ?update_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_init?:
drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: implicit declaration of function ?init_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: ?cd? undeclared (first use in this function)
make[2]: *** [drivers/clocksource/clksrc-dbx500-prcmu.o] Error 1 make[1]: *** [drivers/clocksource] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....

Is it dead code ?

Thanks

-- Daniel

- --
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPAZnPAAoJEAKBbMCpUGYASZEH/j++IpjESlRymu9JLcTOsc4e WId52JNiqAkWdkNenstPQu/Rfc7cByR9qYRGKcZH91SvzsMia3fmMRCqCzq4RYgQ gyWy4wzd881YvlBwnwqHXqeWr8DsKwTvT4fnc0lw/c6HE0paTtWaJ/Zcw0XC4Uv1 skKUht7u1rjZShqXvb9Wb97gXZlbH3JLTdxJpJLG8BV3UjgrbviObdNxyo8hx9hm hjwXatdynl5AtS9ls3K8lrbFDAi/6FULwD2aliXioda5O9mzpQDMgK6F7yUol2qc xXgdqDODzpbJGXgbPfrTVb8xgeM60j0SiHhovbWxHVj2t2jBjBzbZ1zJgk06RAM= =GUyt
-----END PGP SIGNATURE-----

Linus Walleij

2012-01-02 12:59 UTC #1 lore raw

Quoted 42 lines · Daniel Lezcano

the kernel does not compile when
CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
it fails with :
?CHK ? ? include/linux/version.h
?CHK ? ? include/generated/utsrelease.h
make[1]: `include/generated/mach-types.h' is up to date. ?CALL ? ?scripts/checksyscalls.sh
?CHK ? ? include/generated/compile.h
?CC ? ? ?drivers/clocksource/clksrc-dbx500-prcmu.o drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: type defaults to ?int? in declaration of ?DEFINE_CLOCK_DATA? drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: parameter names (without types) in function declaration drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?sched_clock?:
drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: implicit declaration of function ?cyc_to_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: (Each undeclared identifier is reported only once drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: for each function it appears in.)
drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_update_sched_clock?:
drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: implicit declaration of function ?update_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_init?:
drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: implicit declaration of function ?init_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: ?cd? undeclared (first use in this function)
make[2]: *** [drivers/clocksource/clksrc-dbx500-prcmu.o] Error 1 make[1]: *** [drivers/clocksource] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....

Quoted 1 line

Is it dead code ?

No if it was dead it shouldn't get compiled.

It' probably just some fallout from Marc's rewrite of the sched_clock() stuff, I'll see if I can cook a patch and send off to Marc.

Yours,
Linus Walleij

Daniel Lezcano

author

2012-01-02 13:55 UTC #2 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 43 lines · Linus Walleij

Quoted 40 lines · Daniel Lezcano
the kernel does not compile when
CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
it fails with :
CHK include/linux/version.h CHK include/generated/utsrelease.h make[1]:
`include/generated/mach-types.h' is up to date. CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC drivers/clocksource/clksrc-dbx500-prcmu.o drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: type defaults to ?int? in declaration of ?DEFINE_CLOCK_DATA? drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: parameter names (without types) in function declaration drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?sched_clock?: drivers/clocksource/clksrc-dbx500-prcmu.c:72:
error: implicit declaration of function ?cyc_to_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: (Each undeclared identifier is reported only once drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: for each function it appears in.) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_update_sched_clock?:
drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: implicit declaration of function ?update_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_init?:
drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: implicit declaration of function ?init_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: ?cd? undeclared (first use in this function) make[2]: *** [drivers/clocksource/clksrc-dbx500-prcmu.o] Error 1 make[1]: *** [drivers/clocksource] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 make: *** Waiting for unfinished jobs....

Quoted 7 lines

Quoted 1 line
Is it dead code ?
No if it was dead it shouldn't get compiled.
It' probably just some fallout from Marc's rewrite of the sched_clock() stuff, I'll see if I can cook a patch and send off to Marc.

Ok, thanks. I will test the patch you sent.

it seems also the commit :

commit c15def1cc30edeaa74a97205c936be82cdc86df6

Author: Linus Walleij <[email protected]>
Date:   Thu Dec 15 13:38:40 2011 +0100

ARM: ux500: remove support for early silicon revisions

The DB8500 ED (Early Drop) and V1 are only available inside of ST-Ericsson or partners, we have actively replaced and scrapped these prototypes. All Nova products on the open market (such as the Snowball board) are based on V2 and later ASIC variants. So let us focus on supporting the silicon that will be used and delete this to get a clear overview.

Signed-off-by Linus Walleij <[email protected]>

removed the U8500_PRCMU_TCDM_BASE_V1 macro definition but it is still used in drivers/mfd/db8500-prcmu.c

The compilation fails with:

drivers/mfd/db8500-prcmu.c: In function ?db8500_prcmu_early_init?:
drivers/mfd/db8500-prcmu.c:2107: error: ?U8500_PRCMU_TCDM_BASE_V1? undeclared (first use in this function) drivers/mfd/db8500-prcmu.c:2107: error: (Each undeclared identifier is reported only once
drivers/mfd/db8500-prcmu.c:2107: error: for each function it appears in.) make[2]: *** [drivers/mfd/db8500-prcmu.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make[1]: *** Waiting for unfinished jobs....

- --

<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPAbdjAAoJEAKBbMCpUGYAsBMH/34gi4X+ASaKC8CbJuXe1xHE 7Vp3SRctP+yNQdd4iI3ma9pDnOX9kLl2iuCty3aRy4rpH+hnzHkgKdmfKKRGzH32 FoffLeEIfnGYcC5T+PDO3wL0T1zim33Umo/wyl/CLrHrgV/dX7C1lqLwQ5TF6GI8 g9pQa7raPgNvRNv3gI8p/ult8dvJEplJkl+R3MXUddfCAn4wfL+y4xpliyOwMHhb uw3ReHAsibmJe1eBD0qh+MvioDuxnHxTLek2eq+eZRUCoiT1gN24L51IGZjbrUlE zgEW4O0+/Gok4vm7ZYHe1gVqvbkPtMx34mPkf4nCV6QhTihWi1Rq2J6CwqugLhE= =xA0Z
-----END PGP SIGNATURE-----

Linus Walleij

2012-01-02 14:00 UTC #3 lore raw

Quoted 15 lines · Daniel Lezcano

it seems also the commit :
commit c15def1cc30edeaa74a97205c936be82cdc86df6
Author: Linus Walleij <[email protected]>
Date: ? Thu Dec 15 13:38:40 2011 +0100
? ?ARM: ux500: remove support for early silicon revisions
? ?The DB8500 ED (Early Drop) and V1 are only available inside of ? ?ST-Ericsson or partners, we have actively replaced and scrapped ? ?these prototypes. All Nova products on the open market (such as ? ?the Snowball board) are based on V2 and later ASIC variants. ? ?So let us focus on supporting the silicon that will be used and ? ?delete this to get a clear overview.

Quoted 4 lines

? ?Signed-off-by: Linus Walleij <[email protected]>
removed the U8500_PRCMU_TCDM_BASE_V1 macro definition but it is still used in drivers/mfd/db8500-prcmu.c

Yes, I have sent the patch removing it from the PRCMU driver to the ARM SoC maintainers (you're on CC) so they can merge it into their ux500 branch, I intended to do it this way (Sam already ACK:ed it) but screwed up some way.

Yours,
Linus Walleij

Daniel Lezcano

author

2012-01-02 14:00 UTC #4 lore raw

In reply to Daniel Lezcano

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 76 lines · Daniel Lezcano

Quoted 42 lines · Linus Walleij
Quoted 39 lines · Daniel Lezcano
the kernel does not compile when
CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
it fails with :
CHK include/linux/version.h CHK include/generated/utsrelease.h make[1]: `include/generated/mach-types.h' is up to date. CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC drivers/clocksource/clksrc-dbx500-prcmu.o drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning: type defaults to ?int? in declaration of ?DEFINE_CLOCK_DATA? drivers/clocksource/clksrc-dbx500-prcmu.c:61: warning:
parameter names (without types) in function declaration drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?sched_clock?: drivers/clocksource/clksrc-dbx500-prcmu.c:72:
error: implicit declaration of function ?cyc_to_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: (Each undeclared identifier is reported only once drivers/clocksource/clksrc-dbx500-prcmu.c:72: error: for each function it appears in.) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_update_sched_clock?:
drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: implicit declaration of function ?update_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:78: error: ?cd? undeclared (first use in this function) drivers/clocksource/clksrc-dbx500-prcmu.c: In function ?clksrc_dbx500_prcmu_init?:
drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: implicit declaration of function ?init_sched_clock? drivers/clocksource/clksrc-dbx500-prcmu.c:100: error: ?cd? undeclared (first use in this function) make[2]: *** [drivers/clocksource/clksrc-dbx500-prcmu.o] Error 1 make[1]:
*** [drivers/clocksource] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 make: *** Waiting for unfinished jobs....
Quoted 7 lines
Quoted 1 line
Is it dead code ?
No if it was dead it shouldn't get compiled.
It' probably just some fallout from Marc's rewrite of the sched_clock() stuff, I'll see if I can cook a patch and send off to Marc.
Ok, thanks. I will test the patch you sent.
it seems also the commit :
commit c15def1cc30edeaa74a97205c936be82cdc86df6 Author: Linus Walleij <[email protected]> Date: Thu Dec 15 13:38:40 2011 +0100
ARM: ux500: remove support for early silicon revisions
The DB8500 ED (Early Drop) and V1 are only available inside of ST-Ericsson or partners, we have actively replaced and scrapped these prototypes. All Nova products on the open market (such as the Snowball board) are based on V2 and later ASIC variants. So let us focus on supporting the silicon that will be used and delete this to get a clear overview.
Signed-off-by Linus Walleij <[email protected]>
removed the U8500_PRCMU_TCDM_BASE_V1 macro definition but it is still used in drivers/mfd/db8500-prcmu.c
The compilation fails with:

Quoted 9 lines

drivers/mfd/db8500-prcmu.c: In function ?db8500_prcmu_early_init?:
drivers/mfd/db8500-prcmu.c:2107: error: ?U8500_PRCMU_TCDM_BASE_V1? undeclared (first use in this function) drivers/mfd/db8500-prcmu.c:2107: error: (Each undeclared identifier is reported only once drivers/mfd/db8500-prcmu.c:2107: error: for each function it appears in.) make[2]: *** [drivers/mfd/db8500-prcmu.o] Error 1 make[1]: *** [drivers/mfd] Error 2 make[1]: *** Waiting for unfinished jobs....

Please ignore, I missed your patch fixing this.
I still have to improve my message filters :)

Thanks
-- Daniel

_______________________________________________
linaro-dev mailing list
linaro-dev at lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev

- --
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPAbiEAAoJEAKBbMCpUGYAg50IAKMmgwZrbrJirvCMNa3tDOzE vwzpE1mAD9p8pL9rMwOaxAdWQBVoJmf6PXnvGemc1DaqE/1WwYtmchanWirII86R 7B6POSslVlyNpqXhRpDPDYwoQXbE1DoW+NHYCLkn2ju6FTnF/xZwO1kr77aQLrfl gSu84kG0oMfVIV2MY1nTsz9n5vv98rn0mllO37HrI6CaIqeZo3qkOye45asjnpF1 YFhfaMnL21R/lnqVa69Uv/tFEDBbacSEsU67URlOiIlY1OXYL9k9nkhyQqMOpM79 e29iHoMfkp8978UTy+inVE+HNOPXteN9O9Hy2TklyekUndCorA5b8G8NeufQVq8= =PPBU
-----END PGP SIGNATURE-----

Christian Robottom Reis

2012-01-02 15:25 UTC #5 lore raw

In reply to Linus Walleij

Quoted 5 lines · Linus Walleij

Quoted 2 lines · Daniel Lezcano
the kernel does not compile when
CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.

Should this be in our default configs, or one of our tested configs, so we can catch this in a CI loop?

Signature · 3 lines

Christian Robottom Reis, Engineering VP
Brazil (GMT-3) | [+55] 16 9112 6430 | [+1] 612 216 4935
Linaro.org: Open Source Software for ARM SoCs

Linus Walleij

2012-01-03 07:19 UTC #6 lore raw

Quoted 9 lines · Christian Robottom Reis

Quoted 5 lines · Linus Walleij
Quoted 2 lines · Daniel Lezcano
the kernel does not compile when
CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
Should this be in our default configs, or one of our tested configs, so we can catch this in a CI loop?

It should be in the defconfig already, the problem showed up for Daniel exactly because it was configured in.

Yours,
Linus Walleij

Christian Robottom Reis

2012-01-03 13:20 UTC #7 lore raw

Quoted 5 lines · Linus Walleij

Quoted 4 lines · Christian Robottom Reis
Quoted 3 lines · Linus Walleij
On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano
<[email protected]> wrote:

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
the kernel does not compile when
CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
Should this be in our default configs, or one of our tested configs, so we can catch this in a CI loop?
It should be in the defconfig already, the problem showed up for Daniel exactly because it was configured in.

Okay, then the question is what do we need to do to make a box go red and have people notified when it breaks?

Signature · 3 lines

Christian Robottom Reis, Engineering VP
Brazil (GMT-3) | [+55] 16 9112 6430 | [+1] 612 216 4935
Linaro.org: Open Source Software for ARM SoCs

Linus Walleij

2012-01-04 09:44 UTC #8 lore raw

Quoted 7 lines · Christian Robottom Reis

Quoted 2 lines · Linus Walleij
It should be in the defconfig already, the problem showed up for Daniel exactly because it was configured in.
Okay, then the question is what do we need to do to make a box go red and have people notified when it breaks?

Since this was a simple compilation issue, it's indicated already by Stephen Rothwells "kisskb" system:
http://kisskb.ellerman.id.au/kisskb/branch/9/

I actually poll the above web page for my machines, sadly not every day due to other duties...

Yours,
Linus Walleij