Skip to contentSkip to conversation

syscalls/unshare02: Replace ((int)NULL) with 0

PATCH In review Markos Chandras 3 participants 3 messages Jan 3, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 6/21 syscalls/unshare02: Replace ((int)NULL) with 0

Hi, please review the attached patch

Signature · 1 line
markos

From 269402e0cf64392442196ecf6c79d35d9e93c1af Mon Sep 17 00:00:00 2001
From: Markos Chandras <[email protected]>
Date: Thu, 22 Dec 2011 11:57:17 +0000
Subject: [PATCH 06/21] syscalls/unshare02: Replace ((int)NULL) with 0

On non-32bit arches, casting a pointer to integer throws a compiler warning because integers and pointers have different sizes in these arches. Therefore, we replace the (int)NULL cast with 0 which has the same effect.

---
 testcases/kernel/syscalls/unshare/unshare02.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
testcases/kernel/syscalls/unshare/unshare02.c +1 -1
index 9f7b436..1a93932 100644
@@ -181,7 +181,7 @@ int main(int ac, char **av) {
 				tst_brkm(TFAIL|TTERRNO, cleanup,
 					"fork() failed.");
 			} else if (TEST_RETURN == 0) {
-				TEST_RETURN = unshare((int)NULL);
+				TEST_RETURN = unshare(0);
 				if (TEST_RETURN == 0) {
 					tst_resm(TPASS, "Call succeeded");
 					rval = 0;
Signature · 1 line
1.7.1

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reviewed-by on v1 6/21
#1 lore raw
Quoted 1 line · Markos Chandras

Hi, please review the attached patch

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
In reply to Markos Chandras
Quoted 1 line · On Tuesday 03 January 2012 05:44:01 Markos Chandras wrote:

Hi, please review the attached patch

looks good
-mike

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list