Skip to contentSkip to conversation

network/lib6/asapi_06: pcmsg->cmsg_len is of type size_t

PATCH NAK Markos Chandras 3 participants 3 messages Jan 3, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 18/21 network/lib6/asapi_06: pcmsg->cmsg_len is of type size_t

Hi, please review the attached patch

Signature · 1 line
markos

From a83368f2077913705a54532b48b1bd3634cc9934 Mon Sep 17 00:00:00 2001
From: Markos Chandras <[email protected]>
Date: Thu, 22 Dec 2011 15:10:11 +0000
Subject: [PATCH 18/21] network/lib6/asapi_06: pcmsg->cmsg_len is of type size_t

---
 testcases/network/lib6/asapi_06.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
testcases/network/lib6/asapi_06.c +2 -2
index 3808c37..6f4428b 100644
@@ -413,7 +413,7 @@ so_test(struct soent *psoe)
 				break;
 			else if (psoe->so_clear) {
 				tst_resm(TFAIL, "%s receive: extraneous data "
-					"in control: level %d type %d len %d",
+					"in control: level %d type %d len %zu",
 					psoe->so_tname, pcmsg->cmsg_level,
 					pcmsg->cmsg_type, pcmsg->cmsg_len);
 				return;
@@ -643,4 +643,4 @@ cleanup(void)
 {
 	TEST_CLEANUP;
 
-}
\ No newline at end of file
+}
Signature · 1 line
1.7.1

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reviewed-by on v1 18/21
#1 lore raw
Quoted 1 line · Markos Chandras

Hi, please review the attached patch

This is ok. While the stance here has been to follow the PRI*
style format string qualifiers, this works and is pseudo standard across BSD, Linux, and probably a few other printf(3) implementations. Thanks,
-Garrett

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
Quoted 8 lines · On Tuesday 03 January 2012 14:33:05 Garrett Cooper wrote:

On Tue, Jan 3, 2012 at 5:23 AM, Markos Chandras

Quoted 1 line · <[email protected]> wrote:

Hi, please review the attached patch

This is ok. While the stance here has been to follow the PRI*
style format string qualifiers, this works and is pseudo standard across BSD, Linux, and probably a few other printf(3) implementations.

the PRI* stuff is for explicitly sized types (e.g. 8bit/16bit/32bit/64bit). it is not for [s]size_t types ... that's what the "z" length field of printf is designed for.
-mike

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list