mmc: dw_mmc: fixed wrong bit operation for SDMMC_GET_FCNT()
Subsystems (2)
Jaehoon Chung
maintainerPATCH 1/1 mmc: dw_mmc: fixed wrong bit operation for SDMMC_GET_FCNT()
In status register, fifo_count is bit[29:17].
(0x1FFF is correctly)
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
--- drivers/mmc/host/dw_mmc.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/dw_mmc.h +1 -1
@@ -126,7 +126,7 @@#define SDMMC_CMD_RESP_EXP BIT(6)#define SDMMC_CMD_INDX (n) ((n) & 0x1F)/* Status register defines */ -#define SDMMC_GET_FCNT (x) (((x)>>17) & 0x1FF) +#define SDMMC_GET_FCNT (x) (((x)>>17) & 0x1FFF)/* Internal DMAC interrupt defines */ #define SDMMC_IDMAC_INT_AI BIT(9)#define SDMMC_IDMAC_INT_NI BIT(8)
Quoted 8 lines · Jaehoon Chung
In status register,
fifo_countis bit[29:17].
(0x1FFFis correctly)Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>---
drivers/mmc/host/dw_mmc.h | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)
Good catch, thanks!
Acked-by Will Newton <[email protected]>
Chris Ball
AppliedHi,
Quoted 10 lines · Will Newton
Quoted 8 lines · Jaehoon Chung
In status register,
fifo_countis bit[29:17].
(0x1FFFis correctly)Signed-off-by Jaehoon Chung <[email protected]>Signed-off-by Kyungmin Park <[email protected]>---
drivers/mmc/host/dw_mmc.h | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 3 lines
Good catch, thanks!
Acked-by Will Newton <[email protected]>
Pushed to mmc-next for 3.3, thanks.
- Chris.
Signature · 2 lines
Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child