makedumpfile can't build on Fedora 16

Hello, Atsushi,

I can't build the latest makedumpfile on Fedora 16,

[wangcong@cr0]~/makedumpfile% make
...
gcc -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DVERSION='"1.4.1"' -DRELEASE_DATE='"6 January 2012"' -D__x86_64__ print_info.o dwarf_info.o elf_info.o erase_info.o sadump_info.o arch/arm.o arch/x86.o arch/x86_64.o arch/ia64.o arch/ppc64.o arch/s390x.o -o makedumpfile makedumpfile.c -static -ldw -lbz2 -lebl -ldl -lelf -lz

makedumpfile.c: In function ‘__exclude_unnecessary_pages’:
makedumpfile.c:3625:15: warning: variable ‘_count’ set but not used [-Wunused-but-set-variable]
/usr/bin/ld: cannot find -lbz2
/usr/bin/ld: cannot find -ldl
/usr/bin/ld: cannot find -lc
collect2: ld returned 1 exit status
make: *** [makedumpfile] Error 1

[wangcong@cr0]~/makedumpfile% rpm -ql bzip2-libs
/lib64/libbz2.so.1
/lib64/libbz2.so.1.0.6
/usr/share/doc/bzip2-libs-1.0.6
/usr/share/doc/bzip2-libs-1.0.6/LICENSE

So, I don't know why ld can't find libbz2 and libc... Any hints?

Thanks!

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

At 01/18/2012 12:36 AM, Cong Wang Wrote:

Quoted 4 lines

Hello, Atsushi,

I can't build the latest makedumpfile on Fedora 16,

Quoted 8 lines

[wangcong@cr0]~/makedumpfile% make
...
gcc -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DVERSION='"1.4.1"' -DRELEASE_DATE='"6 January 2012"' -D__x86_64__ print_info.o dwarf_info.o elf_info.o erase_info.o sadump_info.o arch/arm.o arch/x86.o arch/x86_64.o arch/ia64.o arch/ppc64.o arch/s390x.o -o makedumpfile makedumpfile.c -static -ldw -lbz2 -lebl -ldl -lelf -lz

The parameter has -static, so you need libc.a, libdw.a and ... Or you can remove -static, but you should ensure that there are these dynamic librarys in the second os.

Quoted 15 lines

makedumpfile.c: In function ‘__exclude_unnecessary_pages’:
makedumpfile.c:3625:15: warning: variable ‘_count’ set but not used [-Wunused-but-set-variable]
/usr/bin/ld: cannot find -lbz2
/usr/bin/ld: cannot find -ldl
/usr/bin/ld: cannot find -lc
collect2: ld returned 1 exit status
make: *** [makedumpfile] Error 1

[wangcong@cr0]~/makedumpfile% rpm -ql bzip2-libs
/lib64/libbz2.so.1
/lib64/libbz2.so.1.0.6
/usr/share/doc/bzip2-libs-1.0.6
/usr/share/doc/bzip2-libs-1.0.6/LICENSE

Quoted 9 lines

So, I don't know why ld can't find libbz2 and libc... Any hints?

Thanks!

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Hi,

Quoted 5 lines · On Wed, 18 Jan 2012 08:35:24 +0800 Wen Congyang<[email protected]> wrote:

At 01/18/2012 12:36 AM, Cong Wang Wrote:

Quoted 4 lines

Hello, Atsushi,

I can't build the latest makedumpfile on Fedora 16,

Quoted 12 lines

Quoted 8 lines

[wangcong@cr0]~/makedumpfile% make
...
gcc -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DVERSION='"1.4.1"' -DRELEASE_DATE='"6 January 2012"' -D__x86_64__ print_info.o dwarf_info.o elf_info.o erase_info.o sadump_info.o arch/arm.o arch/x86.o arch/x86_64.o arch/ia64.o arch/ppc64.o arch/s390x.o -o makedumpfile makedumpfile.c -static -ldw -lbz2 -lebl -ldl -lelf -lz

The parameter has -static, so you need libc.a, libdw.a and ... Or you can remove -static, but you should ensure that there are these dynamic librarys in the second os.

That's right.
It has been written in README file of makedumpfile:

&/dev/null; then \

Quoted 12 lines

Quoted 11 lines

Quoted 7 lines

...
gcc -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DVERSION='"1.4.1"' -DRELEASE_DATE='"6 January 2012"' -D__x86_64__ print_info.o dwarf_info.o elf_info.o erase_info.o sadump_info.o arch/arm.o arch/x86.o arch/x86_64.o arch/ia64.o arch/ppc64.o arch/s390x.o -o makedumpfile makedumpfile.c -static -ldw -lbz2 -lebl -ldl -lelf -lz

The parameter has -static, so you need libc.a, libdw.a and ... Or you can remove -static, but you should ensure that there are these dynamic librarys in the second os.

Quoted 2 lines

That's right.
It has been written in README file of makedumpfile:

Hey,

This means we have to patch the source code by ourselves, why not improve it? Something like below?

Makefile +0 -0

index 9afbe1c..1361700 100644
@@ -28,6 +28,11 @@ SRC_PART = print_info.c dwarf_info.c elf_info.c

erase_info.c sadump_info.c
OBJ_PART = print_info.o dwarf_info.o elf_info.o erase_info.o sadump_info.o SRC_ARCH = arch/arm.c arch/x86.c arch/x86_64.c arch/ia64.c arch/ppc64.c
arch/s390x.c
OBJ_ARCH = arch/arm.o arch/x86.o arch/x86_64.o arch/ia64.o arch/ppc64.o
arch/s390x.o
+LIBS := $(shell if $(CC) -static -ldw -lbz2 -lebl -ldl -lelf -lz

Quoted 1 line

&/dev/null; then \

Makefile +5 -2

+       echo "-static -ldw -lbz2 -lebl -ldl -lelf -lz"; \
+       else \
+       echo "-ldw -lbz2 -lebl -ldl -lelf -lz"; \
+       fi)
 
 all: makedumpfile

@@ -38,7 +43,7 @@ $(OBJ_ARCH): $(SRC_ARCH)
        $(CC) $(CFLAGS_ARCH) -c -o ./$@ ./$(@:.o=.c)
 
 makedumpfile: $(SRC) $(OBJ_PART) $(OBJ_ARCH)
-       $(CC) $(CFLAGS) $(LDFLAGS) $(OBJ_PART) $(OBJ_ARCH) -o $@ $<
-static -ldw -lbz2 -lebl -ldl -lelf -lz
+       $(CC) $(CFLAGS) $(LDFLAGS) $(OBJ_PART) $(OBJ_ARCH) -o $@ $< $(LIBS)
        echo .TH MAKEDUMPFILE 8 \"$(DATE)\" \"makedumpfile v$(VERSION)\"

\"Linux System Administrator\'s Manual\" > temp.8
grep -v "^.TH MAKEDUMPFILE 8" makedumpfile.8 >> temp.8 mv temp.8 makedumpfile.8

Hi,

Quoted 12 lines · On Wed, 18 Jan 2012 21:45:09 +0800 Cong Wang <[email protected]> wrote:

Quoted 12 lines

Quoted 11 lines

Quoted 7 lines

...
gcc -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DVERSION='"1.4.1"' -DRELEASE_DATE='"6 January 2012"' -D__x86_64__ print_info.o dwarf_info.o elf_info.o erase_info.o sadump_info.o arch/arm.o arch/x86.o arch/x86_64.o arch/ia64.o arch/ppc64.o arch/s390x.o -o makedumpfile makedumpfile.c -static -ldw -lbz2 -lebl -ldl -lelf -lz

The parameter has -static, so you need libc.a, libdw.a and ... Or you can remove -static, but you should ensure that there are these dynamic librarys in the second os.

Quoted 7 lines

Quoted 2 lines

That's right.
It has been written in README file of makedumpfile:

Hey,

This means we have to patch the source code by ourselves, why not improve it? Something like below?

I guess someone will send "makedumpfile can't run on ..." even if your patch is merged, because these dynamic libraries should be included in the second os and it is easy to forget that. The compiling error is an easy way to notice it, I feel. What do you think, Kumagai-san ?

Thanks
Ken'ichi Ohmichi

Hi,

I think that makedumpfile should be compiled with -static option, because it must be executable in many environment as possible, e.g. even if there are no dynamic libraries in 2nd kernel environment. (as written in README)

But I've got some requests to build it using dynamic libraries, so I will change the Makefile as attached patch.

If you want to build makedumpfile using dynamic libraries, you need "LINKTYPE=dynamic"(see below).

How to build:

   a) linking static libraries (default)
     $ make
     ...
     $ ldd makedumpfile
         not a dynamic executable

   b) linking dynamic libraries
     $ make LINKTYPE=dynamic
     ...
     $ ldd makedumpfile
         libdw.so.1 =>  /usr/lib64/libdw.so.1 (0x0000003ca2800000)
         libbz2.so.1 =>  /usr/lib64/libbz2.so.1 (0x000000394b200000)
         libdl.so.2 =>  /lib64/libdl.so.2 (0x00000031a5a00000)
         libelf.so.1 =>  /usr/lib64/libelf.so.1 (0x0000003ca2400000)
         libz.so.1 =>  /usr/lib64/libz.so.1 (0x00000031a6200000)
         libc.so.6 =>  /lib64/libc.so.6 (0x00000031a5200000)
         /lib64/ld-linux-x86-64.so.2 (0x00000031a4e00000)

What do you think, Cong?

Quoted 1 line · Atsushi Kumagai

Hi,

Hi, Kumagai-san,

Quoted 29 lines

I think that makedumpfile should be compiled with -static option, because it must be executable in many environment as possible, e.g. even if there are no dynamic libraries in 2nd kernel environment. (as written in README)

But I've got some requests to build it using dynamic libraries, so I will change the Makefile as attached patch.

If you want to build makedumpfile using dynamic libraries, you need "LINKTYPE=dynamic"(see below).

How to build:

   a) linking static libraries (default)
     $ make
     ...
     $ ldd makedumpfile
         not a dynamic executable

   b) linking dynamic libraries
     $ make LINKTYPE=dynamic
     ...
     $ ldd makedumpfile
         libdw.so.1 =>  /usr/lib64/libdw.so.1 (0x0000003ca2800000)
         libbz2.so.1 =>  /usr/lib64/libbz2.so.1 (0x000000394b200000)
         libdl.so.2 =>  /lib64/libdl.so.2 (0x00000031a5a00000)
         libelf.so.1 =>  /usr/lib64/libelf.so.1 (0x0000003ca2400000)
         libz.so.1 =>  /usr/lib64/libz.so.1 (0x00000031a6200000)
         libc.so.6 =>  /lib64/libc.so.6 (0x00000031a5200000)
         /lib64/ld-linux-x86-64.so.2 (0x00000031a4e00000)

Quoted 1 line

What do you think, Cong?

This also works for me! Thanks for your patch!

BTW, we also need to update README. ;)

Quoted 30 lines

Quoted 12 lines · On Wed, 18 Jan 2012 21:45:09 +0800 Cong Wang <[email protected]> wrote:

Quoted 12 lines

Quoted 11 lines

Quoted 7 lines

...
gcc -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DVERSION='"1.4.1"' -DRELEASE_DATE='"6 January 2012"' -D__x86_64__ print_info.o dwarf_info.o elf_info.o erase_info.o sadump_info.o arch/arm.o arch/x86.o arch/x86_64.o arch/ia64.o arch/ppc64.o arch/s390x.o -o makedumpfile makedumpfile.c -static -ldw -lbz2 -lebl -ldl -lelf -lz

The parameter has -static, so you need libc.a, libdw.a and ... Or you can remove -static, but you should ensure that there are these dynamic librarys in the second os.

Quoted 7 lines

Quoted 2 lines

That's right.
It has been written in README file of makedumpfile:

Hey,

This means we have to patch the source code by ourselves, why not improve it? Something like below?

I guess someone will send "makedumpfile can't run on ..." even if your patch is merged, because these dynamic libraries should be included in the second os and it is easy to forget that. The compiling error is an easy way to notice it, I feel. What do you think, Kumagai-san ?

Quoted 2 lines

Thanks
Ken'ichi Ohmichi

Thank you for your explanation, Ohmichi-san, I agree with you.

I think that makedumpfile should be compiled with -static option, because it must be executable in many environment as possible, e.g. even if there are no dynamic libraries in 2nd kernel environment. (as written in README)

But I've got some requests to build it using dynamic libraries, so I will change the Makefile as attached patch.

If you want to build makedumpfile using dynamic libraries, you need "LINKTYPE=dynamic"(see below).

How to build:
a) linking static libraries (default)

    $ make
    ...
    $ ldd makedumpfile
        not a dynamic executable

b) linking dynamic libraries

    $ make LINKTYPE=dynamic
    ...
    $ ldd makedumpfile
        libdw.so.1 => /usr/lib64/libdw.so.1 (0x0000003ca2800000)
        libbz2.so.1 => /usr/lib64/libbz2.so.1 (0x000000394b200000)
        libdl.so.2 => /lib64/libdl.so.2 (0x00000031a5a00000)
        libelf.so.1 => /usr/lib64/libelf.so.1 (0x0000003ca2400000)
        libz.so.1 => /usr/lib64/libz.so.1 (0x00000031a6200000)
        libc.so.6 => /lib64/libc.so.6 (0x00000031a5200000)
        /lib64/ld-linux-x86-64.so.2 (0x00000031a4e00000)

What do you think, Cong?

Thanks
Atsushi Kumagai

Makefile +6 -0

index 9afbe1c..b14f09c 100644
@@ -29,6 +29,12 @@ OBJ_PART = print_info.o dwarf_info.o elf_info.o erase_info.o sadump_info.o
 SRC_ARCH = arch/arm.c arch/x86.c arch/x86_64.c arch/ia64.c arch/ppc64.c arch/s390x.c
 OBJ_ARCH = arch/arm.o arch/x86.o arch/x86_64.o arch/ia64.o arch/ppc64.o arch/s390x.o
 
+ifeq ($(LINKTYPE), dynamic)
+LIBS = -ldw -lbz2 -lebl -ldl -lelf -lz
+else
+LIBS = -static -ldw -lbz2 -lebl -ldl -lelf -lz
+endif
+
 all: makedumpfile
 
 $(OBJ_PART): $(SRC_PART)