splitting cgroup.c
While working on cgroup xattr, it appeared to me it's better to create a cgroup_xattr.c instead of stuffing things into cgroup.c.
Then I took a look at how big it is.
$ ls -l -S kernel/*.c
-rw-rw-r-- 1 lizf lizf 142717 Jan 18 10:15 cgroup.c
-rw-rw-r-- 1 lizf lizf 106498 Jan 18 10:15 workqueue.c
-rw-rw-r-- 1 lizf lizf 105206 Jan 18 10:15 lockdep.c
-rw-rw-r-- 1 lizf lizf 91321 Jan 18 10:16 module.c $ wc -l kernel/*.c | sort -n -r
90397 total
5289 cgroup.c
4206 lockdep.c
3840 workqueue.c
3507 module.cSo I think for the sake of readability and maintainability, we'd better split cgroup.c into smaller pieces:
- event_control.c
- css_id.c
- debug.c
- proc.c
- super.c
...
- cgroup.c
We may add xattr.c and release_agency.c as I'm working on them.
Any objection?
Tejun Heo
maintainerHello,
Quoted 11 lines · Li Zefan
While working on cgroup xattr, it appeared to me it's better to create a
cgroup_xattr.cinstead of stuffing things intocgroup.c.Then I took a look at how big it is.
$ ls -l -S kernel/*.c -rw-rw-r-- 1 lizf lizf 142717 Jan 18 10:15 cgroup.c -rw-rw-r-- 1 lizf lizf 106498 Jan 18 10:15 workqueue.c -rw-rw-r-- 1 lizf lizf 105206 Jan 18 10:15 lockdep.c -rw-rw-r-- 1 lizf lizf 91321 Jan 18 10:16 module.c
Quoted 6 lines
$ wc -l kernel/*.c | sort -n -r
90397 total
5289 cgroup.c
4206 lockdep.c
3840 workqueue.c
3507 module.cYeah, cgroup.c one giant file.
Quoted 2 lines
So I think for the sake of readability and maintainability, we'd better split
cgroup.cinto smaller pieces:
I agree that splitting is necessary but IMHO splitting usually tends to go too far. Maybe we can split it into two and think about further splitting later on? e.g. internal logic vs. userland interfacing.
Thanks.
Signature · 1 line
tejun
Quoted 7 lines
Quoted 2 lines
So I think for the sake of readability and maintainability, we'd better split
cgroup.cinto smaller pieces:I agree that splitting is necessary but IMHO splitting usually tends to go too far. Maybe we can split it into two and think about further splitting later on? e.g. internal logic vs. userland interfacing.
This isn't feasible. The feasible way is to split by functionality, which I think was the way taken by perf developers.
Tejun Heo
maintainerHello, Li.
Quoted 6 lines · Li Zefan
Quoted 3 lines
I agree that splitting is necessary but IMHO splitting usually tends to go too far. Maybe we can split it into two and think about further splitting later on? e.g. internal logic vs. userland interfacing.
This isn't feasible. The feasible way is to split by functionality, which I think was the way taken by perf developers.
Eh? Feasible or desirable? How can it be not feasible? Why?
Thanks.
Signature · 1 line
tejun