coccicheck in 3.3rc1
Quoted 4 lines · Brice Goglin
I see that reverting
d0bc1fb4makes "make coccicheck M=..." ignore "M=..." so now I understand the aim of this commit now. I can certainly switch away from "make C=2 CHECK=scripts/coccicheck M=..." to "make coccicheck M=...". But I'd like away to get the very basic output back:
Hi Brice,
Sorry for the trouble. Can you try the patch I've created and see if it works properly when you use "make C=2 CHECK=scripts/coccicheck M=..." ? The patch puts the handling back the way it was for the C=1 and C=2 use case.
Also, I've added the LKML Mailing List to the cc so that this patch is posted publicly.
Greg Dietsche (1):
coccicheck: change handling of C={1,2} when M= is set
scripts/coccicheck | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-)
Signature · 1 line
1.7.6.4
PATCH 1/1 coccicheck: change handling of C={1,2} when M= is set
This patch reverts a portion of d0bc1fb4 so that coccicheck will work properly when C=1 or C=2.
--- scripts/coccicheck | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-)
scripts/coccicheck +4 -9
@@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then # FLAGS="-ignore_unknown_options -very_quiet" # OPTIONS=$* - if [ "$KBUILD_EXTMOD" = "" ] ; then - # Workaround for Coccinelle < 0.2.3 - FLAGS="-I $srctree/include -very_quiet" - shift $(( $# - 1 )) - OPTIONS=$1 - else - echo M= is not currently supported when C=1 or C=2 - exit 1 - fi +# Workaround for Coccinelle < 0.2.3 + FLAGS="-I $srctree/include -very_quiet" + shift $(( $# - 1 )) + OPTIONS=$1 else ONLINE=0 FLAGS="-very_quiet"
Signature · 1 line
1.7.6.4
Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set
Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back.
Quoted 33 lines · Greg Dietsche
This patch reverts a portion of
d0bc1fb4so that coccicheck will work properly when C=1 or C=2.Reported-by Brice Goglin <[email protected]>Signed-off-by Greg Dietsche <[email protected]>--- scripts/coccicheck | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-)scripts/coccicheck +4
-9@@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then # FLAGS="-ignore_unknown_options -very_quiet" # OPTIONS=$* - if [ "$KBUILD_EXTMOD" = "" ] ; then - # Workaround for Coccinelle < 0.2.3 - FLAGS="-I $srctree/include -very_quiet" - shift $(( $# - 1 )) - OPTIONS=$1 - else - echo M= is not currently supported when C=1 or C=2 - exit 1 - fi +# Workaround for Coccinelle < 0.2.3 + FLAGS="-I $srctree/include -very_quiet" + shift $(( $# - 1 )) + OPTIONS=$1 else ONLINE=0 FLAGS="-very_quiet"
Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set
Quoted 12 lines · Brice Goglin
Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back.
Tested-by Brice Goglin <[email protected]>Quoted 5 lines · Greg Dietsche
This patch reverts a portion of
d0bc1fb4so that coccicheck will work properly when C=1 or C=2.Reported-by Brice Goglin <[email protected]>Signed-off-by Greg Dietsche <[email protected]>
Quoted 30 lines
Quoted 28 lines
--- scripts/coccicheck | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-)scripts/coccicheck +4
-9@@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then # FLAGS="-ignore_unknown_options -very_quiet" # OPTIONS=$* - if [ "$KBUILD_EXTMOD" = "" ] ; then - # Workaround for Coccinelle < 0.2.3 - FLAGS="-I $srctree/include -very_quiet" - shift $(( $# - 1 )) - OPTIONS=$1 - else - echo M= is not currently supported when C=1 or C=2 - exit 1 - fi +# Workaround for Coccinelle < 0.2.3 + FLAGS="-I $srctree/include -very_quiet" + shift $(( $# - 1 )) + OPTIONS=$1 else ONLINE=0 FLAGS="-very_quiet"
Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set
In reply to Brice GoglinUnless I missed something, this fix still has not been applied in 3.3-rc. Brice
Quoted 40 lines · Brice Goglin
Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back.
Tested-by Brice Goglin <[email protected]>Quoted 33 lines · Greg Dietsche
This patch reverts a portion of
d0bc1fb4so that coccicheck will work properly when C=1 or C=2.Reported-by Brice Goglin <[email protected]>Signed-off-by Greg Dietsche <[email protected]>--- scripts/coccicheck | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-)scripts/coccicheck +4
-9@@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then # FLAGS="-ignore_unknown_options -very_quiet" # OPTIONS=$* - if [ "$KBUILD_EXTMOD" = "" ] ; then - # Workaround for Coccinelle < 0.2.3 - FLAGS="-I $srctree/include -very_quiet" - shift $(( $# - 1 )) - OPTIONS=$1 - else - echo M= is not currently supported when C=1 or C=2 - exit 1 - fi +# Workaround for Coccinelle < 0.2.3 + FLAGS="-I $srctree/include -very_quiet" + shift $(( $# - 1 )) + OPTIONS=$1 else ONLINE=0 FLAGS="-very_quiet"
Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set
Quoted 9 lines · Brice Goglin
Unless I missed something, this fix still has not been applied in 3.3-rc. Brice
Quoted 3 lines · Brice Goglin
Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back.
Tested-by Brice Goglin <[email protected]>
I applied it to kbuild.git#rc-fixes now.
Michal