Skip to contentSkip to conversation

e1000: Fix PCI memory addressing and fix for receive data polling

RFC PATCH New Ralf Rösch 1 participant 1 message Jan 26, 2012

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 e1000: Fix PCI memory addressing and fix for receive data polling

Hi all,

I had some problem when using your e1000-code on a MIPS target. Attached you will find two fixes which I would like to propose for discussion.

- Fix 1: this has the same reason as in commit
f81ecb5d3300bf92d17302d3712f30585c182da9

- Fix 2: has to do with "C Language Operator Precedence".
I would say the expression taken by the ! operator has precedence before the & operator.
So any bit in rd->status other than E1000_RXD_STAT_DD stops correct detection of data reception.
(What i do not know is, if it is possible that any other bit than E1000_RXD_STAT_DD can get active)

Please leave me in CC, because i'm not subscribed to this list.

Thanks a lot for providing u-boot.

Best regards
Ralf

Signature · 10 lines
Roesch & Walter___________________________________________
Industrie-Elektronik GmbH * Tel.: +49-7824 / 6628-0
W?rtelweg 2b/c            * Fax:  +49-7824 / 6628-29
D-77963 Schwanau          * mailto:ralf.roesch at rw-gmbh.de
Germany                   * WWW: http://www.rw-gmbh.de
Amtsgericht Freiburg i.Br. HRB 391345
Gesch?ftsf?hrer: Dipl.Ing.(FH) Ralf R?sch, Dipl.Ing.(FH) Martin Walter

GnuPG key: 52ECD70F 2010-09-04 [expires: 2012-12-31]
Fingerprint: 8415 9113 5F05 D579 6685  D5AD 5CE7 5429 52EC D70F