Skip to contentSkip to conversation

8250 regression: infinite interrupts

DISCUSSION Jiri Slaby 2 participants 2 messages Jan 27, 2012 – Jan 28, 2012 TTY layer and serial drivers

lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

Hi,

the commit below causes infinite interrupts to be generated on some chips. Namely on IBM x3850 M2.

commit 235dae5d094c415fcf0fc79fa637f1901bc8afe2

Author: Philippe Langlais <[email protected]>
Date:   Thu Jul 29 17:13:57 2010 +0200
    U6715 16550A serial driver support

The culprit is the added size_fifo call proper in autoconfig_16550a. It returns 16, but the chip is confused by what the function does at that point. It is yet to be investigated why. Any ideas at this stage why this could be a problem?

thanks,

Signature · 2 lines
js
suse labs
#1 lore raw

2012/1/27 Jiri Slaby <[email protected]>:

Quoted 4 lines

The culprit is the added size_fifo call proper in autoconfig_16550a. It returns 16, but the chip is confused by what the function does at that point. It is yet to be investigated why. Any ideas at this stage why this could be a problem?

The header says the function sometimes fail :-/

What it does is set the UART in loopback mode and saturate it with 256 bytes to overflow the FIFO, then check how many chars were in the FIFO to determine FIFO size.

Could it be that your variant does not clear the FIFO overflow correctly and get stuck in some error state? Maybe try clearing some error flags at the end of this function?

Yours,
Linus Walleij