xfstests: fsstress - make sync a write op
PATCH 1/1 xfstests: fsstress - make sync a write op
I was running 068 to test freeze changes, and realized that "sync" is not in the op list when "-w" (write ops) is specified, although fsync & fdatasync are. It seems to me that sync should be a default write op as well.
Signed-off-by Eric Sandeen <[email protected]>
---
ltp/fsstress.c +2 -1
@@ -178,6 +178,7 @@ void unresvsp_f(int, long);void write_f (int ,long );opdesc_t ops[] = { +/* { OP_ENUM, "name", function, freq, iswrite }, */ {OP_ALLOCSP ,"allocsp" , allocsp_f,1 ,1 }, {OP_ATTR_REMOVE ,"attr_remove" , attr_remove_f,/* 1 */ 0 ,1 }, {OP_ATTR_SET ,"attr_set" , attr_set_f,/* 2 */ 0 ,1 },
@@ -207,7 +208,7 @@ opdesc_t ops[] = { { OP_SETXATTR, "setxattr", setxattr_f, 1, 1 }, { OP_STAT, "stat", stat_f, 1, 0 }, { OP_SYMLINK, "symlink", symlink_f, 2, 1 }, - { OP_SYNC, "sync", sync_f, 1, 0 }, + { OP_SYNC, "sync", sync_f, 1, 1 }, { OP_TRUNCATE, "truncate", truncate_f, 2, 1 }, { OP_UNLINK, "unlink", unlink_f, 1, 1 }, { OP_UNRESVSP, "unresvsp", unresvsp_f, 1, 1 },
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 6 lines · Eric Sandeen
I was running 068 to test freeze changes, and realized that "sync" is not in the op list when "-w" (write ops) is specified, although fsync & fdatasync are. It seems to me that sync should be a default write op as well.
Signed-off-by Eric Sandeen <[email protected]>
Definitely seems to be an oversight.
Reviewed-by Dave Chinner <[email protected]>
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs