Query: When will drv->poweroff() called

DISCUSSION Viresh Kumar 3 participants 4 messages Feb 6, 2012 – Feb 16, 2012

lore

Share & tools

lore

Viresh Kumar

author

2012-02-06 05:55 UTC #0 lore raw

Hi Guys,

Sorry for asking this silly question, but i couldn't locate much help for it in documentation, so asking it.

We were testing hibernation for SPEAr13xx SoC family, based on ARM Cortex a9.

I observed that poweroff() callback of individual drivers are not getting called at all, while we test hibernate.

I tried to go through the code to see what happened. It looked like there should be call to hibernation_set_ops() for platforms that are willing to get a call to poweroff() for their drivers. Otherwise shutdown of the busses gets called, which is a completely different path.

There are many drivers today, that are registering poweroff() from dev_pm_ops but are not doing bus specific shutdown stuff.

Even i tried to look for hibernation_set_ops() in kernel, and only acpi code is calling it. I didn't understood how other ARM Sub-Arch's are handling this.

Thanks in advance :)

Signature · 1 line

viresh

Rafael J. Wysocki

2012-02-06 12:03 UTC #1 lore raw

Hi,

Quoted 11 lines · Viresh Kumar

Hi Guys,
Sorry for asking this silly question, but i couldn't locate much help for it in documentation, so asking it.
We were testing hibernation for SPEAr13xx SoC family, based on ARM Cortex a9.
I observed that poweroff() callback of individual drivers are not getting called at all, while we test hibernate.

They should be called in the last phase of hibernation, after the image has been created and the system is going for "power off" (hance the callback name).

Quoted 3 lines

I tried to go through the code to see what happened. It looked like there should be call to hibernation_set_ops() for platforms that are willing to get a call to poweroff() for their drivers.

That's correct. The ->poweroff() callbacks are only executed if hibernation_mode is equal to HIBERNATION_PLATFORM, which is not the default.

Quoted 8 lines

Otherwise shutdown of the busses gets called, which is a completely different path.
There are many drivers today, that are registering poweroff() from dev_pm_ops but are not doing bus specific shutdown stuff.
Even i tried to look for hibernation_set_ops() in kernel, and only acpi code is calling it.

That's correct too.

Quoted 1 line

I didn't understood how other ARM Sub-Arch's are handling this.

Well, they are supposed to call hibernation_set_ops() and set the operations appropriately. Those operations may be empty routines if they don't need to do anything, but they have to be defined.

Thanks,
Rafael

Viresh Kumar

author

2012-02-07 04:19 UTC #2 lore raw

Thanks Rafael.

Quoted 29 lines · Rafael J. Wysocki

Quoted 11 lines · Viresh Kumar
Quoted 11 lines
Hi Guys,
Sorry for asking this silly question, but i couldn't locate much help for it in documentation, so asking it.
We were testing hibernation for SPEAr13xx SoC family, based on ARM Cortex a9.
I observed that poweroff() callback of individual drivers are not getting called at all, while we test hibernate.
They should be called in the last phase of hibernation, after the image has been created and the system is going for "power off" (hance the callback name).
Quoted 3 lines
Quoted 3 lines
I tried to go through the code to see what happened. It looked like there should be call to hibernation_set_ops() for platforms that are willing to get a call to poweroff() for their drivers.
That's correct. The ->poweroff() callbacks are only executed if hibernation_mode is equal to HIBERNATION_PLATFORM, which is not the default.
Quoted 6 lines
Quoted 6 lines
Otherwise shutdown of the busses gets called, which is a completely different path.
There are many drivers today, that are registering poweroff() from dev_pm_ops but are not doing bus specific shutdown stuff.

Quoted 8 lines

Quoted 2 lines
Quoted 2 lines
Even i tried to look for hibernation_set_ops() in kernel, and only acpi code is calling it.
That's correct too.
Quoted 1 line
Quoted 1 line
I didn't understood how other ARM Sub-Arch's are handling this.
Well, they are supposed to call hibernation_set_ops() and set the operations appropriately. Those operations may be empty routines if they don't need to do anything, but they have to be defined.

Hi Amit,

Can you give some input on why none of the ARM platforms are calling this routine currently.

Signature · 1 line

viresh

viresh kumar

2012-02-16 15:16 UTC #3 lore raw

[Sorry for mailing again, earlier mail bounced on linux-pm list, as i wasn't subscribed to it]

Hi Amit,

Can you please clear my doubt regarding calling of hibernation_set_ops() for ARM SoC's?

--
viresh

Quoted 43 lines · Viresh Kumar

Quoted 29 lines · Rafael J. Wysocki
Quoted 11 lines · Viresh Kumar
Quoted 11 lines
Hi Guys,
Sorry for asking this silly question, but i couldn't locate much help for it in documentation, so asking it.
We were testing hibernation for SPEAr13xx SoC family, based on ARM Cortex a9.
I observed that poweroff() callback of individual drivers are not getting called at all, while we test hibernate.
They should be called in the last phase of hibernation, after the image has been created and the system is going for "power off" (hance the callback name).
Quoted 3 lines
Quoted 3 lines
I tried to go through the code to see what happened. It looked like there should be call to hibernation_set_ops() for platforms that are willing to get a call to poweroff() for their drivers.
That's correct. ?The ->poweroff() callbacks are only executed if hibernation_mode is equal to HIBERNATION_PLATFORM, which is not the default.
Quoted 6 lines
Quoted 6 lines
Otherwise shutdown of the busses gets called, which is a completely different path.
There are many drivers today, that are registering poweroff() from dev_pm_ops but are not doing bus specific shutdown stuff.
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Even i tried to look for hibernation_set_ops() in kernel, and only acpi code is calling it.
That's correct too.
Quoted 1 line
Quoted 1 line
I didn't understood how other ARM Sub-Arch's are handling this.
Well, they are supposed to call hibernation_set_ops() and set the operations appropriately. ?Those operations may be empty routines if they don't need to do anything, but they have to be defined.
Hi Amit,
Can you give some input on why none of the ARM platforms are calling this routine currently.