mmc: core: add the debug message for SET_BLOCK_COUNT

PATCH In review Jaehoon Chung 3 participants 5 messages Feb 7, 2012 – Feb 11, 2012 MMC, SD and SDIO

Share & tools

Jaehoon Chung

author

2012-02-07 05:13 UTC #0 lore raw

PATCH 1/1 mmc: core: add the debug message for SET_BLOCK_COUNT

This patch is added just debug message.
Almost features need to use the CMD23.
But we didn't see the debug message for sbc. If sbc's message can see, should be help for debugging. (We can check whether use the cmd23 or not)

Signed-off-by Jaehoon Chung <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 drivers/mmc/core/core.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

drivers/mmc/core/core.c +6 -0

index 8a19143..6b72eb8 100644
@@ -188,6 +188,12 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
 	struct scatterlist *sg;
 #endif
 
+	if (mrq->sbc) {
+		pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
+			 mmc_hostname(host), mrq->sbc->opcode,
+			 mrq->sbc->arg, mrq->sbc->flags);
+	}
+
 	pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
 		 mmc_hostname(host), mrq->cmd->opcode,
 		 mrq->cmd->arg, mrq->cmd->flags);

Signature · 1 line

1.7.4.1

Namjae Jeon

2012-02-07 07:27 UTC #1 lore raw

2012/2/7 Jaehoon Chung <[email protected]>:

Quoted 5 lines

This patch is added just debug message.
Almost features need to use the CMD23.
But we didn't see the debug message for sbc. If sbc's message can see, should be help for debugging. (We can check whether use the cmd23 or not)

Hi. Jaehoon.
how about using CONFIG_MMC_DEBUG around this debug message. Thanks.

Quoted 30 lines

Signed-off-by Jaehoon Chung <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
drivers/mmc/core/core.c | 6 ++++++

 1 files changed, 6 insertions(+), 0 deletions(-)

drivers/mmc/core/core.c +6 -1

index 8a19143..6b72eb8 100644
@@ -188,6 +188,12 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
        struct scatterlist *sg;
  #endif
 
+       if (mrq->sbc) {
+               pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
+                        mmc_hostname(host), mrq->sbc->opcode,
+                        mrq->sbc->arg, mrq->sbc->flags);
+       }
+
        pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
                 mmc_hostname(host), mrq->cmd->opcode,
                 mrq->cmd->arg, mrq->cmd->flags);
--

1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Jaehoon Chung

author

2012-02-08 07:40 UTC #2 lore raw

Quoted 8 lines · Namjae Jeon

2012/2/7 Jaehoon Chung <[email protected]>:
Quoted 5 lines
This patch is added just debug message.
Almost features need to use the CMD23.
But we didn't see the debug message for sbc. If sbc's message can see, should be help for debugging. (We can check whether use the cmd23 or not)
Hi. Jaehoon.
how about using CONFIG_MMC_DEBUG around this debug message.

Why using?

Quoted 37 lines

Thanks.
Quoted 25 lines
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/mmc/core/core.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/mmc/core/core.c +6 -1
index 8a19143..6b72eb8 100644
@@ -188,6 +188,12 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
       struct scatterlist *sg;
 #endif
 
+       if (mrq->sbc) {
+               pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
+                        mmc_hostname(host), mrq->sbc->opcode,
+                        mrq->sbc->arg, mrq->sbc->flags);
+       }
+
       pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
                mmc_hostname(host), mrq->cmd->opcode,
                mrq->cmd->arg, mrq->cmd->flags);
--
Quoted 5 lines
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Namjae Jeon

2012-02-08 09:13 UTC #3 lore raw

2012/2/8 Jaehoon Chung <[email protected]>:

Quoted 8 lines · Namjae Jeon

Quoted 7 lines
2012/2/7 Jaehoon Chung <[email protected]>:
Quoted 5 lines
This patch is added just debug message.
Almost features need to use the CMD23.
But we didn't see the debug message for sbc. If sbc's message can see, should be help for debugging. (We can check whether use the cmd23 or not)

Quoted 4 lines

Quoted 2 lines
Hi. Jaehoon.
how about using CONFIG_MMC_DEBUG around this debug message.
Why using?

It is not need because you used pr_debug. I understand. Thanks.

Quoted 40 lines

Quoted 38 lines
Thanks.
Quoted 25 lines
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
drivers/mmc/core/core.c | 6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/mmc/core/core.c +6 -1
index 8a19143..6b72eb8 100644
@@ -188,6 +188,12 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
        struct scatterlist *sg;
  #endif
 
+       if (mrq->sbc) {
+               pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
+                        mmc_hostname(host), mrq->sbc->opcode,
+                        mrq->sbc->arg, mrq->sbc->flags);
+       }
+
        pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
                 mmc_hostname(host), mrq->cmd->opcode,
                 mrq->cmd->arg, mrq->cmd->flags);
--
Quoted 5 lines
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Chris Ball

2012-02-11 21:06 UTC #4 lore raw

In reply to Jaehoon Chung

Hi,

Quoted 19 lines · Jaehoon Chung

This patch is added just debug message.
Almost features need to use the CMD23.
But we didn't see the debug message for sbc. If sbc's message can see, should be help for debugging. (We can check whether use the cmd23 or not)
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/mmc/core/core.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/mmc/core/core.c +0 -0
index 8a19143..6b72eb8 100644
@@ -188,6 +188,12 @@ mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
 	struct scatterlist *sg;
 #endif

drivers/mmc/core/core.c mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) · line 199

Quoted 10 lines

drivers/mmc/core/core.c +6 -0

 
+	if (mrq->sbc) {
+		pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
+			 mmc_hostname(host), mrq->sbc->opcode,
+			 mrq->sbc->arg, mrq->sbc->flags);
+	}
+
 	pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
 		 mmc_hostname(host), mrq->cmd->opcode,
 		 mrq->cmd->arg, mrq->cmd->flags);

Thanks, pushed to mmc-next for 3.4.

- Chris.

Signature · 2 lines

Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child