Skip to contentSkip to conversation

mke2fs: recognize mke4fs program name

PATCH Applied Eric Sandeen 3 participants 3 messages Feb 8, 2012 – Feb 15, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mke2fs: recognize mke4fs program name

We shipped "mke4fs" alongside mke2fs in RHEL5, so that ext4-capable utilities could be installed without disturbing the venerable e2fsprogs-1.39 shipped in RHEL5 from the beginning. But it surprised some users that "mke4fs" created ext2 filesystems by default rather than ext4. While it was my intent to have the renamed binaries behave exactly like the stock ones, it seems that there is some precedence for handling "mkeNfs" in the code, so seems reasonable to add
mke4fs -> ext4 as well.

---

This probably doesn't matter much to upstream, but it seems consistent with the existing code, below, if you'd like to include it.

misc/mke2fs.c +2 -0
index e97e44e..410f880 100644
@@ -1014,6 +1014,8 @@ static char **parse_fs_type(const char *fs_type,
 		ext_type = "ext2";
 	else if (!strcmp(program_name, "mke3fs"))
 		ext_type = "ext3";
+	else if (!strcmp(program_name, "mke4fs"))
+		ext_type = "ext4";
 	else if (progname) {
 		ext_type = strrchr(progname, '/');
 		if (ext_type)
#1 lore raw
Quoted 8 lines · Eric Sandeen

We shipped "mke4fs" alongside mke2fs in RHEL5, so that ext4-capable utilities could be installed without disturbing the venerable e2fsprogs-1.39 shipped in RHEL5 from the beginning. But it surprised some users that "mke4fs" created ext2 filesystems by default rather than ext4. While it was my intent to have the renamed binaries behave exactly like the stock ones, it seems that there is some precedence for handling "mkeNfs" in the code, so seems reasonable to add
mke4fs -> ext4 as well.

Makes sense I think.

Quoted 22 lines

---

This probably doesn't matter much to upstream, but it seems consistent with the existing code, below, if you'd like to include it.

misc/mke2fs.c +2 -1
index e97e44e..410f880 100644
@@ -1014,6 +1014,8 @@ static char **parse_fs_type(const char *fs_type,
 		ext_type = "ext2";
 	else if (!strcmp(program_name, "mke3fs"))
 		ext_type = "ext3";
+	else if (!strcmp(program_name, "mke4fs"))
+		ext_type = "ext4";
 	else if (progname) {
 		ext_type = strrchr(progname, '/');
 		if (ext_type)
 
--
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Cheers, Andreas

Applied
#2 lore raw
In reply to Eric Sandeen
Quoted 10 lines · Eric Sandeen

We shipped "mke4fs" alongside mke2fs in RHEL5, so that ext4-capable utilities could be installed without disturbing the venerable e2fsprogs-1.39 shipped in RHEL5 from the beginning. But it surprised some users that "mke4fs" created ext2 filesystems by default rather than ext4. While it was my intent to have the renamed binaries behave exactly like the stock ones, it seems that there is some precedence for handling "mkeNfs" in the code, so seems reasonable to add
mke4fs -> ext4 as well.

Thanks, applied.

- Ted