Skip to contentSkip to conversation

mx6: consolidating and extending anadig/analog/anatop register defs

U-Boot Wolfgang Grandegger 5 participants 8 messages Feb 13, 2012 – Feb 14, 2012

lore
Share & tools
lore
#0 lore raw

Hello,

for the USB support on MX6Q, I'm trying to consolidate and extend the register definitions for the ANADIG registers. Unfortunately, three different names are used for the same registers: ANADIG, analog and ANATOP. Any idea what the names do stand for and what would be the most appropriate one. Apart from that, we should have a separate structure and header file for these registers. Currently, they are added to the CCM regs.

Wolfgang.

#1 lore raw
Quoted 9 lines

Hello,

for the USB support on MX6Q, I'm trying to consolidate and extend the register definitions for the ANADIG registers. Unfortunately, three different names are used for the same registers: ANADIG, analog and ANATOP. Any idea what the names do stand for and what would be the most appropriate one. Apart from that, we should have a separate structure and header file for these registers. Currently, they are added to the CCM regs.

DIGCTL? ;-) That's how they call those on MX28 I believe.

M

#2 lore raw
In reply to Wolfgang Grandegger

Hi, Wolfgang,

Quoted 1 line

-----Original Message-----

From: [email protected] [mailto:u-boot-bounces at lists.denx.de]

Quoted 6 lines

On Behalf Of Wolfgang Grandegger
Sent: Monday, February 13, 2012 8:08 PM
To: U-Boot
Subject: [U-Boot] mx6: consolidating and extending anadig/analog/anatop register defs

Quoted 8 lines

Hello,

for the USB support on MX6Q, I'm trying to consolidate and extend the register definitions for the ANADIG registers. Unfortunately, three different names are used for the same registers: ANADIG, analog and ANATOP. Any idea what the names do stand for and what would be the most appropriate one. Apart from that, we should have a separate structure and header file for these registers. Currently, they are added to the CCM regs.

The register definition in the CCM according to the RM as followings:
Addresses: CCM_analog_PLL_SYS is 0h base + 0h offset = 0000_0000h CCM_analog_PLL_SYS_SET is 0h base + 4h offset = 0000_0004h CCM_analog_PLL_SYS_CLR is 0h base + 8h offset = 0000_0008h CCM_analog_PLL_SYS_TOG is 0h base + Ch offset = 0000_000Ch

Thus, I put the register definition into the CCM parts.

Quoted 7 lines

Wolfgang.

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#3 lore raw
Quoted 20 lines

Hi, Wolfgang,

Quoted 10 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Wolfgang Grandegger
Sent: Monday, February 13, 2012 8:08 PM
To: U-Boot
Subject: [U-Boot] mx6: consolidating and extending anadig/analog/anatop register defs

Hello,

Quoted 7 lines

for the USB support on MX6Q, I'm trying to consolidate and extend the register definitions for the ANADIG registers. Unfortunately, three different names are used for the same registers: ANADIG, analog and ANATOP. Any idea what the names do stand for and what would be the most appropriate one. Apart from that, we should have a separate structure and header file for these registers. Currently, they are added to the CCM regs.

Quoted 7 lines

The register definition in the CCM according to the RM as followings:
Addresses: CCM_analog_PLL_SYS is 0h base + 0h offset = 0000_0000h CCM_analog_PLL_SYS_SET is 0h base + 4h offset = 0000_0004h CCM_analog_PLL_SYS_CLR is 0h base + 8h offset = 0000_0008h CCM_analog_PLL_SYS_TOG is 0h base + Ch offset = 0000_000Ch

Thus, I put the register definition into the CCM parts.

This again resembles MX28 ... damn, can't we share some parts of MX28 for MX6Q ?

Fabio, I think I'll need one too, this is getting weird ;-)

M

#4 lore raw

Hi Marek,

Quoted 26 lines · Marek Vasut
Quoted 26 lines

Hi, Wolfgang,

Quoted 10 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Wolfgang Grandegger
Sent: Monday, February 13, 2012 8:08 PM
To: U-Boot
Subject: [U-Boot] mx6: consolidating and extending anadig/analog/anatop register defs

Hello,

Quoted 7 lines

for the USB support on MX6Q, I'm trying to consolidate and extend the register definitions for the ANADIG registers. Unfortunately, three different names are used for the same registers: ANADIG, analog and ANATOP. Any idea what the names do stand for and what would be the most appropriate one. Apart from that, we should have a separate structure and header file for these registers. Currently, they are added to the CCM regs.

The register definition in the CCM according to the RM as followings:
Addresses: CCM_analog_PLL_SYS is 0h base + 0h offset = 0000_0000h CCM_analog_PLL_SYS_SET is 0h base + 4h offset = 0000_0004h CCM_analog_PLL_SYS_CLR is 0h base + 8h offset = 0000_0008h CCM_analog_PLL_SYS_TOG is 0h base + Ch offset = 0000_000Ch

Quoted 5 lines
Quoted 1 line

Thus, I put the register definition into the CCM parts.

This again resembles MX28 ... damn, can't we share some parts of MX28 for MX6Q ?

Fabio, I think I'll need one too, this is getting weird ;-)

Unfortunately, I did not get hold of a RM yet :(. It's still under NDA, I believe. Therefore I will postpone my "consolidation" activities for the time being. The USB support patch I sent does work, as Dirk confirmed, and therefore I suggest to apply it as intermediate solution.

Wolfgang.

#5 lore raw
Quoted 29 lines

Hi Marek,

Quoted 26 lines · Marek Vasut
Quoted 26 lines

Hi, Wolfgang,

Quoted 10 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Wolfgang Grandegger Sent: Monday, February 13, 2012 8:08 PM
To: U-Boot
Subject: [U-Boot] mx6: consolidating and extending anadig/analog/anatop register defs

Hello,

Quoted 7 lines

for the USB support on MX6Q, I'm trying to consolidate and extend the register definitions for the ANADIG registers. Unfortunately, three different names are used for the same registers: ANADIG, analog and ANATOP. Any idea what the names do stand for and what would be the most appropriate one. Apart from that, we should have a separate structure and header file for these registers. Currently, they are added to the CCM regs.

The register definition in the CCM according to the RM as followings:
Addresses: CCM_analog_PLL_SYS is 0h base + 0h offset = 0000_0000h CCM_analog_PLL_SYS_SET is 0h base + 4h offset = 0000_0004h CCM_analog_PLL_SYS_CLR is 0h base + 8h offset = 0000_0008h CCM_analog_PLL_SYS_TOG is 0h base + Ch offset = 0000_000Ch

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Thus, I put the register definition into the CCM parts.

This again resembles MX28 ... damn, can't we share some parts of MX28 for MX6Q ?

Fabio, I think I'll need one too, this is getting weird ;-)

Unfortunately, I did not get hold of a RM yet :(.

RM? Who's that?

It's still under NDA,

Quoted 2 lines

I believe. Therefore I will postpone my "consolidation" activities for the time being.

Sorry, I don't intent to hinder your efforts, I'm just seeing a pattern :)

The USB support patch I sent does work, as Dirk

Quoted 1 line

confirmed, and therefore I suggest to apply it as intermediate solution.

Well ... All right then. Though my sense for perfect solution is hurting a lot ;-)

Quoted 2 lines

Wolfgang.

#6 lore raw
Quoted 31 lines · Marek Vasut
Quoted 31 lines

Hi Marek,

Quoted 28 lines · Marek Vasut
Quoted 27 lines

Hi, Wolfgang,

Quoted 10 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Wolfgang Grandegger Sent: Monday, February 13, 2012 8:08 PM
To: U-Boot
Subject: [U-Boot] mx6: consolidating and extending anadig/analog/anatop register defs

Hello,

Quoted 7 lines

for the USB support on MX6Q, I'm trying to consolidate and extend the register definitions for the ANADIG registers. Unfortunately, three different names are used for the same registers: ANADIG, analog and ANATOP. Any idea what the names do stand for and what would be the most appropriate one. Apart from that, we should have a separate structure and header file for these registers. Currently, they are added to the CCM regs.

The register definition in the CCM according to the RM as followings:
Addresses: CCM_analog_PLL_SYS is 0h base + 0h offset = 0000_0000h CCM_analog_PLL_SYS_SET is 0h base + 4h offset = 0000_0004h CCM_analog_PLL_SYS_CLR is 0h base + 8h offset = 0000_0008h CCM_analog_PLL_SYS_TOG is 0h base + Ch offset = 0000_000Ch

Thus, I put the register definition into the CCM parts.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

This again resembles MX28 ... damn, can't we share some parts of MX28 for MX6Q ?

Fabio, I think I'll need one too, this is getting weird ;-)

Unfortunately, I did not get hold of a RM yet :(.

RM? Who's that?

Reference Manual!

Quoted 10 lines

It's still under NDA,

Quoted 2 lines

I believe. Therefore I will postpone my "consolidation" activities for the time being.

Sorry, I don't intent to hinder your efforts, I'm just seeing a pattern :)

The USB support patch I sent does work, as Dirk

Quoted 1 line

confirmed, and therefore I suggest to apply it as intermediate solution.

Well ... All right then. Though my sense for perfect solution is hurting a lot ;-)

Well, that's OK and I realized some kind of mess as well, which should be fixed sooner than later.

Wolfgang.

#7 lore raw
In reply to Wolfgang Grandegger
Quoted 4 lines · Wolfgang Grandegger

Unfortunately, I did not get hold of a RM yet :(. It's still under NDA, I believe. Therefore I will postpone my "consolidation" activities for the time being. The USB support patch I sent does work, as Dirk confirmed, and therefore I suggest to apply it as intermediate solution.

Ok, nice. I will apply your patches to u-boot-imx.

Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================