Skip to contentSkip to conversation

Bug#660154: qemu-keymaps: Finnish keyboard mapping broken

Qemu-devel New Michael Tokarev 2 participants 4 messages Mar 2, 2012 – May 9, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Michael Tokarev

author
#1 lore raw
Quoted 11 lines · Timo Sirainen

Subject: qemu-keymaps: Finnish keyboard mapping broken
Package: qemu-keymaps
Version: 1.0+dfsg-3
Severity: normal

With "-k fi -vnc :1" the keyboard layout works pretty well, except the key between left shift and "z" key, which generates <> characters doesn't work. Instead of "<" it shows "z" and instead of ">" (shift-<) it shows "X".

It works correctly if I comment out these lines:

less 0x2c shift altgr
greater 0x2d shift altgr

Confirmed, and the fix is verified by independent person with finnish keyboard -- https://bugzilla.redhat.com/show_bug.cgi?id=794653
Thank you Atro for the help!

The attached patch does just this: removes the two mentioned lines.

index 2a4e0f0..4be7586 100644

pc-bios/keymaps/fi +0 -2
@@ -99,9 +99,7 @@ asterisk 0x2b shift
 acute 0x2b altgr
 multiply 0x2b shift altgr
 guillemotleft 0x2c altgr
-less 0x2c shift altgr
 guillemotright 0x2d altgr
-greater 0x2d shift altgr
 copyright 0x2e altgr
 leftdoublequotemark 0x2f altgr
 grave 0x2f shift altgr

Thanks!

/mjt

#2 lore raw

Hi,

Quoted 8 lines · Michael Tokarev
Quoted 7 lines · Timo Sirainen

Subject: qemu-keymaps: Finnish keyboard mapping broken
Package: qemu-keymaps
Version: 1.0+dfsg-3
Severity: normal

With "-k fi -vnc :1" the keyboard layout works pretty well, except the key between left shift and "z" key, which generates<> characters doesn't work. Instead of "<" it shows "z" and instead of">" (shift-<) it shows "X".

Quoted 8 lines
Quoted 4 lines

It works correctly if I comment out these lines:

less 0x2c shift altgr
greater 0x2d shift altgr

Confirmed, and the fix is verified by independent person with finnish keyboard -- https://bugzilla.redhat.com/show_bug.cgi?id=794653
Thank you Atro for the help!

while the fix above would seem to resolve this specific issue in most cases it is probably best to leave the keymap undefined thus avoiding using the QEMU internal keymap definitions at all:

https://bugzilla.redhat.com/show_bug.cgi?id=638523
http://hg.fedorahosted.org/hg/python-virtinst/rev/2bde513dcd9e
http://berrange.com/posts/2010/07/04/more-than-you-or-i-ever-wanted-to-know-about-virtual-keyboard-handling/

Cheers,

Signature · 1 line
Marko Myllynen
author
#3 lore raw

PATCH 1/1 qemu-keymaps: Finnish keyboard mapping broken

In reply to a message not in the archive

As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping is kind of broken. Fix it as Timo Sirainen suggests in #660154.

index 2a4e0f0..4be7586 100644

pc-bios/keymaps/fi +0 -2
@@ -99,9 +99,7 @@ asterisk 0x2b shift
 acute 0x2b altgr
 multiply 0x2b shift altgr
 guillemotleft 0x2c altgr
-less 0x2c shift altgr
 guillemotright 0x2d altgr
-greater 0x2d shift altgr
 copyright 0x2e altgr
 leftdoublequotemark 0x2f altgr
 grave 0x2f shift altgr

Thanks!

/mjt

author
#4 lore raw

PATCH 1/1 qemu-keymaps: Finnish keyboard mapping broken

In reply to a message not in the archive

As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping is kind of broken. Fix it as Timo Sirainen suggests in #660154.

Signed-off-by Michael Tokarev <[email protected]>

index 2a4e0f0..4be7586 100644

pc-bios/keymaps/fi +0 -2
@@ -99,9 +99,7 @@ asterisk 0x2b shift
 acute 0x2b altgr
 multiply 0x2b shift altgr
 guillemotleft 0x2c altgr
-less 0x2c shift altgr
 guillemotright 0x2d altgr
-greater 0x2d shift altgr
 copyright 0x2e altgr
 leftdoublequotemark 0x2f altgr
 grave 0x2f shift altgr

Thanks!

/mjt