include usbinit package with usbgadget feature
PATCH 1/1 include usbinit package with usbgadget feature
The g_ether kernel module, in the kernel-module-g-ether package, allows targets to use a USB connection as a network interface. However, that's not useful until the module is loaded.
The usbinit package provides the /etc/init.d/usb-gether script to load the g_ether module at boot, so it should be included along with kernel-module-g-ether.
Tested with core-image-base on beagleboard.
---
meta/recipes-core/tasks/task-base.bb +3 -2
@@ -2,7 +2,7 @@ DESCRIPTION = "Merge machine and distro options to create a basic machine task/p LICENSE = "MIT" LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \ file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" -PR = "r73" +PR = "r74" inherit task
@@ -248,7 +248,8 @@ RRECOMMENDS_task-base-usbgadget = "\ kernel-module-gadgetfs \ kernel-module-g-file-storage \ kernel-module-g-serial \ - kernel-module-g-ether" + kernel-module-g-ether \ + usbinit" RDEPENDS_task-base-usbhost = "\ usbutils "
Quoted 7 lines · Hollis Blanchard
The
g_etherkernel module, in the kernel-module-g-ether package, allows targets to use a USB connection as a network interface. However, that's not useful until the module is loaded.The usbinit package provides the
/etc/init.d/usb-getherscript to load theg_ethermodule at boot, so it should be included along with kernel-module-g-ether.
So if the g-ether kernel module is built-in to the kernel, the kernel-module-g-ether will not be installed (as it's RRECOMMENDS). The usbinit package still will be (unless for some reason it can't be built for the target).
I assume this doesn't pose a problem?
This does mean usbinit would be installed when it isn't strictly necessary - but that's better than not installing it if it's required. Looks good to me.
--
Darren
Quoted 35 lines
Tested with core-image-base on beagleboard.
Signed-off-by Hollis Blanchard <[email protected]>---
meta/recipes-core/tasks/task-base.bb +3
-2@@ -2,7 +2,7 @@ DESCRIPTION = "Merge machine and distro options to create a basic machine task/p LICENSE = "MIT" LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \ file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" -PR = "r73" +PR = "r74" inherit task@@ -248,7 +248,8 @@ RRECOMMENDS_task-base-usbgadget = "\ kernel-module-gadgetfs \ kernel-module-g-file-storage \ kernel-module-g-serial \ - kernel-module-g-ether" + kernel-module-g-ether \ + usbinit" RDEPENDS_task-base-usbhost = "\ usbutils "_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
Signature · 3 lines
Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel
Quoted 8 lines · Darren Hart
Quoted 7 lines · Hollis Blanchard
The
g_etherkernel module, in the kernel-module-g-ether package, allows targets to use a USB connection as a network interface. However, that's not useful until the module is loaded.The usbinit package provides the
/etc/init.d/usb-getherscript to load theg_ethermodule at boot, so it should be included along with kernel-module-g-ether.
Quoted 6 lines
So if the g-ether kernel module is built-in to the kernel, the kernel-module-g-ether will not be installed (as it's RRECOMMENDS). The usbinit package still will be (unless for some reason it can't be built for the target).
I assume this doesn't pose a problem?
Well, hmm, I don't know. The usb-gether script is not very intelligent, so I suppose that would result in yet another boot time error message. Perhaps testing the result of 'modinfo g_ether' in the script would be a good follow-up patch?
Hollis Blanchard
Mentor Graphics, Embedded Systems Division
Quoted 14 lines · Hollis Blanchard
Quoted 13 lines · Darren Hart
Quoted 7 lines · Hollis Blanchard
The
g_etherkernel module, in the kernel-module-g-ether package, allows targets to use a USB connection as a network interface. However, that's not useful until the module is loaded.The usbinit package provides the
/etc/init.d/usb-getherscript to load theg_ethermodule at boot, so it should be included along with kernel-module-g-ether.So if the g-ether kernel module is built-in to the kernel, the kernel-module-g-ether will not be installed (as it's RRECOMMENDS). The usbinit package still will be (unless for some reason it can't be built for the target).
Quoted 7 lines
Quoted 1 line
I assume this doesn't pose a problem?
Well, hmm, I don't know. The usb-gether script is not very intelligent, so I suppose that would result in yet another boot time error message. Perhaps testing the result of 'modinfo
g_ether' in the script would be a good follow-up patch?
Sounds reasonable to me.
Signature · 3 lines
Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel
Quoted 26 lines · Hollis Blanchard
The
g_etherkernel module, in the kernel-module-g-ether package, allows targets to use a USB connection as a network interface. However, that's not useful until the module is loaded.The usbinit package provides the
/etc/init.d/usb-getherscript to load theg_ethermodule at boot, so it should be included along with kernel-module-g-ether.Tested with core-image-base on beagleboard.
Signed-off-by Hollis Blanchard <[email protected]>---
meta/recipes-core/tasks/task-base.bb +0
-0@@ -2,7 +2,7 @@ DESCRIPTION = "Merge machine and distro options tocreate a basic machine task/p
LICENSE = "MIT"
LIC_FILES_CHKSUM=
"file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
meta/recipes-core/tasks/task-base.bb +1
-1-PR = "r73" +PR = "r74" inherit task
meta/recipes-core/tasks/task-base.bb RRECOMMENDS_task-base-usbgadget = "\ · line 255
Quoted 9 lines
meta/recipes-core/tasks/task-base.bb +2
-1@@ -248,7 +248,8 @@ RRECOMMENDS_task-base-usbgadget = "\ kernel-module-gadgetfs \ kernel-module-g-file-storage \ kernel-module-g-serial \ - kernel-module-g-ether" + kernel-module-g-ether \ + usbinit" RDEPENDS_task-base-usbhost = "\ usbutils "
Any additional comments?
Hollis Blanchard
Mentor Graphics, Embedded Systems Division