Skip to contentSkip to conversation

mremap: fix dependency on ipc subdir

PATCH In review Jan Stancek 3 participants 3 messages Mar 26, 2012 – Mar 27, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mremap: fix dependency on ipc subdir

We need to use MAKE_DEPS to declare the ipc subdir depend otherwise attempting to do make mremap01 without building in the ipc subdir will fail, and we can hit race conditions in the overall make.

This is same change as in commit:
commit 7103d3e8e0f9dc1804ba06ee66ee02753e8ce50e

Author: Mike Frysinger <[email protected]>
Date:   Fri Mar 23 12:27:13 2012 -0400

kill: fix dependency on ipc subdir

---
 testcases/kernel/syscalls/mremap/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
testcases/kernel/syscalls/mremap/Makefile +1 -1
index 63e7485..102e473 100644
@@ -32,7 +32,7 @@ $(LIBDIR):
 $(LIB): $(LIBDIR)
 	$(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" all
 
-all: | $(LIB)
+MAKE_DEPS		:= $(LIB)
 
 CPPFLAGS                += -I$(abs_srcdir)/$(LIBDIR)
 

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Jan Stancek

We need to use MAKE_DEPS to declare the ipc subdir depend otherwise attempting to do make mremap01 without building in the ipc subdir will fail, and we can hit race conditions in the overall make.

Quoted 7 lines

This is same change as in commit:
commit 7103d3e8e0f9dc1804ba06ee66ee02753e8ce50e

Author: Mike Frysinger <[email protected]>
Date:   Fri Mar 23 12:27:13 2012 -0400

kill: fix dependency on ipc subdir

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
Quoted 12 lines · Caspar Zhang
Quoted 11 lines · Jan Stancek

We need to use MAKE_DEPS to declare the ipc subdir depend otherwise attempting to do make mremap01 without building in the ipc subdir will fail, and we can hit race conditions in the overall make.

This is same change as in commit:
commit 7103d3e8e0f9dc1804ba06ee66ee02753e8ce50e

Author: Mike Frysinger <[email protected]>
Date:   Fri Mar 23 12:27:13 2012 -0400

kill: fix dependency on ipc subdir

Quoted 3 lines
Quoted 1 line

Thanks Jan, Caspar pushed,

Wanlong Gao

Quoted 10 lines

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list