Skip to contentSkip to conversation

libselinux: Enable many more gcc warnings for

PATCH In review Daniel J Walsh 3 participants 4 messages Mar 27, 2012 – Mar 28, 2012 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 27/73 libselinux: Enable many more gcc warnings for

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This patch looks good to me. acked.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9x2FAACgkQrlYvE4MpobMrTQCdH4LkASjhalXwZxoGX9x3oa+g 6D0AnjSrYCkPVEZFrfwJ41l2PVwrWFot
=RepO
-----END PGP SIGNATURE-----

#1 lore raw
Quoted 1 line · Daniel J Walsh

This patch looks good to me. acked.

It's kind of ugly to conflate warnings with the control options like -fasynchronous-unwind-tables -funit-at-a-time

Maybe consider splitting them out?

Incidentally from the gcc manual:

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

#2 lore raw

We lose part of the message Colin?

Quoted 8 lines · Colin Walters
Quoted 1 line · Daniel J Walsh

This patch looks good to me. acked.

It's kind of ugly to conflate warnings with the control options like -fasynchronous-unwind-tables -funit-at-a-time

Maybe consider splitting them out?

Quoted 8 lines

Incidentally from the gcc manual:

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

#3 lore raw
Quoted 1 line · Eric Paris

We lose part of the message Colin?

Yeah, sorry:

`-funit-at-a-time'
This option is left for compatibility reasons. -funit-at-a-time' has no effect, while -fno-unit-at-a-time' implies -fno-toplevel-reorder' and -fno-section-anchors'.

Enabled by default.

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.