Skip to contentSkip to conversation

imx: Use GPIO_TO_PORT macro in the gpio driver instead of (gpio >> 5)

PATCH New Vikram Narayanan 2 participants 3 messages Apr 10, 2012 – Apr 11, 2012

Subsystems (2)
Arm i.MX and Layerscape GPIO
lore
Share & tools
lore

Vikram Narayanan

author
#0 lore raw

PATCH v2 3/4 imx: Use GPIO_TO_PORT macro in the gpio driver instead of (gpio >> 5)

Use the defined GPIO_TO_PORT macro. Remove gpio >> 5 references.

Signed-off-by Vikram Narayanan <[email protected]>
---
 drivers/gpio/mxc_gpio.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpio/mxc_gpio.c +4 -4
index 7e65b39..21b1cdc 100644
@@ -54,7 +54,7 @@ static unsigned long gpio_ports[] = {
 static int mxc_gpio_direction(unsigned int gpio,
 	enum mxc_gpio_direction direction)
 {
-	unsigned int port = gpio >> 5;
+	unsigned int port = GPIO_TO_PORT(gpio);
 	struct gpio_regs *regs;
 	u32 l;
 

@@ -81,7 +81,7 @@ static int mxc_gpio_direction(unsigned int gpio,
 
 int gpio_set_value(unsigned gpio, int value)
 {
-	unsigned int port = gpio >> 5;
+	unsigned int port = GPIO_TO_PORT(gpio);
 	struct gpio_regs *regs;
 	u32 l;
 

@@ -104,7 +104,7 @@ int gpio_set_value(unsigned gpio, int value)
 
 int gpio_get_value(unsigned gpio)
 {
-	unsigned int port = gpio >> 5;
+	unsigned int port = GPIO_TO_PORT(gpio);
 	struct gpio_regs *regs;
 	u32 val;
 

@@ -122,7 +122,7 @@ int gpio_get_value(unsigned gpio)
 
 int gpio_request(unsigned gpio, const char *label)
 {
-	unsigned int port = gpio >> 5;
+	unsigned int port = GPIO_TO_PORT(gpio);
 	if (port >= ARRAY_SIZE(gpio_ports))
 		return -1;
 	return 0;
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH v2 3/4 imx: Use GPIO_TO_PORT macro in the gpio driver instead of (gpio >> 5)

Quoted 39 lines · Vikram Narayanan

Use the defined GPIO_TO_PORT macro. Remove gpio >> 5 references.

Signed-off-by Vikram Narayanan <[email protected]>
---
 drivers/gpio/mxc_gpio.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpio/mxc_gpio.c +3 -3
index 7e65b39..21b1cdc 100644
@@ -54,7 +54,7 @@ static unsigned long gpio_ports[] = {
 static int mxc_gpio_direction(unsigned int gpio,
 	enum mxc_gpio_direction direction)
 {
-	unsigned int port = gpio >> 5;
+	unsigned int port = GPIO_TO_PORT(gpio);
 	struct gpio_regs *regs;
 	u32 l;
 

@@ -81,7 +81,7 @@ static int mxc_gpio_direction(unsigned int gpio,
 
 int gpio_set_value(unsigned gpio, int value)
 {
-	unsigned int port = gpio >> 5;
+	unsigned int port = GPIO_TO_PORT(gpio);
 	struct gpio_regs *regs;
 	u32 l;
 

@@ -104,7 +104,7 @@ int gpio_set_value(unsigned gpio, int value)
 
 int gpio_get_value(unsigned gpio)
 {
-	unsigned int port = gpio >> 5;
+	unsigned int port = GPIO_TO_PORT(gpio);
 	struct gpio_regs *regs;
 	u32 val;

drivers/gpio/mxc_gpio.c int gpio_get_value(unsigned gpio) · line 128

Quoted 8 lines
drivers/gpio/mxc_gpio.c +1 -1
@@ -122,7 +122,7 @@ int gpio_get_value(unsigned gpio)
 
 int gpio_request(unsigned gpio, const char *label)
 {
-	unsigned int port = gpio >> 5;
+	unsigned int port = GPIO_TO_PORT(gpio);
 	if (port >= ARRAY_SIZE(gpio_ports))
 		return -1;
 	return 0;
Acked-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw

PATCH v2 3/4 imx: Use GPIO_TO_PORT macro in the gpio driver instead of (gpio >> 5)

In reply to Vikram Narayanan
Quoted 4 lines · Vikram Narayanan

Use the defined GPIO_TO_PORT macro. Remove gpio >> 5 references.

Signed-off-by Vikram Narayanan <[email protected]>

---

Applied to u-boot-imx (fix), thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================