Skip to contentSkip to conversation

pnx_clocksource broken?

DISCUSSION John Stultz 2 participants 3 messages Apr 11, 2012 – Jan 22, 2013 MIPS

lore
Share & tools
lore
#0 lore raw

Looking at arch/mips/pnx8550/common/time.c the pnx_clocksource never seems to be assigned a mult/shift value before it calls clocksource_register(). Clearly this is broken and I suspect this clocksource is never used.

I was hoping to convert this driver over (its the last of 3 remaining) to use clocksource_register_hz/khz() but I'm not sure what the actual frequency of the hardware should be. Is mips_hpt_frequency the right value here?

Even so, if this is clocksource is never used, should it just be removed?

thanks
-john

#1 lore raw

Any NXP PNX user left (was: Re: pnx_clocksource broken?)

Quoted 11 lines · John Stultz

Looking at arch/mips/pnx8550/common/time.c the pnx_clocksource never seems to be assigned a mult/shift value before it calls clocksource_register(). Clearly this is broken and I suspect this clocksource is never used.

I was hoping to convert this driver over (its the last of 3 remaining) to use clocksource_register_hz/khz() but I'm not sure what the actual frequency of the hardware should be. Is mips_hpt_frequency the right value here?

Even so, if this is clocksource is never used, should it just be removed?

Iow PNX has not had a functioning clocksource for a very long time. Equally there has not been any user feedback for ages and I wonder if that makes the PNX code a candidate for removal.

Any remaining PNX users should raise their voice now or PNX will be toast. Soon.

Ralf

#2 lore raw

Re: Any NXP PNX user left (was: Re: pnx_clocksource broken?)

Quoted 10 lines · Ralf Baechle
Quoted 10 lines

Looking at arch/mips/pnx8550/common/time.c the pnx_clocksource never seems to be assigned a mult/shift value before it calls clocksource_register(). Clearly this is broken and I suspect this clocksource is never used.

I was hoping to convert this driver over (its the last of 3 remaining) to use clocksource_register_hz/khz() but I'm not sure what the actual frequency of the hardware should be. Is mips_hpt_frequency the right value here?

Quoted 8 lines
Quoted 1 line

Even so, if this is clocksource is never used, should it just be removed?

Iow PNX has not had a functioning clocksource for a very long time. Equally there has not been any user feedback for ages and I wonder if that makes the PNX code a candidate for removal.

Any remaining PNX users should raise their voice now or PNX will be toast. Soon.

Not soon at all but nobody's answered so I've removed all of PNX8550.

Ralf