fix build error with seabios
PATCH 1/1 fix build error with seabios
Pass PYTHON down to seabios, so seabios will use same python binary as whole xen tree does. Fixes build error on NetBSD.
tools/firmware/Makefile +1 -1
@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.
Ian, does this look sensible to you ?
Quoted 21 lines
Signed-off-by Christoph Egger <[email protected]>----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Ian Campbell
Acked-byQuoted 7 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that is OK, so we might as well take this now.
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the future
Quoted 2 lines
Quoted 2 lines
Signed-off-by Christoph Egger <[email protected]>
Quoted 20 lines
Quoted 20 lines
----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Quoted 11 lines · Ian Campbell
Quoted 7 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of
tools/firmware, but I guess that is OK, so we might as well take this now.
Thanks.
Quoted 3 lines
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the future
No, this doesn't work.
Quoted 29 lines
Quoted 3 lines
Quoted 3 lines
Signed-off-by Christoph Egger <[email protected]>Acked-by Ian Campbell <[email protected]>Quoted 20 lines
Quoted 20 lines
----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
Quoted 19 lines · Christoph Egger
Quoted 11 lines · Ian Campbell
Quoted 7 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of
tools/firmware, but I guess that is OK, so we might as well take this now.Thanks.
Quoted 6 lines
Quoted 3 lines
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the futureNo, this doesn't work.
What about
subdir-all-seabios: PYTHON=...
?
Quoted 33 lines
Quoted 30 lines
Quoted 4 lines
Quoted 4 lines
Signed-off-by Christoph Egger <[email protected]>Acked-by Ian Campbell <[email protected]>Quoted 20 lines
Quoted 20 lines
----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Quoted 24 lines · Ian Campbell
Quoted 23 lines · Christoph Egger
Quoted 11 lines · Ian Campbell
Quoted 7 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of
tools/firmware, but I guess that is OK, so we might as well take this now.Thanks.
Quoted 3 lines
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the future
Quoted 5 lines
Quoted 1 line
No, this doesn't work.
What about
subdir-all-seabios: PYTHON=...
?
No, doesn't work. I also tried without success:
subdirs-all-seabios
subdir-all-seabios-dir
subdirs-all-seabios-dir
seabios-dir
Christoph
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Christoph Egger <[email protected]>Acked-by Ian Campbell <[email protected]>Quoted 16 lines
Quoted 16 lines
----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
Quoted 33 lines · Christoph Egger
Quoted 24 lines · Ian Campbell
Quoted 23 lines · Christoph Egger
Quoted 11 lines · Ian Campbell
Quoted 7 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of
tools/firmware, but I guess that is OK, so we might as well take this now.Thanks.
Quoted 3 lines
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the futureQuoted 5 lines
Quoted 1 line
No, this doesn't work.
What about
subdir-all-seabios: PYTHON=...
?
Quoted 6 lines
No, doesn't work. I also tried without success:
subdirs-all-seabios
subdir-all-seabios-dir
subdirs-all-seabios-dir
seabios-dir
I found something that works:
subdir-all-seabios-dir:
export PYTHON=$(PYTHON)
Christoph
Quoted 24 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 3 lines
Quoted 3 lines
Signed-off-by Christoph Egger <[email protected]>Acked-by Ian Campbell <[email protected]>Quoted 16 lines
Quoted 16 lines
----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
Quoted 42 lines · Christoph Egger
Quoted 33 lines · Christoph Egger
Quoted 24 lines · Ian Campbell
Quoted 23 lines · Christoph Egger
Quoted 11 lines · Ian Campbell
Quoted 7 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of
tools/firmware, but I guess that is OK, so we might as well take this now.Thanks.
Quoted 3 lines
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the futureQuoted 5 lines
Quoted 1 line
No, this doesn't work.
What about
subdir-all-seabios: PYTHON=...
?Quoted 6 lines
No, doesn't work. I also tried without success:
subdirs-all-seabios
subdir-all-seabios-dir
subdirs-all-seabios-dir
seabios-dir
Quoted 4 lines
I found something that works:
subdir-all-seabios-dir:
export PYTHON=$(PYTHON)
Ah, no. This causes a subsequent seabios build error about a missing build rule. I should have waited with sending the mail till the build finished.
Quoted 23 lines
Christoph
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 3 lines
Quoted 3 lines
Signed-off-by Christoph Egger <[email protected]>Acked-by Ian Campbell <[email protected]>Quoted 16 lines
Quoted 16 lines
----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
Quoted 42 lines · Christoph Egger
Quoted 33 lines · Christoph Egger
Quoted 24 lines · Ian Campbell
Quoted 23 lines · Christoph Egger
Quoted 11 lines · Ian Campbell
Quoted 7 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of
tools/firmware, but I guess that is OK, so we might as well take this now.Thanks.
Quoted 3 lines
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the futureQuoted 5 lines
Quoted 1 line
No, this doesn't work.
What about
subdir-all-seabios: PYTHON=...
?Quoted 6 lines
No, doesn't work. I also tried without success:
subdirs-all-seabios
subdir-all-seabios-dir
subdirs-all-seabios-dir
seabios-dir
Quoted 4 lines
I found something that works:
subdir-all-seabios-dir:
export PYTHON=$(PYTHON)
Really, that's not a syntax I've ever seen before, I've no idea how that works, all on the same line, sure, but on the next line like that, odd!. I would have thought that this would have caused "export PYTHON= $(PYTHON)" to be run it its own new subshell which would immediately exit.
Anyway, I guess if it works we might as well use this version...
Ian.
Quoted 29 lines
Christoph
Quoted 24 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 3 lines
Quoted 3 lines
Signed-off-by Christoph Egger <[email protected]>Acked-by Ian Campbell <[email protected]>Quoted 16 lines
Quoted 16 lines
----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------
Quoted 48 lines · Ian Campbell
Quoted 42 lines · Christoph Egger
Quoted 33 lines · Christoph Egger
Quoted 24 lines · Ian Campbell
Quoted 23 lines · Christoph Egger
Quoted 11 lines · Ian Campbell
Quoted 7 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of
tools/firmware, but I guess that is OK, so we might as well take this now.Thanks.
Quoted 3 lines
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the futureQuoted 5 lines
Quoted 1 line
No, this doesn't work.
What about
subdir-all-seabios: PYTHON=...
?Quoted 6 lines
No, doesn't work. I also tried without success:
subdirs-all-seabios
subdir-all-seabios-dir
subdirs-all-seabios-dir
seabios-dirQuoted 4 lines
I found something that works:
subdir-all-seabios-dir:
export PYTHON=$(PYTHON)
Quoted 7 lines
Really, that's not a syntax I've ever seen before, I've no idea how that works, all on the same line, sure, but on the next line like that, odd!. I would have thought that this would have caused "export PYTHON= $(PYTHON)" to be run it its own new subshell which would immediately exit.
Anyway, I guess if it works we might as well use this version...
No, it doesn't. It causes a subsequent seabios build error about a missing build rule. I should have waited with reporting this till the build finished.
Christoph
Quoted 36 lines
Ian.
Quoted 29 lines
Christoph
Quoted 24 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 3 lines
Quoted 3 lines
Signed-off-by Christoph Egger <[email protected]>Acked-by Ian Campbell <[email protected]>Quoted 16 lines
Quoted 16 lines
----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
Quoted 33 lines · Christoph Egger
Quoted 24 lines · Ian Campbell
Quoted 23 lines · Christoph Egger
Quoted 11 lines · Ian Campbell
Quoted 7 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of
tools/firmware, but I guess that is OK, so we might as well take this now.Thanks.
Quoted 3 lines
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the futureQuoted 5 lines
Quoted 1 line
No, this doesn't work.
What about
subdir-all-seabios: PYTHON=...
?
Quoted 6 lines
No, doesn't work. I also tried without success:
subdirs-all-seabios
subdir-all-seabios-dir
subdirs-all-seabios-dir
seabios-dir
Strange. Oh well I guess the original patch does the job.
Ian.
Quoted 26 lines
Christoph
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Christoph Egger <[email protected]>Acked-by Ian Campbell <[email protected]>Quoted 16 lines
Quoted 16 lines
----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------
Quoted 34 lines · Ian Campbell
Quoted 33 lines · Christoph Egger
Quoted 29 lines · Ian Campbell
Quoted 19 lines · Christoph Egger
Quoted 11 lines · Ian Campbell
Quoted 7 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of
tools/firmware, but I guess that is OK, so we might as well take this now.Thanks.
Quoted 5 lines
Quoted 3 lines
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the futureNo, this doesn't work.
What about
subdir-all-seabios: PYTHON=...
?
Quoted 8 lines
Quoted 6 lines
No, doesn't work. I also tried without success:
subdirs-all-seabios
subdir-all-seabios-dir
subdirs-all-seabios-dir
seabios-dirStrange. Oh well I guess the original patch does the job.
Yes, that's right.
Christoph
Quoted 32 lines
Ian.
Quoted 26 lines
Christoph
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Christoph Egger <[email protected]>Acked-by Ian Campbell <[email protected]>Quoted 16 lines
Quoted 16 lines
----------------------------------------------------------------------
diff -rab552da976a3tools/firmware/Makefiletools/firmware/Makefile +1
-2@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y) false ; \ fi endif - $(MAKE) subdirs-$@ + $(MAKE) PYTHON=$(PYTHON) subdirs-$@ .PHONY: install ----------------------------------------------------------------------
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
Ian Campbell writes ("Re: [Xen-devel] [PATCH] fix build error with seabios"):
Quoted 11 lines · Ian Jackson
Quoted 7 lines
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
Quoted 4 lines
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of
tools/firmware, but I guess that is OK, so we might as well take this now.
I wasn't sure about that. But OK.
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Christoph Egger <[email protected]>Acked-by Ian Campbell <[email protected]>
I have applied it.
But I rewrote the commit message. Christoph, I often find I need to rewrite or reword your commit messages; you might like to look at the message for 25241:15f094c85c85 to see what would be a more conventional style and set of information.
Thanks,
Ian.