Skip to contentSkip to conversation

ath5k: add missing iounmap to AHB probe removal

PATCH In review Jonathan Bither 2 participants 2 messages Apr 24, 2012 Atheros ATH5K wireless driver

lore
Share & tools
lore

Jonathan Bither

author
#0 lore raw

PATCH v2 1/1 ath5k: add missing iounmap to AHB probe removal

When our driver device is removed on the AHB bus, our IO memory is never unmapped.

Signed-off-by Jonathan Bither <[email protected]>
drivers/net/wireless/ath/ath5k/ahb.c +1 -0
index 8c50d9d..aec33cc 100644
@@ -220,6 +220,7 @@ static int ath_ahb_remove(struct platform_device *pdev)
 	}
 
 	ath5k_deinit_ah(ah);
+	iounmap(ah->iobase);
 	platform_set_drvdata(pdev, NULL);
 	ieee80211_free_hw(hw);
Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · On Tue, 24 Apr 2012 05:20:15 -0400 Jonathan Bither <[email protected]> wrote:

When our driver device is removed on the AHB bus, our IO memory is never unmapped.

Signed-off-by Jonathan Bither <[email protected]>
(quoted diff) +0 -0

b/drivers/net/wireless/ath/ath5k/ahb.c index 8c50d9d..aec33cc 100644

drivers/net/wireless/ath/ath5k/ahb.c static int ath_ahb_remove(struct platform_device · line 225

Quoted 6 lines
drivers/net/wireless/ath/ath5k/ahb.c +1 -0
@@ -220,6 +220,7 @@ static int ath_ahb_remove(struct platform_device
 *pdev) }
 
 	ath5k_deinit_ah(ah);
+	iounmap(ah->iobase);
 	platform_set_drvdata(pdev, NULL);
 	ieee80211_free_hw(hw);
Reviewed-by Pavel Roskin <[email protected]>
Signature · 2 lines
Regards,
Pavel Roskin