Skip to contentSkip to conversation

Ext4: use try_to_writeback_inodes_sb() instead of writeback_inodes_sb_if_idle()

PATCH In review Miao Xie 1 participant 1 message Apr 26, 2012

Subsystems (2)
VFS ext4 file system
lore
Share & tools
lore

Miao Xie

author
#0 lore raw

PATCH 3/4 Ext4: use try_to_writeback_inodes_sb() instead of writeback_inodes_sb_if_idle()

If the s_umount is write locked, then the sb is not idle. IOWs, writeback_inodes_sb...if_idle() should be doing down_read_trylock(), not down_read(). So use try_to_writeback_inodes_sb() instead of writeback_inodes_sb_if_idle().

Signed-off-by Miao Xie <[email protected]>
---
 fs/ext4/inode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/ext4/inode.c +1 -1
index c77b0bd..2dccb4d 100644
@@ -2380,7 +2380,7 @@ static int ext4_nonda_switch(struct super_block *sb)
 	 * start pushing delalloc when 1/2 of free blocks are dirty.
 	 */
 	if (free_blocks < 2 * dirty_blocks)
-		writeback_inodes_sb_if_idle(sb, WB_REASON_FS_FREE_SPACE);
+		try_to_writeback_inodes_sb(sb, WB_REASON_FS_FREE_SPACE);
 
 	return 0;
 }
Signature · 1 line
1.7.6.5