Skip to contentSkip to conversation

patman: Add meaningful statements instead of blah blah

PATCH New Vikram Narayanan 2 participants 3 messages Apr 27, 2012 – Apr 30, 2012

lore
Share & tools
lore

Vikram Narayanan

author
#0 lore raw

PATCH v2 2/4 patman: Add meaningful statements instead of blah blah

Add example statements for commit message and series messages

Signed-off-by Vikram Narayanan <[email protected]>
Cc Simon Glass <[email protected]>
---
 tools/patman/README |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
tools/patman/README +4 -5
index d9820ab..d98f081 100644
@@ -132,16 +132,15 @@ Series-prefix: prefix
 
 Cover-letter:
 This is the patch set title
-blah blah
-more blah blah
+This patch set fixes the errors when CONFIG_xxx is enabled.
+Tested on xyz board.
 END
 	Sets the cover letter contents for the series. The first line
 	will become the subject of the cover letter
 
 Series-notes:
-blah blah
-blah blah
-more blah blah
+Sorry that I couldn't find time to reply for the comments posted on the v1 of my
+patch. This patch supersedes v1. Please comment.
 END
 	Sets some notes for the patch series, which you don't want in
 	the commit messages, but do want to send, The notes are joined
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH v2 2/4 patman: Add meaningful statements instead of blah blah

Dear Vikram Narayanan,

Quoted 23 lines · In message <[email protected]> you wrote:

Add example statements for commit message and series messages

Signed-off-by Vikram Narayanan <[email protected]>
Cc Simon Glass <[email protected]>
---
 tools/patman/README |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
tools/patman/README +2 -2
index d9820ab..d98f081 100644
@@ -132,16 +132,15 @@ Series-prefix: prefix
 
 Cover-letter:
 This is the patch set title
-blah blah
-more blah blah
+This patch set fixes the errors when CONFIG_xxx is enabled.
+Tested on xyz board.
 END
 	Sets the cover letter contents for the series. The first line
 	will become the subject of the cover letter

tools/patman/README Series-prefix: prefix · line 146

Quoted 10 lines
tools/patman/README +2 -3
 
 Series-notes:
-blah blah
-blah blah
-more blah blah
+Sorry that I couldn't find time to reply for the comments posted on the v1 of my
+patch. This patch supersedes v1. Please comment.
 END
 	Sets some notes for the patch series, which you don't want in
 	the commit messages, but do want to send, The notes are joined

I'm not sure this is an improvement. Your example messages are pretty much specific, so people in completely different situations will not find much help in them either.

I suggest we leave the text as is. What do you think?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Our business is run on trust.  We trust you will pay in advance.
author
#2 lore raw

PATCH v2 2/4 patman: Add meaningful statements instead of blah blah

Hello Wolfgang,

Quoted 11 lines · Wolfgang Denk

Dear Vikram Narayanan,

Quoted 8 lines · In message<[email protected]> you wrote:

Add example statements for commit message and series messages

Signed-off-by Vikram Narayanan<[email protected]>
Cc Simon Glass<[email protected]>
---
  tools/patman/README |    9 ++++-----
  1 files changed, 4 insertions(+), 5 deletions(-)

<snip>

Quoted 5 lines

I'm not sure this is an improvement. Your example messages are pretty much specific, so people in completely different situations will not find much help in them either.

I suggest we leave the text as is. What do you think?

Yes. Then, its better to leave as it is.

Regards,
Vikram