Skip to contentSkip to conversation

clean up TLB_FLUSH_ALL definition?

PATCH Alex Shi 1 participant 1 message May 10, 2012 x86

lore
Share & tools
lore

Alex Shi

author
#0 lore raw

why we need the different definition for TLB_FLUSH_ALL in 32 or 64 bits mode in commit d291cf83639?

#ifdef CONFIG_X86_32
-# include "tlbflush_32.h"
+# define TLB_FLUSH_ALL 0xffffffff
#else
-# include "tlbflush_64.h"
+# define TLB_FLUSH_ALL -1ULL
+#endif

If it's possible to unify it as following?

#define TLB_FLUSH_ALL -1UL

-----------------

Quoted 1 line

From 928db8019f7f66470a6a6188f870ec9a6f108a8c Mon Sep 17 00:00:00 2001

From: Alex Shi <[email protected]>
Date: Thu, 10 May 2012 18:01:59 +0800
Subject: [PATCH] x86/tlb: clean up and unify TLB_FLUSH_ALL definition

Since sizeof(long) is 4 in x86_32 mode, and it's 8 in x86_64 mode, sizeof(long long) is also 8 byte in x86_64 mode.
use long mode can fit TLB_FLUSH_ALL defination here both in 32 or 64 bits mode.

---
 arch/x86/include/asm/tlbflush.h |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)
arch/x86/include/asm/tlbflush.h +1 -5
index c0e108e..7e8a096 100644
@@ -62,11 +62,7 @@ static inline void __flush_tlb_one(unsigned long addr)
 		__flush_tlb();
 }
 
-#ifdef CONFIG_X86_32
-# define TLB_FLUSH_ALL	0xffffffff
-#else
-# define TLB_FLUSH_ALL	-1ULL
-#endif
+#define TLB_FLUSH_ALL	-1UL
 
 /*
  * TLB flushing:
Signature · 1 line
1.7.0.1