Skip to contentSkip to conversation

create lib/tizen directory

PATCH New Donghwa Lee 5 participants 8 messages May 10, 2012 – May 24, 2012

lore
Share & tools
lore
#1 lore raw

PATCH v5 2/3 create lib/tizen directory

Quoted 34 lines · Donghwa Lee

From 01bebda80c7cb128048e4c1c89f2b5b1cdbfd67d Mon Sep 17 00:00:00 2001
From: Donghwa Lee <[email protected]>
Date: Thu, 10 May 2012 12:02:55 +0900
Subject: [PATCH] v5: create lib/tizen directory

This directory includes tizen logo data, common tizen library and so on.

Signed-off-by Donghwa Lee <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---
Changes for v4:
? ? ? ?- remove get_tizen_hd_logo* functions and get data directly ? ? ? ?- changes tizen hd logo data variables name
? ? ? ?- get_tizen_logo_info() uses parameter that vidinfo_t *vid.

Changes for v3:
? ? ? ?- create common get logo infomation function. ? ? ? ?- define logo resolution

Changes for v2:
? ? ? ?- create lib/tizen directory and moves logo data to lib/tizen. ? ? ? ?- create common tizen library function.
? ? ? ?- changes patch name from "LCD: add compressed 32bpp BMP image data" ? ? ? ?to crete lib/tizen directory

Changes for v1:
? ? ? ?- moves to logo data from arch/arm to include/

?Makefile ? ? ? ? ? ? ? ? ? ? ? | ? ?1 +
?include/libtizen.h ? ? ? ? ? ? | ? 30 +
?lib/tizen/Makefile ? ? ? ? ? ? | ? 46 +
?lib/tizen/tizen.c ? ? ? ? ? ? ?| ? 40 +
?lib/tizen/tizen_hd_logo.h ? ? ?| 5071 ++++++++++++++++++++++++++++++++++++++++
?lib/tizen/tizen_hd_logo_data.h | ? 30 +
Quoted 7 lines

?6 files changed, 5218 insertions(+), 0 deletions(-) ?create mode 100644 include/libtizen.h ?create mode 100644 lib/tizen/Makefile ?create mode 100644 lib/tizen/tizen.c ?create mode 100644 lib/tizen/tizen_hd_logo.h ?create mode 100644 lib/tizen/tizen_hd_logo_data.h

Acked-by Minkyu Kang <[email protected]>
Signature · 2 lines
from. prom.
www.promsoft.net
#2 lore raw

PATCH v5 2/3 create lib/tizen directory

In reply to Donghwa Lee
Quoted 6 lines · On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
 Makefile                       |    1 +
 include/libtizen.h             |   30 +
 lib/tizen/Makefile             |   46 +
 lib/tizen/tizen.c              |   40 +
 lib/tizen/tizen_hd_logo.h      | 5071

lib/tizen/tizen_hd_logo_data.h | 30 +

do you really need your own lib/tizen/ dir for a logo ? every one who doesn't build this still has to waste time going into lib/tizen/ to create an empty object. at least make the addition of lib/tizen/ depend on CONFIG_TIZEN too.

also, where are the boards that actually use this ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120514/e14c8035/attachment.pgp>

#3 lore raw

PATCH v5 2/3 create lib/tizen directory

Hi,

Quoted 8 lines · Mike Frysinger
Quoted 6 lines · On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
 Makefile                       |    1 +
 include/libtizen.h             |   30 +
 lib/tizen/Makefile             |   46 +
 lib/tizen/tizen.c              |   40 +
 lib/tizen/tizen_hd_logo.h      | 5071

lib/tizen/tizen_hd_logo_data.h | 30 +

Quoted 6 lines

do you really need your own lib/tizen/ dir for a logo ? every one who doesn't
build this still has to waste time going into lib/tizen/ to create an empty

object. at least make the addition of lib/tizen/ depend on CONFIG_TIZEN too.

It uses the same method as others does.
e.g., libfdt

In Makefile
LIBS += lib/libfdt/libfdt.o

In "lib/libfdt/Makefile"
SOBJS =

COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o

COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)

Quoted 2 lines

also, where are the boards that actually use this ?

board/samsung/trats uses this logo.

Thank you,
Kyungmin Park

#4 lore raw

PATCH v5 2/3 create lib/tizen directory

Quoted 24 lines · On Monday 14 May 2012 01:37:10 Kyungmin Park wrote:
Quoted 9 lines · Mike Frysinger
Quoted 7 lines · On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
 Makefile                       |    1 +
 include/libtizen.h             |   30 +
 lib/tizen/Makefile             |   46 +
 lib/tizen/tizen.c              |   40 +
 lib/tizen/tizen_hd_logo.h      | 5071

lib/tizen/tizen_hd_logo_data.h | 30 +

Quoted 7 lines

do you really need your own lib/tizen/ dir for a logo ? every one who doesn't
build this still has to waste time going into lib/tizen/ to create an empty

object. at least make the addition of lib/tizen/ depend on CONFIG_TIZEN too.

It uses the same method as others does.
e.g., libfdt

In Makefile
LIBS += lib/libfdt/libfdt.o

Quoted 7 lines

In "lib/libfdt/Makefile"
SOBJS =

COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o

COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)

the difference is they have more than one CONFIG symbol going on, and their code base is sizable, and many arches/boards utilize it. you're adding a single file with a single function with a single CONFIG knob for a single board.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120514/dc30be80/attachment.pgp>

#5 lore raw

PATCH v5 2/3 create lib/tizen directory

Quoted 31 lines · Mike Frysinger
Quoted 30 lines · On Monday 14 May 2012 01:37:10 Kyungmin Park wrote:
Quoted 9 lines · Mike Frysinger
Quoted 7 lines · On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
 Makefile                       |    1 +
 include/libtizen.h             |   30 +
 lib/tizen/Makefile             |   46 +
 lib/tizen/tizen.c              |   40 +
 lib/tizen/tizen_hd_logo.h      | 5071

lib/tizen/tizen_hd_logo_data.h | 30 +

Quoted 8 lines

do you really need your own lib/tizen/ dir for a logo ? every one who doesn't
build this still has to waste time going into lib/tizen/ to create an empty

object. at least make the addition of lib/tizen/ depend on CONFIG_TIZEN
too.

It uses the same method as others does.
e.g., libfdt

In Makefile
LIBS += lib/libfdt/libfdt.o

In "lib/libfdt/Makefile"
SOBJS =

COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o

Quoted 8 lines
Quoted 2 lines

COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)

the difference is they have more than one CONFIG symbol going on, and their

code base is sizable, and many arches/boards utilize it. you're adding a single file with a single function with a single CONFIG knob for a single board.

Right, So we asked it first, which directory is proper. and suggested that the create the lib/tizen instead of others. since it's not platform, nor soc specific.

Of course this suggestion from Wolfgang.

Thank you,
Kyungmin Park

#6 lore raw

PATCH v5 2/3 create lib/tizen directory

Quoted 38 lines · On Monday 14 May 2012 03:27:55 Kyungmin Park wrote:
Quoted 37 lines · Mike Frysinger
Quoted 24 lines · On Monday 14 May 2012 01:37:10 Kyungmin Park wrote:
Quoted 8 lines · Mike Frysinger
Quoted 6 lines · On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
 Makefile                       |    1 +
 include/libtizen.h             |   30 +
 lib/tizen/Makefile             |   46 +
 lib/tizen/tizen.c              |   40 +
 lib/tizen/tizen_hd_logo.h      | 5071

lib/tizen/tizen_hd_logo_data.h | 30 +

Quoted 8 lines

do you really need your own lib/tizen/ dir for a logo ? every one who doesn't
build this still has to waste time going into lib/tizen/ to create an empty

object. at least make the addition of lib/tizen/ depend on CONFIG_TIZEN
too.

It uses the same method as others does.
e.g., libfdt

In Makefile
LIBS += lib/libfdt/libfdt.o

Quoted 8 lines

In "lib/libfdt/Makefile"
SOBJS =

COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o

COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)

the difference is they have more than one CONFIG symbol going on, and their

Quoted 7 lines
Quoted 3 lines

code base is sizable, and many arches/boards utilize it. you're adding a single file with a single function with a single CONFIG knob for a single board.

Right, So we asked it first, which directory is proper. and suggested that the create the lib/tizen instead of others. since it's not platform, nor soc specific.

you can still do in the top level to avoid affecting other people:
ifeq ($(CONFIG_TIZEN),y)
LIBS += lib/tizen/libtizen.o
endif
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120515/fb96b4f3/attachment.pgp>

#7 lore raw

PATCH v5 2/3 create lib/tizen directory

In reply to Donghwa Lee

Hi,

Quoted 28 lines · On Thu, 10 May 2012 14:23:40 +0900 Donghwa Lee <[email protected]> wrote:

From 01bebda80c7cb128048e4c1c89f2b5b1cdbfd67d Mon Sep 17 00:00:00 2001
From: Donghwa Lee <[email protected]>
Date: Thu, 10 May 2012 12:02:55 +0900
Subject: [PATCH] v5: create lib/tizen directory

This directory includes tizen logo data, common tizen library and so on.

Signed-off-by Donghwa Lee <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---
Changes for v4:
- remove get_tizen_hd_logo* functions and get data directly
- changes tizen hd logo data variables name
- get_tizen_logo_info() uses parameter that vidinfo_t *vid.

Changes for v3:
- create common get logo infomation function.
- define logo resolution

Changes for v2:
- create lib/tizen directory and moves logo data to lib/tizen.
- create common tizen library function.
- changes patch name from "LCD: add compressed 32bpp BMP image data" to crete lib/tizen directory

Changes for v1:
- moves to logo data from arch/arm to include/

Quoted 12 lines
 Makefile                       |    1 +
 include/libtizen.h             |   30 +
 lib/tizen/Makefile             |   46 +
 lib/tizen/tizen.c              |   40 +
 lib/tizen/tizen_hd_logo.h      | 5071 ++++++++++++++++++++++++++++++++++++++++
 lib/tizen/tizen_hd_logo_data.h |   30 +
 6 files changed, 5218 insertions(+), 0 deletions(-)
 create mode 100644 include/libtizen.h
 create mode 100644 lib/tizen/Makefile
 create mode 100644 lib/tizen/tizen.c
 create mode 100644 lib/tizen/tizen_hd_logo.h
 create mode 100644 lib/tizen/tizen_hd_logo_data.h

Applied to u-boot-video/master after changing to conditionally build lib/tizen/ directory. Thanks.

Anatolij