Skip to contentSkip to conversation

Duplicate labels in dts files

DISCUSSION Stephen Warren 3 participants 4 messages May 18, 2012 – May 21, 2012

lore
Share & tools
lore
#0 lore raw

The following arch/arm/boot/dts/*.dts all have duplicate label definitions, albeit all duplicates pointing at the same node. Is this expected? This does work OK with the in-kernel dtc and latest mainline dtc, but triggered some error-checks in a dtc patch that I have locally, which allows node/property deletion. I think the duplicate labels should probably be removed - do you agree?

at91sam9g25ek.dts
label: nand0
defined at at91sam9x5.dtsi:233
defined at at91sam9x5cm.dtsi:27

imx53-ard.dts
label: uart1
defined at imx53.dtsi:185
defined at imx53-ard.dts:43

imx6q-sabresd.dts
label: uart1
defined at imx6q.dtsi:168
defined at imx6q-sabresd.dts:28

#1 lore raw
Quoted 3 lines · Stephen Warren

The following arch/arm/boot/dts/*.dts all have duplicate label definitions, albeit all duplicates pointing at the same node. Is this expected?

At least for IMX, I would say, yes.

For example, when I have the following node in imx53.dtsi and need to have it in imx53-ard.dts, the first line of the node definition will be naturally copied into imx53-ard.dts. As the result, the label "uart1" will be "duplicated".

	uart1: serial at 53fbc000 {
		...
	};
Quoted 5 lines

This does work OK with the in-kernel dtc and latest mainline dtc, but triggered some error-checks in a dtc patch that I have locally, which allows node/property deletion. I think the duplicate labels should probably be removed - do you agree?

I hardly think so. You probably would agree that we shouldn't say the node is duplicated, since the node will still be one in dtb. Then, as long as the label points to the same node, we should not say the label is duplicated either.

Signature · 2 lines
Regards,
Shawn
#2 lore raw

On 05/19/2012 04:56 AM, Shawn Guo :

Quoted 7 lines · Stephen Warren
Quoted 3 lines

The following arch/arm/boot/dts/*.dts all have duplicate label definitions, albeit all duplicates pointing at the same node. Is this expected?

At least for IMX, I would say, yes.

Quoted 8 lines

For example, when I have the following node in imx53.dtsi and need to have it in imx53-ard.dts, the first line of the node definition will be naturally copied into imx53-ard.dts. As the result, the label "uart1" will be "duplicated".

	uart1: serial at 53fbc000 {
		...
	};

Well, for AT91, I would say it is intended.
As explained by Shawn, The node definition is simply copied.

Quoted 9 lines
Quoted 5 lines

This does work OK with the in-kernel dtc and latest mainline dtc, but triggered some error-checks in a dtc patch that I have locally, which allows node/property deletion. I think the duplicate labels should probably be removed - do you agree?

I hardly think so. You probably would agree that we shouldn't say the node is duplicated, since the node will still be one in dtb. Then, as long as the label points to the same node, we should not say the label is duplicated either.

I agree with Shawn: If the node definition is not copied literally (including the label), I fear that DT newbies will not understand the meaning of this. Moreover, it would be harder to manage includes and nodes definitions (while creating a board file out of a SoC file for example).

So, please keep the in-kernel dtc behavior.

Best regards,

Signature · 1 line
Nicolas Ferre
#3 lore raw
In reply to Shawn Guo
Quoted 5 lines · Shawn Guo
Quoted 3 lines · Stephen Warren

The following arch/arm/boot/dts/*.dts all have duplicate label definitions, albeit all duplicates pointing at the same node. Is this expected?

Quoted 8 lines

At least for IMX, I would say, yes.

For example, when I have the following node in imx53.dtsi and need to have it in imx53-ard.dts, the first line of the node definition will be naturally copied into imx53-ard.dts. As the result, the label "uart1" will be "duplicated".

	uart1: serial at 53fbc000 {

There's no need to duplicate the label here; that line would work just fine as:

	serial at 53fbc000 {

Writing that doesn't remove the label from the node at all.