Skip to contentSkip to conversation

scripts/patch-kernel: fix typos and compression comment

PATCH In review Randy Dunlap 2 participants 3 messages May 21, 2012 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 scripts/patch-kernel: fix typos and compression comment

From: Randy Dunlap <[email protected]>

Fix typo, drop trailing whitespace, and add "xz" to list of compression types supported.

---
 scripts/patch-kernel |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/patch-kernel +3 -3
@@ -26,8 +26,8 @@
 #
 #       Nick Holloway <[email protected]>, 2nd January 1995.
 #
-# Added support for handling multiple types of compression. What includes
-# gzip, bzip, bzip2, zip, compress, and plaintext. 
+# Added support for handling multiple types of compression. That includes
+# gzip, bzip, bzip2, zip, compress, xz, and plaintext.
 #
 #       Adam Sulmicki <[email protected]>, 1st January 1997.
 #
@@ -159,7 +159,7 @@ applyPatch () {
   fi
   # Remove backup files
   find $sourcedir/ '(' -name '*.orig' -o -name '.*.orig' ')' -exec rm -f {} \;
- 
+
   return 0;
 }
 
#1 lore raw
Quoted 13 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix typo, drop trailing whitespace, and add "xz" to list of compression types supported.

---
 scripts/patch-kernel |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

scripts/patch-kernel line 32

Quoted 9 lines
scripts/patch-kernel +2 -2
@@ -26,8 +26,8 @@
 #
 #       Nick Holloway <[email protected]>, 2nd January 1995.
 #
-# Added support for handling multiple types of compression. What includes
-# gzip, bzip, bzip2, zip, compress, and plaintext. 
+# Added support for handling multiple types of compression. That includes
+# gzip, bzip, bzip2, zip, compress, xz, and plaintext.
 #
 #       Adam Sulmicki <[email protected]>, 1st January 1997.

You are editing a changelog entry from time when xz did not exist. Why don't you instead add a note to the usage examples at the beginning of the script, that several compression formats are supported.

BTW, are you actually *using* this script? Wow, that would be two confirmed users in this calendar year alone :).

Michal

#2 lore raw
Quoted 11 lines · Michal Marek
Quoted 10 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix typo, drop trailing whitespace, and add "xz" to list of compression types supported.

---
 scripts/patch-kernel |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 16 lines

scripts/patch-kernel line 32

Quoted 12 lines
scripts/patch-kernel +2 -2
@@ -26,8 +26,8 @@
 #
 #       Nick Holloway <[email protected]>, 2nd January 1995.
 #
-# Added support for handling multiple types of compression. What includes
-# gzip, bzip, bzip2, zip, compress, and plaintext. 
+# Added support for handling multiple types of compression. That includes
+# gzip, bzip, bzip2, zip, compress, xz, and plaintext.
 #
 #       Adam Sulmicki <[email protected]>, 1st January 1997.

You are editing a changelog entry from time when xz did not exist. Why don't you instead add a note to the usage examples at the beginning of the script, that several compression formats are supported.

OK, I'll not edit the changelog entry. duh.

Quoted 2 lines

BTW, are you actually *using* this script? Wow, that would be two confirmed users in this calendar year alone :).

I doubt that anyone is using it successfully with 3.x, but I plan to make it useful.

Signature · 1 line
~Randy