Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI

Hello,

After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some err infos with latest
Linus's tree, does somebody also has the same issue?

sound/soc/omap/omap-hdmi.c:45:24: error: field 'dss_audio' has incomplete type
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_startup':
sound/soc/omap/omap-hdmi.c:67:27: error: 'struct omap_dss_driver' has no member named 'audio_supported'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
sound/soc/omap/omap-hdmi.c:79:29: error: 'struct omap_dss_driver' has no member named 'audio_enable'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_hw_params':
sound/soc/omap/omap-hdmi.c:208:28: error: 'struct omap_dss_driver' has no member named 'audio_config'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_trigger':
sound/soc/omap/omap-hdmi.c:224:29: error: 'struct omap_dss_driver' has no member named 'audio_start'

sound/soc/omap/omap-hdmi.c:229:23: error: 'struct omap_dss_driver' has no member named 'audio_stop'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_shutdown':
sound/soc/omap/omap-hdmi.c:242:22: error: 'struct omap_dss_driver' has no member named 'audio_disable'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
sound/soc/omap/omap-hdmi.c:80:1: warning: control reaches end of non-void function

Regards,
Xiao

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

+Tomi

Hi Xiao,

Quoted 20 lines · Xiao Jiang

Hello,

After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some err infos with latest
Linus's tree, does somebody also has the same issue?

sound/soc/omap/omap-hdmi.c:45:24: error: field 'dss_audio' has incomplete type
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_startup':
sound/soc/omap/omap-hdmi.c:67:27: error: 'struct omap_dss_driver' has no member named 'audio_supported'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
sound/soc/omap/omap-hdmi.c:79:29: error: 'struct omap_dss_driver' has no member named 'audio_enable'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_hw_params':
sound/soc/omap/omap-hdmi.c:208:28: error: 'struct omap_dss_driver' has no member named 'audio_config'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_trigger':
sound/soc/omap/omap-hdmi.c:224:29: error: 'struct omap_dss_driver' has no member named 'audio_start'

Quoted 8 lines

sound/soc/omap/omap-hdmi.c:229:23: error: 'struct omap_dss_driver' has no member named 'audio_stop'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_shutdown':
sound/soc/omap/omap-hdmi.c:242:22: error: 'struct omap_dss_driver' has no member named 'audio_disable'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
sound/soc/omap/omap-hdmi.c:80:1: warning: control reaches end of non-void function

Build breaks because there some patches [1] that are still missing in Linus' tree. ASoC HDMI audio driver for OMAP[2] now uses the new DSS audio functionality in [1], but ASoC patches were merged first. DSS patches have been accepted and they are part of Tomi's pull request for DSS for K3.5. Hopefully this will be fixed when v3.5-rc1 is out.

BR,

Ricardo

[1].http://www.spinics.net/lists/linux-omap/msg69466.html [2].http://www.spinics.net/lists/linux-omap/msg70561.html

Quoted 8 lines

Regards,
Xiao

Signature · 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Build breaks because there some patches [1] that are still missing in Linus' tree. ASoC HDMI audio driver for OMAP[2] now uses the new DSS audio functionality in [1], but ASoC patches were merged first. DSS patches have been accepted and they are part of Tomi's pull request for DSS for K3.5. Hopefully this will be fixed when v3.5-rc1 is out.

Quoted 6 lines · Ricardo Neri

Build breaks because there some patches [1] that are still missing in Linus' tree. ASoC HDMI audio driver for OMAP[2] now uses the new DSS audio functionality in [1], but ASoC patches were merged first. DSS patches have been accepted and they are part of Tomi's pull request for DSS for K3.5. Hopefully this will be fixed when v3.5-rc1 is out.

Then there was an error already in the process if dependent sets didn't go together via the same merge or in next merge window. Remember each commit must compile alone.

It's quite boring to try to bisect over multiple kernel versions and where most of the time goes solving random unrelated build breakages.

It's true that there's a commit range where the asoc stuff doesn't compile, and I agree that it's not good. But you need to explicitly enable the HDMI ASOC support to get the error.

Quoted 2 lines

It's quite boring to try to bisect over multiple kernel versions and where most of the time goes solving random unrelated build breakages.

How to get arm/arm/, omapdss, omapdrm and asoc driver changes in at the same time? All go through various different trees and maintainers. I haven't found a solution for this. If you have good ideas, please share =).

Quoted 4 lines · Tomi Valkeinen

It's true that there's a commit range where the asoc stuff doesn't compile, and I agree that it's not good. But you need to explicitly enable the HDMI ASOC support to get the error.

You can still hit the build breakage by randconfig or if it's enabled by default in the future and you start bisecting with that config old kernel.

Quoted 8 lines

Quoted 2 lines

It's quite boring to try to bisect over multiple kernel versions and where most of the time goes solving random unrelated build breakages.

How to get arm/arm/, omapdss, omapdrm and asoc driver changes in at the same time? All go through various different trees and maintainers. I haven't found a solution for this. If you have good ideas, please share =).

One simple - wait for next merge window. It's not that long. Only ~3 months and meanwhile one could keep boss/customer/wife/whatever satisfied by carrying patches in own tree :-)

Quoted 3 lines

One simple - wait for next merge window. It's not that long. Only ~3 months and meanwhile one could keep boss/customer/wife/whatever satisfied by carrying patches in own tree :-)

Well... I'm not sure how serious you are here =).

In some cases that's doable, and we've done it, for example omapdrm had some things delayed until next merge window, so it's definitely an option.

But it's quite easy to get some build dependencies between pull requests, so we'd be delaying features all the time. And sometimes even cross dependencies. In the worst case it could end up with delaying some features for a year to get all single pieces in bit by bit.

Something I think we could try to do is create some kinds of temporary dummy functions or such which allow the compilation, but of course makes the component not (fully) functional. The temp functions could then be removed in -rc2 or so, when the dependencies are all there. But doesn't feel like an optimal solution either...

Quoted 34 lines · Ricardo Neri

+Tomi

Hi Xiao,

Quoted 28 lines · Xiao Jiang

Hello,

After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some err infos with latest
Linus's tree, does somebody also has the same issue?

sound/soc/omap/omap-hdmi.c:45:24: error: field 'dss_audio' has incomplete type
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_startup':
sound/soc/omap/omap-hdmi.c:67:27: error: 'struct omap_dss_driver' has no member named 'audio_supported'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
sound/soc/omap/omap-hdmi.c:79:29: error: 'struct omap_dss_driver' has no member named 'audio_enable'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_hw_params':
sound/soc/omap/omap-hdmi.c:208:28: error: 'struct omap_dss_driver' has no member named 'audio_config'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_trigger':
sound/soc/omap/omap-hdmi.c:224:29: error: 'struct omap_dss_driver' has no member named 'audio_start' sound/soc/omap/omap-hdmi.c:229:23: error: 'struct omap_dss_driver' has no member named 'audio_stop'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_shutdown':
sound/soc/omap/omap-hdmi.c:242:22: error: 'struct omap_dss_driver' has no member named 'audio_disable'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
sound/soc/omap/omap-hdmi.c:80:1: warning: control reaches end of non-void function

Quoted 6 lines

Build breaks because there some patches [1] that are still missing in Linus' tree. ASoC HDMI audio driver for OMAP[2] now uses the new DSS audio functionality in [1], but ASoC patches were merged first. DSS patches have been accepted and they are part of Tomi's pull request for DSS for K3.5. Hopefully this will be fixed when v3.5-rc1 is out.

Ricardo, thanks for your detail infos :).

Regards,
Xiao

Quoted 15 lines

BR,

Ricardo

[1].http://www.spinics.net/lists/linux-omap/msg69466.html [2].http://www.spinics.net/lists/linux-omap/msg70561.html

Quoted 8 lines

Regards,
Xiao

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Xiao, Tomi, Jarkko,

Quoted 41 lines · Xiao Jiang

Quoted 40 lines · Ricardo Neri

+Tomi

Hi Xiao,

Quoted 20 lines · Xiao Jiang

Hello,

After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some err infos with latest
Linus's tree, does somebody also has the same issue?

sound/soc/omap/omap-hdmi.c:45:24: error: field 'dss_audio' has incomplete type
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_startup':
sound/soc/omap/omap-hdmi.c:67:27: error: 'struct omap_dss_driver' has no member named 'audio_supported'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
sound/soc/omap/omap-hdmi.c:79:29: error: 'struct omap_dss_driver' has no member named 'audio_enable'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_hw_params':
sound/soc/omap/omap-hdmi.c:208:28: error: 'struct omap_dss_driver' has no member named 'audio_config'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_trigger':
sound/soc/omap/omap-hdmi.c:224:29: error: 'struct omap_dss_driver' has no member named 'audio_start'

Quoted 8 lines

sound/soc/omap/omap-hdmi.c:229:23: error: 'struct omap_dss_driver' has no member named 'audio_stop'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_shutdown':
sound/soc/omap/omap-hdmi.c:242:22: error: 'struct omap_dss_driver' has no member named 'audio_disable'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
sound/soc/omap/omap-hdmi.c:80:1: warning: control reaches end of non-void function

Build breaks because there some patches [1] that are still missing in Linus' tree. ASoC HDMI audio driver for OMAP[2] now uses the new DSS audio functionality in [1], but ASoC patches were merged first. DSS patches have been accepted and they are part of Tomi's pull request for DSS for K3.5. Hopefully this will be fixed when v3.5-rc1 is out.

Quoted 1 line

Ricardo, thanks for your detail infos :).

Just wanted to confirm to you that this build break is not present in 3.5-rc1 as both omapdss and asoc dependencies are present.

Ricardo

Quoted 19 lines

Regards,
Xiao

Quoted 15 lines

BR,

Ricardo

[1].http://www.spinics.net/lists/linux-omap/msg69466.html [2].http://www.spinics.net/lists/linux-omap/msg70561.html

Quoted 8 lines

Regards,
Xiao

Signature · 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 47 lines · Ricardo Neri

Hi Xiao, Tomi, Jarkko,

Quoted 44 lines · Xiao Jiang

Quoted 43 lines · Ricardo Neri

+Tomi

Hi Xiao,

Quoted 23 lines · Xiao Jiang

Hello,

After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some
err infos with latest
Linus's tree, does somebody also has the same issue?

sound/soc/omap/omap-hdmi.c:45:24: error: field 'dss_audio' has incomplete type
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_startup':
sound/soc/omap/omap-hdmi.c:67:27: error: 'struct omap_dss_driver' has no
member named 'audio_supported'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
sound/soc/omap/omap-hdmi.c:79:29: error: 'struct omap_dss_driver' has no
member named 'audio_enable'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_hw_params':
sound/soc/omap/omap-hdmi.c:208:28: error: 'struct omap_dss_driver' has no member named 'audio_config'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_trigger':
sound/soc/omap/omap-hdmi.c:224:29: error: 'struct omap_dss_driver' has no member named 'audio_start'

Quoted 8 lines

sound/soc/omap/omap-hdmi.c:229:23: error: 'struct omap_dss_driver' has no member named 'audio_stop'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_shutdown':
sound/soc/omap/omap-hdmi.c:242:22: error: 'struct omap_dss_driver' has no member named 'audio_disable'
sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
sound/soc/omap/omap-hdmi.c:80:1: warning: control reaches end of non-void function

Build breaks because there some patches [1] that are still missing in Linus' tree. ASoC HDMI audio driver for OMAP[2] now uses the new DSS audio functionality in [1], but ASoC patches were merged first. DSS patches have been accepted and they are part of Tomi's pull request for DSS for K3.5. Hopefully this will be fixed when v3.5-rc1 is out.

Quoted 5 lines

Quoted 1 line

Ricardo, thanks for your detail infos :).

Just wanted to confirm to you that this build break is not present in 3.5-rc1 as both omapdss and asoc dependencies are present.

Hi Ricardo,

Good to know, but I can't get any voice with aplay, although penguins are appeared on
the hdmi tv. Pls see below infos.

root@panda:/root> aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0: OMAPHDMI [OMAPHDMI], device 0: HDMI omap-hdmi-hifi-0 []
Subdevices: 1/1
Subdevice #0: subdevice #0

root@panda:/root> alsamixer ▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒ AlsaMixer v1.0.21 ▒
▒ Card: OMAPHDMI F1: Help ▒
▒ Chip: F2: System information ▒
▒ View: F3: Playback F4: Capture F5: All F6: Select sound card ▒ ▒ Item: Esc: Exit ▒
▒ ▒
▒ ▒
▒ ▒
▒ This sound device does not have any controls. ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒ ▒
▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒

root@panda:/root> aplay audio48k16S.wav
Playing WAVE 'audio48k16S.wav' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo

But hdmi audio of imx6q board is ok with the same hdmi tv. Did I miss something else? thanks.

Regards,
Xiao

Quoted 22 lines

Ricardo

Quoted 20 lines

Regards,
Xiao

Quoted 16 lines

BR,

Ricardo

[1].http://www.spinics.net/lists/linux-omap/msg69466.html [2].http://www.spinics.net/lists/linux-omap/msg70561.html

Quoted 9 lines

Regards,
Xiao

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Do you see that the playback finishes (even though you don't hear anything)? Also, what version of Pandaboard are you using? Is it Pandaboard or PandaboardES? Have you tried on different TVs?

BR,
Ricardo