Skip to contentSkip to conversation

dapm_widget_power_read_file() symmetry issue?

DISCUSSION Stephen Warren 2 participants 2 messages Jun 4, 2012 – Jun 5, 2012

lore
Share & tools
lore
#0 lore raw

In dapm_widget_power_read_file(), there is first:

Quoted 3 lines
	list_for_each_entry(p, &w->sources, list_sink) {
		if (p->connected && !p->connected(w, p->sink))
			continue;

then right after that:

Quoted 3 lines
	list_for_each_entry(p, &w->sinks, list_source) {
		if (p->connected && !p->connected(w, p->sink))
			continue;

Should that last call to p->connected() be p->connected(p->source, w), since the function's parameters are (source, sink)?

#1 lore raw
Quoted 6 lines · Stephen Warren
Quoted 3 lines
	list_for_each_entry(p, &w->sinks, list_source) {
		if (p->connected && !p->connected(w, p->sink))
			continue;

Should that last call to p->connected() be p->connected(p->source, w), since the function's parameters are (source, sink)?

Probably, yes.