Skip to contentSkip to conversation

-Werror=old-style-definition and UST tracepoints

RFC PATCH Mathieu Desnoyers 1 participant 1 message Jun 11, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Mathieu Desnoyers

author
#1 lore raw

* Hollis Blanchard ([email protected]) wrote:
[...]

Quoted 4 lines

I believe the problem comes from -Werror=old-style-definition not liking that empty "()", i.e. tracepoint_cb_qemu_tb_hash___flushall() { ... }. The following patch seems to work for me; is there a reason it isn't already written this way?

Good catch !

Fixed as master commit:

commit 86637aa6452f66dee5f769461668c2ea059b3a30

Author: Mathieu Desnoyers <[email protected]>
Date:   Mon Jun 11 09:53:07 2012 -0400

Fix: tracepoint.h should not generate old-style definitions

and merged into stable-2.0.

Thanks!

Mathieu

Quoted 39 lines
include/lttng/tracepoint.h +0 -0

index 4b773bb..60d8c73 100644

--- a/include/lttng/tracepoint.h

+++ b/include/lttng/tracepoint.h

include/lttng/tracepoint.h +1 -1
@@ -88,7 +88,7 @@ extern "C" {
 
 #define _TP_EXDATA_VAR20(a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,r,s,t)      __tp_data,b,d,f,h,j,l,n,p,r,t
 
 
 
 /* _TP_EXPROTO* extract tuples of type, var */
 
-#define _TP_EXPROTO0()
 
+#define _TP_EXPROTO0()                                         void
 
 #define _TP_EXPROTO2(a,b)                                      a b
 
 #define _TP_EXPROTO4(a,b,c,d)                                  a b,c d
 
 #define _TP_EXPROTO6(a,b,c,d,e,f)                              a b,c d,e f

If this is OK, I'm happy to resend as a proper patch.

Signature · 8 lines
Hollis Blanchard
Mentor Graphics, Embedded Systems Division


_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Signature · 4 lines
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com