Skip to contentSkip to conversation

Boolean change of names.

DISCUSSION Daniel J Walsh 4 participants 10 messages Jun 11, 2012 SELinux security module

lore
Share & tools
lore
#0 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

We have started pushing a boolean change into Fedora 18.

https://fedoraproject.org/wiki/Features/SELinuxBooleansRename

The problem we are seeing is that boolean names used within an interface are causing the install to fail on rebuild of policy.

IE If I installed a custom policy with a boolean used in it, and the boolean changed then the module will blow up the policy compile.

interface(kerberos_manage_host_rcache',

	gen_require(`
		type krb5_host_rcache_t;
	')

...

	tunable_policy(`allow_kerberos',`
		allow $1 self:process setfscreate;
...
	')

...
')

And change the allow_kerberos to kerberos_enabled.

One idea would be to pull the translations into the semanage, or would I need to do this at a lower level. Or are we stuck with these bad names forever...

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/WGQEACgkQrlYvE4MpobOHYQCdEg6dag1f3ucskDiXohzcMITB pPQAoM21wP+O5Cgsiu2dmFGR+UcRaFne
=1UKe
-----END PGP SIGNATURE-----

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

#1 lore raw
Quoted 23 lines · Daniel J Walsh

We have started pushing a boolean change into Fedora 18.

https://fedoraproject.org/wiki/Features/SELinuxBooleansRename

The problem we are seeing is that boolean names used within an interface are causing the install to fail on rebuild of policy.

IE If I installed a custom policy with a boolean used in it, and the boolean changed then the module will blow up the policy compile.

interface(kerberos_manage_host_rcache',

	gen_require(`
		type krb5_host_rcache_t;
	')

...

	tunable_policy(`allow_kerberos',`
		allow $1 self:process setfscreate;
...
	')
Quoted 7 lines

...
')

And change the allow_kerberos to kerberos_enabled.

One idea would be to pull the translations into the semanage, or would I need to do this at a lower level. Or are we stuck with these bad names forever...

Adding boolean aliases to the policy language, including kernel support, seems like the best route if you truly want to do this.

Signature · 8 lines
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.
#2 lore raw
Quoted 27 lines · Stephen Smalley
Quoted 26 lines · Daniel J Walsh

We have started pushing a boolean change into Fedora 18.

https://fedoraproject.org/wiki/Features/SELinuxBooleansRename

The problem we are seeing is that boolean names used within an interface are causing the install to fail on rebuild of policy.

IE If I installed a custom policy with a boolean used in it, and the boolean changed then the module will blow up the policy compile.

interface(kerberos_manage_host_rcache',
      gen_require(`
              type krb5_host_rcache_t;
      ')

...

      tunable_policy(allow_kerberos',
              allow $1 self:process setfscreate;
...
      ')

...
')

Quoted 7 lines
Quoted 4 lines

And change the allow_kerberos to kerberos_enabled.

One idea would be to pull the translations into the semanage, or would I need to do this at a lower level.  Or are we stuck with these bad names forever...

Adding boolean aliases to the policy language, including kernel support, seems like the best route if you truly want to do this.

What does 'including kernel support' mean? Expose both names in the booleans/ directory?

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

#3 lore raw
Quoted 30 lines · Eric Paris
Quoted 29 lines · Stephen Smalley
Quoted 28 lines · Daniel J Walsh

We have started pushing a boolean change into Fedora 18.

https://fedoraproject.org/wiki/Features/SELinuxBooleansRename

The problem we are seeing is that boolean names used within an interface are causing the install to fail on rebuild of policy.

IE If I installed a custom policy with a boolean used in it, and the boolean changed then the module will blow up the policy compile.

interface(kerberos_manage_host_rcache',

      gen_require(`
              type krb5_host_rcache_t;
      ')

...

      tunable_policy(`allow_kerberos',`
              allow $1 self:process setfscreate;
...
      ')

...
')

And change the allow_kerberos to kerberos_enabled.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

One idea would be to pull the translations into the semanage, or would I need to do this at a lower level. Or are we stuck with these bad names forever...

Adding boolean aliases to the policy language, including kernel support, seems like the best route if you truly want to do this.

What does 'including kernel support' mean? Expose both names in the booleans/ directory?

Yes, you would need to do that if you want [gs]etsebool or semanage boolean to support use of either name.

I guess if you only want this support for policy modules, you could do it entirely within libsepol and have it remap all aliases to their primary names during policy link/expand.

Signature · 8 lines
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.
#9 lore raw
In reply to Stephen Smalley

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 22 lines · Stephen Smalley
Quoted 21 lines · Daniel J Walsh

We have started pushing a boolean change into Fedora 18.

https://fedoraproject.org/wiki/Features/SELinuxBooleansRename

The problem we are seeing is that boolean names used within an interface are causing the install to fail on rebuild of policy.

IE If I installed a custom policy with a boolean used in it, and the boolean changed then the module will blow up the policy compile.

interface(kerberos_manage_host_rcache', gen_require(` type krb5_host_rcache_t; ')

...

tunable_policy(allow_kerberos', allow $1 self:process setfscreate; ... ')

... ')

Quoted 9 lines
Quoted 5 lines

And change the allow_kerberos to kerberos_enabled.

One idea would be to pull the translations into the semanage, or would I need to do this at a lower level. Or are we stuck with these bad names forever...

Adding boolean aliases to the policy language, including kernel support, seems like the best route if you truly want to do this.

I disagree, this is just a translation problem. We can build it into the toolchain and not dirty up the kernel.

I would prefer to go with the simpler root and not dirty up /sys/fs/selinux/booleans.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/WLK8ACgkQrlYvE4MpobN8AwCgvk9TPyuDdTyAqXnkKVtSAn1m 6sEAoOVm5f86/PFhbSeZXXRernQr/lxn
=BA5Z
-----END PGP SIGNATURE-----

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

#4 lore raw
In reply to Stephen Smalley

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 37 lines · Stephen Smalley
Quoted 30 lines · Eric Paris
Quoted 28 lines · Stephen Smalley
Quoted 26 lines · Daniel J Walsh

We have started pushing a boolean change into Fedora 18.

https://fedoraproject.org/wiki/Features/SELinuxBooleansRename

The problem we are seeing is that boolean names used within an interface are causing the install to fail on rebuild of policy.

IE If I installed a custom policy with a boolean used in it, and the boolean changed then the module will blow up the policy compile.

interface(kerberos_manage_host_rcache', gen_require(` type krb5_host_rcache_t; ')

...

tunable_policy(allow_kerberos', allow $1 self:process setfscreate; ... ')

... ')

And change the allow_kerberos to kerberos_enabled.

One idea would be to pull the translations into the semanage, or would I need to do this at a lower level. Or are we stuck with these bad names forever...

Quoted 5 lines
Quoted 2 lines

Adding boolean aliases to the policy language, including kernel support, seems like the best route if you truly want to do this.

What does 'including kernel support' mean? Expose both names in the booleans/ directory?

Quoted 8 lines

Yes, you would need to do that if you want [gs]etsebool or semanage boolean to support use of either name.

I guess if you only want this support for policy modules, you could do it entirely within libsepol and have it remap all aliases to their primary names during policy link/expand.

Yes that is what I am suggesting. Can libsepol call into libselinux? I have exported an selinux_boolean_sub function which returns either the translated name or the original.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/WLQ8ACgkQrlYvE4MpobOUZQCdF4HYNPZo+qRLnFBmv5K7ly+D B2MAn34JnQfdR/l68UBPZ6sB3gUVOHuJ
=h9DE
-----END PGP SIGNATURE-----

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

#5 lore raw
Quoted 41 lines · Daniel J Walsh
Quoted 40 lines · Stephen Smalley
Quoted 30 lines · Eric Paris
Quoted 28 lines · Stephen Smalley
Quoted 26 lines · Daniel J Walsh

We have started pushing a boolean change into Fedora 18.

https://fedoraproject.org/wiki/Features/SELinuxBooleansRename

The problem we are seeing is that boolean names used within an interface are causing the install to fail on rebuild of policy.

IE If I installed a custom policy with a boolean used in it, and the boolean changed then the module will blow up the policy compile.

interface(kerberos_manage_host_rcache', gen_require(` type krb5_host_rcache_t; ')

...

tunable_policy(allow_kerberos', allow $1 self:process setfscreate; ... ')

... ')

And change the allow_kerberos to kerberos_enabled.

One idea would be to pull the translations into the semanage, or would I need to do this at a lower level. Or are we stuck with these bad names forever...

Quoted 5 lines
Quoted 2 lines

Adding boolean aliases to the policy language, including kernel support, seems like the best route if you truly want to do this.

What does 'including kernel support' mean? Expose both names in the booleans/ directory?

Yes, you would need to do that if you want [gs]etsebool or semanage boolean to support use of either name.

Quoted 8 lines
Quoted 5 lines

I guess if you only want this support for policy modules, you could do it entirely within libsepol and have it remap all aliases to their primary names during policy link/expand.

Yes that is what I am suggesting. Can libsepol call into libselinux? I have exported an selinux_boolean_sub function which returns either the translated name or the original.

No, libsepol isn't supposed to call libselinux. Tools like checkpolicy that call libsepol need to work even on non-SELinux (and even non-Linux) platforms.

Signature · 8 lines
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.
#7 lore raw
In reply to Stephen Smalley

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 37 lines · Stephen Smalley
Quoted 30 lines · Eric Paris
Quoted 28 lines · Stephen Smalley
Quoted 26 lines · Daniel J Walsh

We have started pushing a boolean change into Fedora 18.

https://fedoraproject.org/wiki/Features/SELinuxBooleansRename

The problem we are seeing is that boolean names used within an interface are causing the install to fail on rebuild of policy.

IE If I installed a custom policy with a boolean used in it, and the boolean changed then the module will blow up the policy compile.

interface(kerberos_manage_host_rcache', gen_require(` type krb5_host_rcache_t; ')

...

tunable_policy(allow_kerberos', allow $1 self:process setfscreate; ... ')

... ')

And change the allow_kerberos to kerberos_enabled.

One idea would be to pull the translations into the semanage, or would I need to do this at a lower level. Or are we stuck with these bad names forever...

Quoted 5 lines
Quoted 2 lines

Adding boolean aliases to the policy language, including kernel support, seems like the best route if you truly want to do this.

What does 'including kernel support' mean? Expose both names in the booleans/ directory?

Quoted 8 lines

Yes, you would need to do that if you want [gs]etsebool or semanage boolean to support use of either name.

I guess if you only want this support for policy modules, you could do it entirely within libsepol and have it remap all aliases to their primary names during policy link/expand.

Adding a
boolalias newbool alias oldbool;

Is fine with me, although I still think we would need to generate a translation table for libselinux.

getsebool allow_ypbind
nis_enabled --> off

And the kernel does not see the aliases.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/WL6gACgkQrlYvE4MpobM7DQCglWRmFTs5UAsO2RiJMiDc5F+0 BK0AoOrmGk7uS3MJD9Vxu5/CkO3LHHSr
=HgF6
-----END PGP SIGNATURE-----

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

#6 lore raw
In reply to Stephen Smalley
Quoted 5 lines · Stephen Smalley

On Mon, 2012-06-11 at 13:38 -0400, Daniel J Walsh wrote:

No, libsepol isn't supposed to call libselinux.  Tools like checkpolicy that call libsepol need to work even on non-SELinux (and even non-Linux) platforms.

Agreed alternate names should be a first class citizen and part of policy proper. I'm trying to decide if we should move the get/set translator to load the policydb and find alternates that way or should we generate the alternate names as a file at build time and use that small translation file (like we tried today)?

-Eric

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

#8 lore raw
In reply to Stephen Smalley
Quoted 40 lines · Stephen Smalley
Quoted 30 lines · Eric Paris
Quoted 29 lines · Stephen Smalley
Quoted 28 lines · Daniel J Walsh

We have started pushing a boolean change into Fedora 18.

https://fedoraproject.org/wiki/Features/SELinuxBooleansRename

The problem we are seeing is that boolean names used within an interface are causing the install to fail on rebuild of policy.

IE If I installed a custom policy with a boolean used in it, and the boolean changed then the module will blow up the policy compile.

interface(kerberos_manage_host_rcache',

      gen_require(`
              type krb5_host_rcache_t;
      ')

...

      tunable_policy(`allow_kerberos',`
              allow $1 self:process setfscreate;
...
      ')

...
')

And change the allow_kerberos to kerberos_enabled.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

One idea would be to pull the translations into the semanage, or would I need to do this at a lower level. Or are we stuck with these bad names forever...

Adding boolean aliases to the policy language, including kernel support, seems like the best route if you truly want to do this.

What does 'including kernel support' mean? Expose both names in the booleans/ directory?

Quoted 6 lines

Yes, you would need to do that if you want [gs]etsebool or semanage boolean to support use of either name.

I guess if you only want this support for policy modules, you could do it entirely within libsepol and have it remap all aliases to their primary names during policy link/expand.

Also, if there are any local Boolean states in semanage (i.e. setsebool -P), they'd have to be migrated to the new symbol name too.

Signature · 10 lines
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com



--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.